mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Sebastian Andrzej Siewior" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: irq/cleanups] iio: magnetometer: Remove IRQF_ONESHOT
Date: Sun, 01 Feb 2026 17:13:35 -0000	[thread overview]
Message-ID: <176996601558.2495410.11210142983544784172.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260128095540.863589-19-bigeasy@linutronix.de>

The following commit has been merged into the irq/cleanups branch of tip:

Commit-ID:     25974af8028aa638f33ef46cb9ae6a9b4206aa49
Gitweb:        https://git.kernel.org/tip/25974af8028aa638f33ef46cb9ae6a9b4206aa49
Author:        Sebastian Andrzej Siewior <bigeasy@linutronix.de>
AuthorDate:    Wed, 28 Jan 2026 10:55:38 +01:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Sun, 01 Feb 2026 17:37:17 +01:00

iio: magnetometer: Remove IRQF_ONESHOT

Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.

The flag also prevents force-threading of the primary handler and the
irq-core will warn about this.

The force-threading functionality is required on PREEMPT_RT because the
handler is using locks with can sleep on PREEMPT_RT.

Remove IRQF_ONESHOT from irqflags.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Link: https://patch.msgid.link/20260128095540.863589-19-bigeasy@linutronix.de
---
 drivers/iio/magnetometer/ak8975.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index 3fd0171..d30315a 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -581,7 +581,7 @@ static int ak8975_setup_irq(struct ak8975_data *data)
 		irq = gpiod_to_irq(data->eoc_gpiod);
 
 	rc = devm_request_irq(&client->dev, irq, ak8975_irq_handler,
-			      IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+			      IRQF_TRIGGER_RISING,
 			      dev_name(&client->dev), data);
 	if (rc < 0) {
 		dev_err(&client->dev, "irq %d request failed: %d\n", irq, rc);

  parent reply	other threads:[~2026-02-01 17:13 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  9:55 [PATCH v2 00/20] IRQF_ONESHOT clean up Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 01/20] genirq: Set IRQF_COND_ONESHOT in devm_request_irq() Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 02/20] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq() Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 03/20] iommu/amd: Use core's primary handler and set IRQF_ONESHOT Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 04/20] mailbox: bcm-ferxrm-mailbox: Use default primary handler Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-02-02  0:56   ` [PATCH v2 04/20] " Jassi Brar
2026-01-28  9:55 ` [PATCH v2 05/20] bus: fsl-mc: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 06/20] Bluetooth: btintel_pcie: Use IRQF_ONESHOT and " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 07/20] scsi: efct: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 08/20] ARM: versatile: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 09/20] char: tpm: cr50: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 10/20] EDAC/altera: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 11/20] usb: typec: fusb302: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 12/20] rtc: amlogic-a4: " Sebastian Andrzej Siewior
2026-01-28 11:28   ` (subset) " Alexandre Belloni
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 13/20] thermal/qcom/lmh: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 14/20] perf/cxlpmu: " Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 15/20] mfd: wm8350-core: Use IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-28 13:07   ` Andy Shevchenko
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 16/20] iio: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-28 13:03   ` Andy Shevchenko
2026-01-29 16:11     ` Jonathan Cameron
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 17/20] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-29 16:12   ` Jonathan Cameron
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 18/20] iio: magnetometer: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-28 13:04   ` Andy Shevchenko
2026-01-29 16:13     ` Jonathan Cameron
2026-02-01 17:13   ` tip-bot2 for Sebastian Andrzej Siewior [this message]
2026-01-28  9:55 ` [PATCH v2 19/20] iio: adc: ad7766: Use iio_trigger_generic_data_rdy_poll() Sebastian Andrzej Siewior
2026-01-28 13:05   ` Andy Shevchenko
2026-01-29 16:14     ` Jonathan Cameron
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 20/20] media: pci: mg4b: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-02-03  8:23   ` tip-bot2 for Sebastian Andrzej Siewior
2026-02-03 13:22   ` [PATCH v2 20/20] " Martin Tůma
2026-01-28 16:12 ` [PATCH v2 00/20] IRQF_ONESHOT clean up Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176996601558.2495410.11210142983544784172.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=andriy.shevchenko@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®