mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: "Thomas Gleixner" <tglx@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
	"Hans de Goede" <johannes.goede@oss.qualcomm.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Hans de Goede" <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH v2 02/20] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq()
Date: Wed, 28 Jan 2026 10:55:22 +0100	[thread overview]
Message-ID: <20260128095540.863589-3-bigeasy@linutronix.de> (raw)
In-Reply-To: <20260128095540.863589-1-bigeasy@linutronix.de>

Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.

The flag was added to match the flag on the shared handler which uses a
threaded handler and therefore IRQF_ONESHOT. This is no longer needed
because devm_request_irq() now passes IRQF_COND_ONESHOT for this case.

Revert adding IRQF_ONESHOT to irqflags.

Reported-by: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>
Closes: https://lore.kernel.org/all/555f1c56-0f74-41bf-8bd2-6217e0aab0c6@intel.com
Fixes: 8f812373d1958 ("platform/x86: intel: int0002_vgpio: Pass IRQF_ONESHOT to request_irq()")
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
Cc: Hans de Goede <hansg@kernel.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org
---
 drivers/platform/x86/intel/int0002_vgpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/x86/intel/int0002_vgpio.c
index 6f5629dc3f8db..562e880256436 100644
--- a/drivers/platform/x86/intel/int0002_vgpio.c
+++ b/drivers/platform/x86/intel/int0002_vgpio.c
@@ -206,8 +206,8 @@ static int int0002_probe(struct platform_device *pdev)
 	 * FIXME: augment this if we managed to pull handling of shared
 	 * IRQs into gpiolib.
 	 */
-	ret = devm_request_irq(dev, irq, int0002_irq,
-			       IRQF_ONESHOT | IRQF_SHARED, "INT0002", chip);
+	ret = devm_request_irq(dev, irq, int0002_irq, IRQF_SHARED, "INT0002",
+			       chip);
 	if (ret) {
 		dev_err(dev, "Error requesting IRQ %d: %d\n", irq, ret);
 		return ret;
-- 
2.51.0


  parent reply	other threads:[~2026-01-28  9:55 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  9:55 [PATCH v2 00/20] IRQF_ONESHOT clean up Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 01/20] genirq: Set IRQF_COND_ONESHOT in devm_request_irq() Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` Sebastian Andrzej Siewior [this message]
2026-02-01 17:13   ` [tip: irq/cleanups] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq() tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 03/20] iommu/amd: Use core's primary handler and set IRQF_ONESHOT Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 04/20] mailbox: bcm-ferxrm-mailbox: Use default primary handler Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-02-02  0:56   ` [PATCH v2 04/20] " Jassi Brar
2026-01-28  9:55 ` [PATCH v2 05/20] bus: fsl-mc: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 06/20] Bluetooth: btintel_pcie: Use IRQF_ONESHOT and " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 07/20] scsi: efct: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 08/20] ARM: versatile: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 09/20] char: tpm: cr50: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 10/20] EDAC/altera: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 11/20] usb: typec: fusb302: " Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 12/20] rtc: amlogic-a4: " Sebastian Andrzej Siewior
2026-01-28 11:28   ` (subset) " Alexandre Belloni
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 13/20] thermal/qcom/lmh: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 14/20] perf/cxlpmu: " Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 15/20] mfd: wm8350-core: Use IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-28 13:07   ` Andy Shevchenko
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 16/20] iio: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-28 13:03   ` Andy Shevchenko
2026-01-29 16:11     ` Jonathan Cameron
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 17/20] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-29 16:12   ` Jonathan Cameron
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 18/20] iio: magnetometer: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-28 13:04   ` Andy Shevchenko
2026-01-29 16:13     ` Jonathan Cameron
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 19/20] iio: adc: ad7766: Use iio_trigger_generic_data_rdy_poll() Sebastian Andrzej Siewior
2026-01-28 13:05   ` Andy Shevchenko
2026-01-29 16:14     ` Jonathan Cameron
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28  9:55 ` [PATCH v2 20/20] media: pci: mg4b: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-02-01 17:13   ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-02-03  8:23   ` tip-bot2 for Sebastian Andrzej Siewior
2026-02-03 13:22   ` [PATCH v2 20/20] " Martin Tůma
2026-01-28 16:12 ` [PATCH v2 00/20] IRQF_ONESHOT clean up Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128095540.863589-3-bigeasy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®