From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Lee Jones <lee@kernel.org>,
patches@opensource.cirrus.com, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 15/20] mfd: wm8350-core: Use IRQF_ONESHOT
Date: Wed, 28 Jan 2026 15:07:00 +0200 [thread overview]
Message-ID: <aXoJ9JIYINR_KXro@smile.fi.intel.com> (raw)
In-Reply-To: <20260128095540.863589-16-bigeasy@linutronix.de>
On Wed, Jan 28, 2026 at 10:55:35AM +0100, Sebastian Andrzej Siewior wrote:
> Using a threaded interrupt without a dedicated primary handler mandates
> the IRQF_ONESHOT flag to mask the interrupt source while the threaded
> handler is active. Otherwise the interrupt can fire again before the
> threaded handler had a chance to run.
>
> Mark explained that this should not happen with this hardware since it
> is a slow irqchip which is behind an I2C/ SPI bus but the IRQ-core will
> refuse to accept such a handler.
>
> Set IRQF_ONESHOT so the interrupt source is masked until the secondary
> handler is done.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-28 13:07 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 9:55 [PATCH v2 00/20] IRQF_ONESHOT clean up Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 01/20] genirq: Set IRQF_COND_ONESHOT in devm_request_irq() Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 02/20] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq() Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 03/20] iommu/amd: Use core's primary handler and set IRQF_ONESHOT Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 04/20] mailbox: bcm-ferxrm-mailbox: Use default primary handler Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-02-02 0:56 ` [PATCH v2 04/20] " Jassi Brar
2026-01-28 9:55 ` [PATCH v2 05/20] bus: fsl-mc: " Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 06/20] Bluetooth: btintel_pcie: Use IRQF_ONESHOT and " Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 07/20] scsi: efct: " Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 08/20] ARM: versatile: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 09/20] char: tpm: cr50: " Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 10/20] EDAC/altera: " Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 11/20] usb: typec: fusb302: " Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 12/20] rtc: amlogic-a4: " Sebastian Andrzej Siewior
2026-01-28 11:28 ` (subset) " Alexandre Belloni
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 13/20] thermal/qcom/lmh: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 14/20] perf/cxlpmu: " Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 15/20] mfd: wm8350-core: Use IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-28 13:07 ` Andy Shevchenko [this message]
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 16/20] iio: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-28 13:03 ` Andy Shevchenko
2026-01-29 16:11 ` Jonathan Cameron
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 17/20] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-29 16:12 ` Jonathan Cameron
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 18/20] iio: magnetometer: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-28 13:04 ` Andy Shevchenko
2026-01-29 16:13 ` Jonathan Cameron
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 19/20] iio: adc: ad7766: Use iio_trigger_generic_data_rdy_poll() Sebastian Andrzej Siewior
2026-01-28 13:05 ` Andy Shevchenko
2026-01-29 16:14 ` Jonathan Cameron
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-01-28 9:55 ` [PATCH v2 20/20] media: pci: mg4b: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-02-01 17:13 ` [tip: irq/cleanups] " tip-bot2 for Sebastian Andrzej Siewior
2026-02-03 8:23 ` tip-bot2 for Sebastian Andrzej Siewior
2026-02-03 13:22 ` [PATCH v2 20/20] " Martin Tůma
2026-01-28 16:12 ` [PATCH v2 00/20] IRQF_ONESHOT clean up Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXoJ9JIYINR_KXro@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®