* [PATCH] arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity sensor
@ 2026-02-25 14:43 Erikas Bitovtas
2026-02-25 14:48 ` Konrad Dybcio
2026-03-18 13:50 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Erikas Bitovtas @ 2026-02-25 14:43 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas
This device uses Capella CM36686 as its ambient light and proximity
sensor. It is fully compatible with Vishay VCNL4040. Downstream device
tree reports Capella CM36283, but upon probe, a device ID for CM36686 is
actually found. This commit adds support for Capella CM36686 ambient
light and proximity sensor.
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity
sensor
This device uses Capella CM36686 as its ambient light and proximity
sensor. Downstream device tree uses the compatible of CM36283, but upon
probe, we can see that a device ID of CM36686 is actually read. Possibly
a driver for CM36283 was adapted to be used on CM36686.
This patch enables Capella CM36686 ambient light and proximity sensor on
Asus ZenFone 2 Laser/Selfie.
---
arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts b/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts
index ea90b00a2c8a..1a340fa92755 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts
@@ -147,6 +147,17 @@ magnetometer@c {
pinctrl-names = "default";
};
+ light-sensor@60 {
+ compatible = "capella,cm36686", "vishay,vcnl4040";
+ reg = <0x60>;
+
+ interrupts-extended = <&tlmm 113 IRQ_TYPE_EDGE_FALLING>;
+ proximity-near-level = <30>;
+
+ pinctrl-0 = <&light_int_default>;
+ pinctrl-names = "default";
+ };
+
imu@68 {
compatible = "invensense,mpu6515";
reg = <0x68>;
@@ -330,4 +341,11 @@ mag_reset_default: mag-reset-default-state {
drive-strength = <2>;
bias-disable;
};
+
+ light_int_default: light-int-default-state {
+ pins = "gpio113";
+ function = "gpio";
+ drive-strength = <16>;
+ bias-pull-up;
+ };
};
---
base-commit: 3ef088b0c5772a6f75634e54aa34f5fc0a2c041c
change-id: 20260225-z00t-capella-sensor-dfd37c2960f6
Best regards,
--
Erikas Bitovtas <xerikasxx@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity sensor
2026-02-25 14:43 [PATCH] arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity sensor Erikas Bitovtas
@ 2026-02-25 14:48 ` Konrad Dybcio
2026-03-18 13:50 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-02-25 14:48 UTC (permalink / raw)
To: Erikas Bitovtas, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 2/25/26 3:43 PM, Erikas Bitovtas wrote:
> This device uses Capella CM36686 as its ambient light and proximity
> sensor. It is fully compatible with Vishay VCNL4040. Downstream device
> tree reports Capella CM36283, but upon probe, a device ID for CM36686 is
> actually found. This commit adds support for Capella CM36686 ambient
> light and proximity sensor.
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity
> sensor
>
> This device uses Capella CM36686 as its ambient light and proximity
> sensor. Downstream device tree uses the compatible of CM36283, but upon
> probe, we can see that a device ID of CM36686 is actually read. Possibly
> a driver for CM36283 was adapted to be used on CM36686.
> This patch enables Capella CM36686 ambient light and proximity sensor on
> Asus ZenFone 2 Laser/Selfie.
Downstream using vaguely-related compatibles is ""standard practice"",
many vendor drivers don't really care about semantic correctness,
as you were able to find out via the chip ID register
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity sensor
2026-02-25 14:43 [PATCH] arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity sensor Erikas Bitovtas
2026-02-25 14:48 ` Konrad Dybcio
@ 2026-03-18 13:50 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-03-18 13:50 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Erikas Bitovtas
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On Wed, 25 Feb 2026 16:43:24 +0200, Erikas Bitovtas wrote:
> This device uses Capella CM36686 as its ambient light and proximity
> sensor. It is fully compatible with Vishay VCNL4040. Downstream device
> tree reports Capella CM36283, but upon probe, a device ID for CM36686 is
> actually found. This commit adds support for Capella CM36686 ambient
> light and proximity sensor.
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity sensor
commit: 83a06a3afb36818f09d68490d5939e7e56cb96d2
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-18 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-25 14:43 [PATCH] arm64: dts: qcom: msm8939-asus-z00t: add ambient light and proximity sensor Erikas Bitovtas
2026-02-25 14:48 ` Konrad Dybcio
2026-03-18 13:50 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®