* [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message
@ 2026-05-12 10:33 Chen-Yu Tsai
2026-05-12 10:41 ` Hans Zhang
2026-05-19 14:27 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2026-05-12 10:33 UTC (permalink / raw)
To: Matthias Brugger, AngeloGioacchino Del Regno, Ryder Lee,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
Krzysztof Kozlowski, Conor Dooley
Cc: Chen-Yu Tsai, devicetree, linux-pci, linux-mediatek,
linux-kernel, Dan Carpenter
When pwrctrl integration was added, the error message for when
pci_pwrctrl_create_devices() fails was incorrectly put after the error
goto statement, causing it to be skipped.
Move the goto statement after the dev_err_probe() call so that the
error message actually gets printed (or saved if probe is deferred).
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/all/adjNaKB5KGpl6qIp@stanley.mountain/
Fixes: 1a152e21940a ("PCI: mediatek-gen3: Integrate new pwrctrl API")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index 6f0ae946d501..ef64778bbf8b 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -1221,8 +1221,8 @@ static int mtk_pcie_probe(struct platform_device *pdev)
err = pci_pwrctrl_create_devices(pcie->dev);
if (err) {
- goto err_tear_down_irq;
dev_err_probe(dev, err, "failed to create pwrctrl devices\n");
+ goto err_tear_down_irq;
}
err = mtk_pcie_setup(pcie);
--
2.54.0.563.g4f69b47b94-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message
2026-05-12 10:33 [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message Chen-Yu Tsai
@ 2026-05-12 10:41 ` Hans Zhang
2026-05-19 14:27 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Hans Zhang @ 2026-05-12 10:41 UTC (permalink / raw)
To: Chen-Yu Tsai, Matthias Brugger, AngeloGioacchino Del Regno,
Ryder Lee, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
Krzysztof Kozlowski, Conor Dooley
Cc: devicetree, linux-pci, linux-mediatek, linux-kernel, Dan Carpenter
On 5/12/26 18:33, Chen-Yu Tsai wrote:
> When pwrctrl integration was added, the error message for when
> pci_pwrctrl_create_devices() fails was incorrectly put after the error
> goto statement, causing it to be skipped.
>
> Move the goto statement after the dev_err_probe() call so that the
> error message actually gets printed (or saved if probe is deferred).
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/all/adjNaKB5KGpl6qIp@stanley.mountain/
> Fixes: 1a152e21940a ("PCI: mediatek-gen3: Integrate new pwrctrl API")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Hans Zhang <18255117159@163.com>
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index 6f0ae946d501..ef64778bbf8b 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -1221,8 +1221,8 @@ static int mtk_pcie_probe(struct platform_device *pdev)
>
> err = pci_pwrctrl_create_devices(pcie->dev);
> if (err) {
> - goto err_tear_down_irq;
> dev_err_probe(dev, err, "failed to create pwrctrl devices\n");
> + goto err_tear_down_irq;
> }
>
> err = mtk_pcie_setup(pcie);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message
2026-05-12 10:33 [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message Chen-Yu Tsai
2026-05-12 10:41 ` Hans Zhang
@ 2026-05-19 14:27 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2026-05-19 14:27 UTC (permalink / raw)
To: Matthias Brugger, AngeloGioacchino Del Regno, Ryder Lee,
Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring,
Bjorn Helgaas, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai
Cc: devicetree, linux-pci, linux-mediatek, linux-kernel, Dan Carpenter
On Tue, 12 May 2026 18:33:45 +0800, Chen-Yu Tsai wrote:
> When pwrctrl integration was added, the error message for when
> pci_pwrctrl_create_devices() fails was incorrectly put after the error
> goto statement, causing it to be skipped.
>
> Move the goto statement after the dev_err_probe() call so that the
> error message actually gets printed (or saved if probe is deferred).
>
> [...]
Applied, thanks!
[1/1] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message
commit: 8ba433753d9b131c2e43b1ff7ba8c5730cef8231
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-19 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-12 10:33 [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message Chen-Yu Tsai
2026-05-12 10:41 ` Hans Zhang
2026-05-19 14:27 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®