* [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses
@ 2026-06-03 11:20 Andy Shevchenko
2026-06-03 12:25 ` Andrew Lunn
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Andy Shevchenko @ 2026-06-03 11:20 UTC (permalink / raw)
To: Andy Shevchenko, netdev, linux-kernel
Cc: Linus Walleij, Alvin Šipraga, Andrew Lunn, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Convert to %pM instead of using custom code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/dsa/realtek/rtl8366rb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
index d96ae72b0a5c..103039fe3086 100644
--- a/drivers/net/dsa/realtek/rtl8366rb.c
+++ b/drivers/net/dsa/realtek/rtl8366rb.c
@@ -573,8 +573,7 @@ static int rtl8366rb_set_addr(struct realtek_priv *priv)
eth_random_addr(addr);
- dev_info(priv->dev, "set MAC: %02X:%02X:%02X:%02X:%02X:%02X\n",
- addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
+ dev_info(priv->dev, "set MAC: %pM\n", addr);
val = addr[0] << 8 | addr[1];
ret = regmap_write(priv->map, RTL8366RB_SMAR0, val);
if (ret)
--
2.50.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses
2026-06-03 11:20 [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses Andy Shevchenko
@ 2026-06-03 12:25 ` Andrew Lunn
2026-06-03 12:38 ` Nicolai Buchwitz
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2026-06-03 12:25 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, Linus Walleij, Alvin Šipraga,
Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Wed, Jun 03, 2026 at 01:20:11PM +0200, Andy Shevchenko wrote:
> Convert to %pM instead of using custom code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses
2026-06-03 11:20 [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses Andy Shevchenko
2026-06-03 12:25 ` Andrew Lunn
@ 2026-06-03 12:38 ` Nicolai Buchwitz
2026-06-04 20:18 ` Linus Walleij
2026-06-05 1:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Nicolai Buchwitz @ 2026-06-03 12:38 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, Linus Walleij, Alvin Šipraga,
Andrew Lunn, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
On 3.6.2026 13:20, Andy Shevchenko wrote:
> Convert to %pM instead of using custom code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/dsa/realtek/rtl8366rb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/realtek/rtl8366rb.c
> b/drivers/net/dsa/realtek/rtl8366rb.c
> index d96ae72b0a5c..103039fe3086 100644
> --- a/drivers/net/dsa/realtek/rtl8366rb.c
> +++ b/drivers/net/dsa/realtek/rtl8366rb.c
> @@ -573,8 +573,7 @@ static int rtl8366rb_set_addr(struct realtek_priv
> *priv)
>
> eth_random_addr(addr);
>
> - dev_info(priv->dev, "set MAC: %02X:%02X:%02X:%02X:%02X:%02X\n",
> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
> + dev_info(priv->dev, "set MAC: %pM\n", addr);
> val = addr[0] << 8 | addr[1];
> ret = regmap_write(priv->map, RTL8366RB_SMAR0, val);
> if (ret)
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
Thanks
Nicolai
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses
2026-06-03 11:20 [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses Andy Shevchenko
2026-06-03 12:25 ` Andrew Lunn
2026-06-03 12:38 ` Nicolai Buchwitz
@ 2026-06-04 20:18 ` Linus Walleij
2026-06-05 1:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2026-06-04 20:18 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, Alvin Šipraga, Andrew Lunn,
Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Wed, Jun 3, 2026 at 1:20 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Convert to %pM instead of using custom code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses
2026-06-03 11:20 [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses Andy Shevchenko
` (2 preceding siblings ...)
2026-06-04 20:18 ` Linus Walleij
@ 2026-06-05 1:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-05 1:20 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, linusw, alsi, andrew, olteanv, davem,
edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 3 Jun 2026 13:20:11 +0200 you wrote:
> Convert to %pM instead of using custom code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/dsa/realtek/rtl8366rb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
- [net-next,v1,1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses
https://git.kernel.org/netdev/net-next/c/c1424df7ff82
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-05 1:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-03 11:20 [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses Andy Shevchenko
2026-06-03 12:25 ` Andrew Lunn
2026-06-03 12:38 ` Nicolai Buchwitz
2026-06-04 20:18 ` Linus Walleij
2026-06-05 1:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®