[PATCH] ASoC: fs210x: Make cache write through again during resume

[PATCH] ASoC: fs210x: Make cache write through again during resume

[Mark Brown]

The fs210x driver currently puts the regmap cache into cache only mode
during suspend but at no point does it make it writable again, meaning
that device can't work after suspend other than basic powerup which
bypasses the cache.

Mark the cache as writable again when we resync the registers, it's not
clear to me that the cache only mode is needed at all but this is a
fairly minimal change.  Since this is setting a flag it's safe to do
even if the cache was not previously in cache only mode.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/fs210x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/fs210x.c b/sound/soc/codecs/fs210x.c
index 5f381fe063e8..d794ff918b6f 100644
--- a/sound/soc/codecs/fs210x.c
+++ b/sound/soc/codecs/fs210x.c
@@ -607,6 +607,7 @@ static int fs210x_init_chip(struct fs210x_priv *fs210x)
 
 	regcache_cache_bypass(fs210x->regmap, false);
 	if (!ret) {
+		regcache_cache_only(fs210x->regmap, false);
 		regcache_mark_dirty(fs210x->regmap);
 		regcache_sync(fs210x->regmap);
 		fs210x->is_inited = true;

---
base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
change-id: 20260715-asoc-fs210x-fix-resume-30f9ac19c120

Best regards,
--  
Mark Brown <broonie@kernel.org>

Re: [PATCH] ASoC: fs210x: Make cache write through again during resume

[Cezary Rojewski]

On 7/15/2026 10:16 PM, Mark Brown wrote:
> The fs210x driver currently puts the regmap cache into cache only mode
> during suspend but at no point does it make it writable again, meaning
> that device can't work after suspend other than basic powerup which
> bypasses the cache.
> 
> Mark the cache as writable again when we resync the registers, it's not
> clear to me that the cache only mode is needed at all but this is a
> fairly minimal change.  Since this is setting a flag it's safe to do
> even if the cache was not previously in cache only mode.
The first paragraph seems to mark this patch as a good Fixes: candidate. 
  That's just a nitpick though.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

Re: [PATCH] ASoC: fs210x: Make cache write through again during resume

[Mark Brown]

On Wed, 15 Jul 2026 21:16:48 +0100, Mark Brown wrote:
> ASoC: fs210x: Make cache write through again during resume

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2

Thanks!

[1/1] ASoC: fs210x: Make cache write through again during resume
      https://git.kernel.org/broonie/sound/c/7dcf091da4b4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark