[PATCH net-next] net: dsa: motorcomm: Handle degenerated blink delays

[PATCH net-next] net: dsa: motorcomm: Handle degenerated blink delays

[David Yang]

The LED core defines delay_on == 0 as steady off and delay_off == 0 as
steady on, which was treated as a blink in our LED driver. Fix it.

Fixes: 9af9a8168213 ("net: dsa: motorcomm: Add LED support")
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
 drivers/net/dsa/motorcomm/leds.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/dsa/motorcomm/leds.c b/drivers/net/dsa/motorcomm/leds.c
index 7d3c0f68d8ff..87a6b9cf6068 100644
--- a/drivers/net/dsa/motorcomm/leds.c
+++ b/drivers/net/dsa/motorcomm/leds.c
@@ -107,6 +107,8 @@ yt921x_led_blink_set(struct yt921x_priv *priv, int port, int group,
 		       YT921X_LED_DUTY(1, 2);
 
 		use_cycle = false;
+	} else if (!*onp || !*offp) {
+		return yt921x_led_force_set(priv, port, group, *onp);
 	} else {
 		res = yt921x_led_blink_select(priv, *onp, *offp, &cycle, &duty);
 		if (res)
-- 
2.53.0

Re: [PATCH net-next] net: dsa: motorcomm: Handle degenerated blink delays

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri,  4 Sep 2026 21:47:46 +0800 you wrote:
> The LED core defines delay_on == 0 as steady off and delay_off == 0 as
> steady on, which was treated as a blink in our LED driver. Fix it.
> 
> Fixes: 9af9a8168213 ("net: dsa: motorcomm: Add LED support")
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
>  drivers/net/dsa/motorcomm/leds.c | 2 ++
>  1 file changed, 2 insertions(+)

Here is the summary with links:
  - [net-next] net: dsa: motorcomm: Handle degenerated blink delays
    https://git.kernel.org/netdev/net-next/c/10973152f2f8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html