* [PATCH] irqchip: riscv-imsic: Expose the fwnode via the global config
@ 2026-10-02 12:04 Prajwal N
2026-10-02 17:06 ` Anup Patel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Prajwal N @ 2026-10-02 12:04 UTC (permalink / raw)
To: anup, tglx, radu, pjw, palmer, aou, alex
Cc: linux-riscv, linux-kernel, prajwal.n.oss, Prajwal N
The fwnode describes a global property of the IMSIC interrupt
controller that is equally relevant to external consumers of
imsic_global_config as it is to the imsic_priv itself.
Keeping it in imsic_priv forces the external drivers to access
the private structure rather than using the already exported
imsic_get_global_config() interface.
Moving the fwnode into imsic_global_config makes the public
API self-contained and eliminates the need for callers to
access imsic_priv internals directly.
Signed-off-by: Prajwal N <prajwal.n@oss.qualcomm.com>
---
drivers/irqchip/irq-riscv-imsic-early.c | 2 +-
drivers/irqchip/irq-riscv-imsic-platform.c | 18 +++++++++---------
drivers/irqchip/irq-riscv-imsic-state.c | 2 +-
drivers/irqchip/irq-riscv-imsic-state.h | 3 ---
include/linux/irqchip/riscv-imsic.h | 3 +++
5 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/irqchip/irq-riscv-imsic-early.c b/drivers/irqchip/irq-riscv-imsic-early.c
index 12efd241ce88..769849147148 100644
--- a/drivers/irqchip/irq-riscv-imsic-early.c
+++ b/drivers/irqchip/irq-riscv-imsic-early.c
@@ -75,7 +75,7 @@ static int __init imsic_ipi_domain_init(void)
riscv_ipi_set_virq_range(virq, IMSIC_NR_IPI);
/* Announce that IMSIC is providing IPIs */
- pr_info("%pfwP: providing IPIs using interrupt %d\n", imsic->fwnode, IMSIC_IPI_ID);
+ pr_info("%pfwP: providing IPIs using interrupt %d\n", imsic->global.fwnode, IMSIC_IPI_ID);
return 0;
}
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 643c8e459611..95ff76e63a69 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -313,40 +313,40 @@ int imsic_irqdomain_init(void)
};
struct imsic_global_config *global;
- if (!imsic || !imsic->fwnode) {
+ if (!imsic || !imsic->global.fwnode) {
pr_err("early driver not probed\n");
return -ENODEV;
}
if (imsic->base_domain) {
- pr_err("%pfwP: irq domain already created\n", imsic->fwnode);
+ pr_err("%pfwP: irq domain already created\n", imsic->global.fwnode);
return -ENODEV;
}
/* Create Base IRQ domain */
- info.fwnode = imsic->fwnode,
+ info.fwnode = imsic->global.fwnode,
imsic->base_domain = msi_create_parent_irq_domain(&info, &imsic_msi_parent_ops);
if (!imsic->base_domain) {
- pr_err("%pfwP: failed to create IMSIC base domain\n", imsic->fwnode);
+ pr_err("%pfwP: failed to create IMSIC base domain\n", imsic->global.fwnode);
return -ENOMEM;
}
global = &imsic->global;
pr_info("%pfwP: hart-index-bits: %d, guest-index-bits: %d\n",
- imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
+ imsic->global.fwnode, global->hart_index_bits, global->guest_index_bits);
pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
- imsic->fwnode, global->group_index_bits, global->group_index_shift);
+ imsic->global.fwnode, global->group_index_bits, global->group_index_shift);
pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
- imsic->fwnode, global->nr_ids, &global->base_addr);
+ imsic->global.fwnode, global->nr_ids, &global->base_addr);
pr_info("%pfwP: total %d interrupts available\n",
- imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
+ imsic->global.fwnode, num_possible_cpus() * (global->nr_ids - 1));
return 0;
}
static int imsic_platform_probe_common(struct fwnode_handle *fwnode)
{
- if (imsic && imsic->fwnode != fwnode) {
+ if (imsic && imsic->global.fwnode != fwnode) {
pr_err("%pfwP: fwnode mismatch\n", fwnode);
return -ENODEV;
}
diff --git a/drivers/irqchip/irq-riscv-imsic-state.c b/drivers/irqchip/irq-riscv-imsic-state.c
index b8d1bbbf42f7..ae982f89318b 100644
--- a/drivers/irqchip/irq-riscv-imsic-state.c
+++ b/drivers/irqchip/irq-riscv-imsic-state.c
@@ -813,9 +813,9 @@ int __init imsic_setup_state(struct fwnode_handle *fwnode, void *opaque)
imsic = kzalloc_obj(*imsic);
if (!imsic)
return -ENOMEM;
- imsic->fwnode = fwnode;
global = &imsic->global;
+ global->fwnode = fwnode;
global->local = alloc_percpu(typeof(*global->local));
if (!global->local) {
rc = -ENOMEM;
diff --git a/drivers/irqchip/irq-riscv-imsic-state.h b/drivers/irqchip/irq-riscv-imsic-state.h
index c42ee180b305..178b678f5c0f 100644
--- a/drivers/irqchip/irq-riscv-imsic-state.h
+++ b/drivers/irqchip/irq-riscv-imsic-state.h
@@ -44,9 +44,6 @@ struct imsic_local_priv {
};
struct imsic_priv {
- /* Device details */
- struct fwnode_handle *fwnode;
-
/* Global configuration common for all HARTs */
struct imsic_global_config global;
diff --git a/include/linux/irqchip/riscv-imsic.h b/include/linux/irqchip/riscv-imsic.h
index 61af3a5bea09..b7be1aad7774 100644
--- a/include/linux/irqchip/riscv-imsic.h
+++ b/include/linux/irqchip/riscv-imsic.h
@@ -46,6 +46,9 @@ struct imsic_local_config {
};
struct imsic_global_config {
+ /* Device details */
+ struct fwnode_handle *fwnode;
+
/*
* MSI Target Address Scheme
*
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] irqchip: riscv-imsic: Expose the fwnode via the global config
2026-10-02 12:04 [PATCH] irqchip: riscv-imsic: Expose the fwnode via the global config Prajwal N
@ 2026-10-02 17:06 ` Anup Patel
2026-10-15 10:22 ` [tip: irq/drivers] irqchip/riscv-imsic: " tip-bot2 for Prajwal N
2026-11-01 22:16 ` [PATCH] irqchip: riscv-imsic: " patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: Anup Patel @ 2026-10-02 17:06 UTC (permalink / raw)
To: Prajwal N
Cc: tglx, radu, pjw, palmer, aou, alex, linux-riscv, linux-kernel,
prajwal.n.oss, Sunil V L
+Sunil
On Fri, Oct 2, 2026 at 5:34 PM Prajwal N <prajwal.n@oss.qualcomm.com> wrote:
>
> The fwnode describes a global property of the IMSIC interrupt
> controller that is equally relevant to external consumers of
> imsic_global_config as it is to the imsic_priv itself.
>
> Keeping it in imsic_priv forces the external drivers to access
> the private structure rather than using the already exported
> imsic_get_global_config() interface.
>
> Moving the fwnode into imsic_global_config makes the public
> API self-contained and eliminates the need for callers to
> access imsic_priv internals directly.
>
> Signed-off-by: Prajwal N <prajwal.n@oss.qualcomm.com>
> ---
> drivers/irqchip/irq-riscv-imsic-early.c | 2 +-
> drivers/irqchip/irq-riscv-imsic-platform.c | 18 +++++++++---------
> drivers/irqchip/irq-riscv-imsic-state.c | 2 +-
> drivers/irqchip/irq-riscv-imsic-state.h | 3 ---
> include/linux/irqchip/riscv-imsic.h | 3 +++
> 5 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/irqchip/irq-riscv-imsic-early.c b/drivers/irqchip/irq-riscv-imsic-early.c
> index 12efd241ce88..769849147148 100644
> --- a/drivers/irqchip/irq-riscv-imsic-early.c
> +++ b/drivers/irqchip/irq-riscv-imsic-early.c
> @@ -75,7 +75,7 @@ static int __init imsic_ipi_domain_init(void)
> riscv_ipi_set_virq_range(virq, IMSIC_NR_IPI);
>
> /* Announce that IMSIC is providing IPIs */
> - pr_info("%pfwP: providing IPIs using interrupt %d\n", imsic->fwnode, IMSIC_IPI_ID);
> + pr_info("%pfwP: providing IPIs using interrupt %d\n", imsic->global.fwnode, IMSIC_IPI_ID);
>
> return 0;
> }
> diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
> index 643c8e459611..95ff76e63a69 100644
> --- a/drivers/irqchip/irq-riscv-imsic-platform.c
> +++ b/drivers/irqchip/irq-riscv-imsic-platform.c
> @@ -313,40 +313,40 @@ int imsic_irqdomain_init(void)
> };
> struct imsic_global_config *global;
>
> - if (!imsic || !imsic->fwnode) {
> + if (!imsic || !imsic->global.fwnode) {
> pr_err("early driver not probed\n");
> return -ENODEV;
> }
>
> if (imsic->base_domain) {
> - pr_err("%pfwP: irq domain already created\n", imsic->fwnode);
> + pr_err("%pfwP: irq domain already created\n", imsic->global.fwnode);
> return -ENODEV;
> }
>
> /* Create Base IRQ domain */
> - info.fwnode = imsic->fwnode,
> + info.fwnode = imsic->global.fwnode,
> imsic->base_domain = msi_create_parent_irq_domain(&info, &imsic_msi_parent_ops);
> if (!imsic->base_domain) {
> - pr_err("%pfwP: failed to create IMSIC base domain\n", imsic->fwnode);
> + pr_err("%pfwP: failed to create IMSIC base domain\n", imsic->global.fwnode);
> return -ENOMEM;
> }
>
> global = &imsic->global;
> pr_info("%pfwP: hart-index-bits: %d, guest-index-bits: %d\n",
> - imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
> + imsic->global.fwnode, global->hart_index_bits, global->guest_index_bits);
> pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
> - imsic->fwnode, global->group_index_bits, global->group_index_shift);
> + imsic->global.fwnode, global->group_index_bits, global->group_index_shift);
> pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
> - imsic->fwnode, global->nr_ids, &global->base_addr);
> + imsic->global.fwnode, global->nr_ids, &global->base_addr);
> pr_info("%pfwP: total %d interrupts available\n",
> - imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
> + imsic->global.fwnode, num_possible_cpus() * (global->nr_ids - 1));
>
> return 0;
> }
>
> static int imsic_platform_probe_common(struct fwnode_handle *fwnode)
> {
> - if (imsic && imsic->fwnode != fwnode) {
> + if (imsic && imsic->global.fwnode != fwnode) {
> pr_err("%pfwP: fwnode mismatch\n", fwnode);
> return -ENODEV;
> }
> diff --git a/drivers/irqchip/irq-riscv-imsic-state.c b/drivers/irqchip/irq-riscv-imsic-state.c
> index b8d1bbbf42f7..ae982f89318b 100644
> --- a/drivers/irqchip/irq-riscv-imsic-state.c
> +++ b/drivers/irqchip/irq-riscv-imsic-state.c
> @@ -813,9 +813,9 @@ int __init imsic_setup_state(struct fwnode_handle *fwnode, void *opaque)
> imsic = kzalloc_obj(*imsic);
> if (!imsic)
> return -ENOMEM;
> - imsic->fwnode = fwnode;
> global = &imsic->global;
>
> + global->fwnode = fwnode;
> global->local = alloc_percpu(typeof(*global->local));
> if (!global->local) {
> rc = -ENOMEM;
> diff --git a/drivers/irqchip/irq-riscv-imsic-state.h b/drivers/irqchip/irq-riscv-imsic-state.h
> index c42ee180b305..178b678f5c0f 100644
> --- a/drivers/irqchip/irq-riscv-imsic-state.h
> +++ b/drivers/irqchip/irq-riscv-imsic-state.h
> @@ -44,9 +44,6 @@ struct imsic_local_priv {
> };
>
> struct imsic_priv {
> - /* Device details */
> - struct fwnode_handle *fwnode;
> -
> /* Global configuration common for all HARTs */
> struct imsic_global_config global;
>
> diff --git a/include/linux/irqchip/riscv-imsic.h b/include/linux/irqchip/riscv-imsic.h
> index 61af3a5bea09..b7be1aad7774 100644
> --- a/include/linux/irqchip/riscv-imsic.h
> +++ b/include/linux/irqchip/riscv-imsic.h
> @@ -46,6 +46,9 @@ struct imsic_local_config {
> };
>
> struct imsic_global_config {
> + /* Device details */
> + struct fwnode_handle *fwnode;
> +
Now that fwnode is part of struct imsic_global_config, I suggest
having another patch (on-top-of this patch) which replace the
imsic_acpi_get_fwnode() function with code sequence accessing
fwnode from struct imsic_global_config.
> /*
> * MSI Target Address Scheme
> *
> --
> 2.43.0
>
Regards,
Anup
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: irq/drivers] irqchip/riscv-imsic: Expose the fwnode via the global config
2026-10-02 12:04 [PATCH] irqchip: riscv-imsic: Expose the fwnode via the global config Prajwal N
2026-10-02 17:06 ` Anup Patel
@ 2026-10-15 10:22 ` tip-bot2 for Prajwal N
2026-11-01 22:16 ` [PATCH] irqchip: riscv-imsic: " patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Prajwal N @ 2026-10-15 10:22 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Prajwal N, Thomas Gleixner, x86, linux-kernel
The following commit has been merged into the irq/drivers branch of tip:
Commit-ID: ff6f8cd2919badd242593a86191e8fbba9a18a97
Gitweb: https://git.kernel.org/tip/ff6f8cd2919badd242593a86191e8fbba9a18a97
Author: Prajwal N <prajwal.n@oss.qualcomm.com>
AuthorDate: Fri, 02 Oct 2026 17:34:17 +05:30
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Thu, 15 Oct 2026 12:16:59 +02:00
irqchip/riscv-imsic: Expose the fwnode via the global config
The fwnode describes a global property of the IMSIC interrupt
controller that is equally relevant to external consumers of
imsic_global_config as it is to the imsic_priv itself.
Keeping it in imsic_priv forces the external drivers to access
the private structure rather than using the already exported
imsic_get_global_config() interface.
Moving the fwnode into imsic_global_config makes the public
API self-contained and eliminates the need for callers to
access imsic_priv internals directly.
Signed-off-by: Prajwal N <prajwal.n@oss.qualcomm.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20261002120417.2708979-1-prajwal.n@oss.qualcomm.com
---
drivers/irqchip/irq-riscv-imsic-early.c | 2 +-
drivers/irqchip/irq-riscv-imsic-platform.c | 18 +++++++++---------
drivers/irqchip/irq-riscv-imsic-state.c | 2 +-
drivers/irqchip/irq-riscv-imsic-state.h | 3 ---
include/linux/irqchip/riscv-imsic.h | 3 +++
5 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/irqchip/irq-riscv-imsic-early.c b/drivers/irqchip/irq-riscv-imsic-early.c
index 823f5f2..06726a0 100644
--- a/drivers/irqchip/irq-riscv-imsic-early.c
+++ b/drivers/irqchip/irq-riscv-imsic-early.c
@@ -75,7 +75,7 @@ static int __init imsic_ipi_domain_init(void)
riscv_ipi_set_virq_range(virq, IPI_MAX);
/* Announce that IMSIC is providing IPIs */
- pr_info("%pfwP: providing IPIs using interrupt %d\n", imsic->fwnode, IMSIC_IPI_ID);
+ pr_info("%pfwP: providing IPIs using interrupt %d\n", imsic->global.fwnode, IMSIC_IPI_ID);
return 0;
}
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 643c8e4..95ff76e 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -313,40 +313,40 @@ int imsic_irqdomain_init(void)
};
struct imsic_global_config *global;
- if (!imsic || !imsic->fwnode) {
+ if (!imsic || !imsic->global.fwnode) {
pr_err("early driver not probed\n");
return -ENODEV;
}
if (imsic->base_domain) {
- pr_err("%pfwP: irq domain already created\n", imsic->fwnode);
+ pr_err("%pfwP: irq domain already created\n", imsic->global.fwnode);
return -ENODEV;
}
/* Create Base IRQ domain */
- info.fwnode = imsic->fwnode,
+ info.fwnode = imsic->global.fwnode,
imsic->base_domain = msi_create_parent_irq_domain(&info, &imsic_msi_parent_ops);
if (!imsic->base_domain) {
- pr_err("%pfwP: failed to create IMSIC base domain\n", imsic->fwnode);
+ pr_err("%pfwP: failed to create IMSIC base domain\n", imsic->global.fwnode);
return -ENOMEM;
}
global = &imsic->global;
pr_info("%pfwP: hart-index-bits: %d, guest-index-bits: %d\n",
- imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
+ imsic->global.fwnode, global->hart_index_bits, global->guest_index_bits);
pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
- imsic->fwnode, global->group_index_bits, global->group_index_shift);
+ imsic->global.fwnode, global->group_index_bits, global->group_index_shift);
pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
- imsic->fwnode, global->nr_ids, &global->base_addr);
+ imsic->global.fwnode, global->nr_ids, &global->base_addr);
pr_info("%pfwP: total %d interrupts available\n",
- imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
+ imsic->global.fwnode, num_possible_cpus() * (global->nr_ids - 1));
return 0;
}
static int imsic_platform_probe_common(struct fwnode_handle *fwnode)
{
- if (imsic && imsic->fwnode != fwnode) {
+ if (imsic && imsic->global.fwnode != fwnode) {
pr_err("%pfwP: fwnode mismatch\n", fwnode);
return -ENODEV;
}
diff --git a/drivers/irqchip/irq-riscv-imsic-state.c b/drivers/irqchip/irq-riscv-imsic-state.c
index 960c71d..0162037 100644
--- a/drivers/irqchip/irq-riscv-imsic-state.c
+++ b/drivers/irqchip/irq-riscv-imsic-state.c
@@ -822,9 +822,9 @@ int __init imsic_setup_state(struct fwnode_handle *fwnode, void *opaque)
imsic = kzalloc_obj(*imsic);
if (!imsic)
return -ENOMEM;
- imsic->fwnode = fwnode;
global = &imsic->global;
+ global->fwnode = fwnode;
global->local = alloc_percpu(typeof(*global->local));
if (!global->local) {
rc = -ENOMEM;
diff --git a/drivers/irqchip/irq-riscv-imsic-state.h b/drivers/irqchip/irq-riscv-imsic-state.h
index 878cc19..189829b 100644
--- a/drivers/irqchip/irq-riscv-imsic-state.h
+++ b/drivers/irqchip/irq-riscv-imsic-state.h
@@ -43,9 +43,6 @@ struct imsic_local_priv {
};
struct imsic_priv {
- /* Device details */
- struct fwnode_handle *fwnode;
-
/* Global configuration common for all HARTs */
struct imsic_global_config global;
diff --git a/include/linux/irqchip/riscv-imsic.h b/include/linux/irqchip/riscv-imsic.h
index 61af3a5..b7be1aa 100644
--- a/include/linux/irqchip/riscv-imsic.h
+++ b/include/linux/irqchip/riscv-imsic.h
@@ -46,6 +46,9 @@ struct imsic_local_config {
};
struct imsic_global_config {
+ /* Device details */
+ struct fwnode_handle *fwnode;
+
/*
* MSI Target Address Scheme
*
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] irqchip: riscv-imsic: Expose the fwnode via the global config
2026-10-02 12:04 [PATCH] irqchip: riscv-imsic: Expose the fwnode via the global config Prajwal N
2026-10-02 17:06 ` Anup Patel
2026-10-15 10:22 ` [tip: irq/drivers] irqchip/riscv-imsic: " tip-bot2 for Prajwal N
@ 2026-11-01 22:16 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-riscv @ 2026-11-01 22:16 UTC (permalink / raw)
To: Prajwal N
Cc: linux-riscv, anup, tglx, radu, pjw, palmer, aou, alex,
linux-kernel, prajwal.n.oss
Hello:
This patch was applied to riscv/linux.git (fixes)
by Thomas Gleixner <tglx@kernel.org>:
On Fri, 2 Oct 2026 17:34:17 +0530 you wrote:
> The fwnode describes a global property of the IMSIC interrupt
> controller that is equally relevant to external consumers of
> imsic_global_config as it is to the imsic_priv itself.
>
> Keeping it in imsic_priv forces the external drivers to access
> the private structure rather than using the already exported
> imsic_get_global_config() interface.
>
> [...]
Here is the summary with links:
- irqchip: riscv-imsic: Expose the fwnode via the global config
https://git.kernel.org/riscv/c/ff6f8cd2919b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-01 22:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-02 12:04 [PATCH] irqchip: riscv-imsic: Expose the fwnode via the global config Prajwal N
2026-10-02 17:06 ` Anup Patel
2026-10-15 10:22 ` [tip: irq/drivers] irqchip/riscv-imsic: " tip-bot2 for Prajwal N
2026-11-01 22:16 ` [PATCH] irqchip: riscv-imsic: " patchwork-bot+linux-riscv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®