mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Carlos Maiolino <cem@kernel.org>
To: linux-kernel@vger.kernel.org, jianyungao89@gmail.com
Cc: stable@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>,
	 Alexei Starovoitov <ast@kernel.org>,
	 Kefeng Wang <wangkefeng.wang@huawei.com>,
	Viktor Malik <vmalik@redhat.com>,
	 Yuzuki Ishiyama <ishiyama@hpc.is.uec.ac.jp>,
	 Bill O'Donnell <billodo@sgi.com>,
	David Chinner <david@fromorbit.com>,
	 Lachlan McIlroy <lachlan@sgi.com>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix temporary cursor leak in btree shift corruption paths
Date: Tue, 03 Nov 2026 11:02:35 +0100	[thread overview]
Message-ID: <179370015592.413123.10191493207403501135.b4-ty@kernel.org> (raw)
In-Reply-To: <20261102150146.19777-1-jianyungao89@gmail.com>

On Mon, 02 Nov 2026 23:01:41 +0800, jianyungao89@gmail.com wrote:
> In xfs_btree_lshift and xfs_btree_rshift, when XFS_IS_CORRUPT detects
> an invalid firstrec/lastrec result after xfs_btree_dup_cursor has
> successfully allocated a temporary cursor, the error path jumps to
> error0 which returns without freeing tcur.  This leaks the cursor
> memory, the xfs_group reference, and the per-level buffer references
> held by the duplicated cursor.  Jump to error1 instead, which calls
> xfs_btree_del_cursor(tcur, XFS_BTREE_ERROR) to properly release all
> resources.
> 
> [...]

Applied to for-next, thanks!

[1/1] xfs: fix temporary cursor leak in btree shift corruption paths
      commit: 2bbca049deeb1699cafd966cb2793fee576ee409

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>


  parent reply	other threads:[~2026-11-03 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 15:01 jianyungao89
2026-11-02 15:22 ` Carlos Maiolino
2026-11-03 10:02 ` Carlos Maiolino [this message]
2026-11-03 10:43 ` Markus Elfring
2026-11-03 14:12   ` Jianyun Gao
2026-11-03 14:40     ` Markus Elfring
2026-11-03 14:55 ` [PATCH] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179370015592.413123.10191493207403501135.b4-ty@kernel.org \
    --to=cem@kernel.org \
    --cc=ast@kernel.org \
    --cc=billodo@sgi.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=ishiyama@hpc.is.uec.ac.jp \
    --cc=jianyungao89@gmail.com \
    --cc=lachlan@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vmalik@redhat.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®