From: Jianyun Gao <jianyungao89@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
"Bill O'Donnell" <billodo@sgi.com>,
"Darrick J. Wong" <djwong@kernel.org>,
David Chinner <david@fromorbit.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Lachlan McIlroy <lachlan@sgi.com>,
Viktor Malik <vmalik@redhat.com>,
Yuzuki Ishiyama <ishiyama@hpc.is.uec.ac.jp>
Subject: Re: [PATCH] xfs: fix temporary cursor leak in btree shift corruption paths
Date: Tue, 3 Nov 2026 22:12:41 +0800 [thread overview]
Message-ID: <CAHP3+4BfTma1tQLbGLzy3aAzx05eR0QKOfmL0V-X5vEeOWtAEg@mail.gmail.com> (raw)
In-Reply-To: <717984c9-a0c2-43d8-a801-d36c18c7040d@web.de>
Hi Markus,
Thanks for the review and the suggestion. I agree that centralizing
the error handling paths in these functions would improve readability.
However, to keep this patch focused strictly on the cursor leak fix
(as per the 'one patch, one thing' principle), I would prefer to
submit the code clean-up as a separate follow-up patch if that's
acceptable. I will review the affected functions and see if there are
any obvious style issues worth addressing.
Best regards,
Jianyun
On Tue, Nov 3, 2026 at 6:43 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> …
> > held by the duplicated cursor. Jump to error1 instead, which calls
> > xfs_btree_del_cursor(tcur, XFS_BTREE_ERROR) to properly release all
> > resources.
>
> Can further source code clean-up become helpful for affected function implementations?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.4-rc1#n526
>
> Regards,
> Markus
next prev parent reply other threads:[~2026-11-03 14:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 15:01 jianyungao89
2026-11-02 15:22 ` Carlos Maiolino
2026-11-03 10:02 ` Carlos Maiolino
2026-11-03 10:43 ` Markus Elfring
2026-11-03 14:12 ` Jianyun Gao [this message]
2026-11-03 14:40 ` Markus Elfring
2026-11-03 14:55 ` [PATCH] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHP3+4BfTma1tQLbGLzy3aAzx05eR0QKOfmL0V-X5vEeOWtAEg@mail.gmail.com \
--to=jianyungao89@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=ast@kernel.org \
--cc=billodo@sgi.com \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=ishiyama@hpc.is.uec.ac.jp \
--cc=lachlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vmalik@redhat.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®