From: Markus Elfring <Markus.Elfring@web.de>
To: Jianyun Gao <jianyungao89@gmail.com>, linux-xfs@vger.kernel.org
Cc: Carlos Maiolino <cem@kernel.org>,
stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
David Chinner <david@fromorbit.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Viktor Malik <vmalik@redhat.com>,
Yuzuki Ishiyama <ishiyama@hpc.is.uec.ac.jp>
Subject: Re: xfs: fix temporary cursor leak in btree shift corruption paths
Date: Tue, 3 Nov 2026 15:40:27 +0100 [thread overview]
Message-ID: <3a510baa-b919-4d35-a6b6-db19f9ddaa3b@web.de> (raw)
In-Reply-To: <CAHP3+4BfTma1tQLbGLzy3aAzx05eR0QKOfmL0V-X5vEeOWtAEg@mail.gmail.com>
> Thanks for the review and the suggestion. I agree that centralizing
> the error handling paths in these functions would improve readability.
Further adjustment possibilities might be evolving.
> However, to keep this patch focused strictly on the cursor leak fix
> (as per the 'one patch, one thing' principle), I would prefer to
> submit the code clean-up as a separate follow-up patch if that's
> acceptable.
This can be the case.
Related constraints can eventually be reconsidered also for clean-up patches
in combination with growing number for fixes.
> I will review the affected functions and see if there are
> any obvious style issues worth addressing.
Would you find another clarification approach helpful?
[RFC] Replacing special goto statements by direct returns?
https://lore.kernel.org/kernel-janitors/52418f50-b3ff-461d-8e66-c10f70e35b2a@web.de/
Regards,
Markus
next prev parent reply other threads:[~2026-11-03 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 15:01 [PATCH] " jianyungao89
2026-11-02 15:22 ` Carlos Maiolino
2026-11-03 10:02 ` Carlos Maiolino
2026-11-03 10:43 ` Markus Elfring
2026-11-03 14:12 ` Jianyun Gao
2026-11-03 14:40 ` Markus Elfring [this message]
2026-11-03 14:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a510baa-b919-4d35-a6b6-db19f9ddaa3b@web.de \
--to=markus.elfring@web.de \
--cc=ast@kernel.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=ishiyama@hpc.is.uec.ac.jp \
--cc=jianyungao89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vmalik@redhat.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®