From: mdshahid03@gmail.com
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mdshahid03@gmail.com, starblue@users.sourceforge.net,
legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: legousbtower: use stream_open for stream semantics
Date: Wed, 11 Nov 2026 18:30:21 +0530 [thread overview]
Message-ID: <179440202172.231301.13877269286726215478.b4-reply@b4> (raw)
In-Reply-To: <2026111054-reversing-gurgling-94fd@gregkh>
Hi Greg,
I did basic sanity ,I build driver and ran smatch after changes.
I don't have Lego USB HW to test it ,but there is similar changes
in Xyllibus ,that was sent by me and Eli(maintainer)has tested in HW.
According to Eli ,There is no regressions with stream_open().
Here is discussion:
https://lore.kernel.org/all/24af6daf-dbf3-5c47-beb7-077c4473ea7e@outbound.gmail.com/
Thanks
Shahid.
On 2026-11-10 13:21 -0500, Greg KH wrote:
> On Tue, Nov 10, 2026 at 11:01:36PM +0530, mdshahid03@gmail.com wrote:
> > Hi,
> >
> > Could you please review patch and give your feedback,when time permits.
> >
> > Thanks
> > Shahid.
> >
> > On 2026-10-28 23:58 +0530, mdshahid03@gmail.com wrote:
> > > From: Mohammad Shahid <mdshahid03@gmail.com>
> > >
> > > The LEGO USB Tower driver uses nonseekable_open() in tower_open()
> > > However, its read and write have stream semantics.
> > >
> > > Use stream_open instead to mark the file as a stream and disable
> > > unnecessary file position handling.
> > >
> > > The issue is reported by stream_open.cocci script as potential
> > > deadlock between read and write operation.
> > >
> > > Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
> > > ---
> > > drivers/usb/misc/legousbtower.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> How was this tested?
>
>
next prev parent reply other threads:[~2026-11-11 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 18:28 mdshahid03
2026-11-10 17:31 ` mdshahid03
2026-11-10 18:21 ` Greg KH
2026-11-11 13:00 ` mdshahid03 [this message]
2026-11-11 13:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179440202172.231301.13877269286726215478.b4-reply@b4 \
--to=mdshahid03@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=legousb-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=starblue@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®