* [PATCH net-next v3 0/2] net: sfp: add ODI quirk and sort SFP quirk entries @ 2026-11-18 16:23 github 2026-11-18 16:23 ` [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 github 2026-11-18 16:23 ` [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks github 0 siblings, 2 replies; 9+ messages in thread From: github @ 2026-11-18 16:23 UTC (permalink / raw) To: Russell King, Andrew Lunn, Heiner Kallweit Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel From: Israel Cueto <github@bumblecito.com> This series adds 2500Base-X support for the ODI DFP-34X-2C3 XPON SFP module and performs a cleanup of the SFP quirk table. The first patch adds the ODI module quirk. The module was tested on a Horaco ZX-SWTGW2C8F switch, establishing a 2500 Mb/s link with speed and duplex forced and autonegotiation disabled. The second patch is an independent table-ordering cleanup, sorting the OEM and Turris entries without changing existing quirk behavior. Thanks to Andrew Lunn for the suggestion to include the additional ordering cleanup. Israel Cueto (2): net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 net: sfp: sort OEM and Turris SFP quirks drivers/net/phy/sfp.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 2026-11-18 16:23 [PATCH net-next v3 0/2] net: sfp: add ODI quirk and sort SFP quirk entries github @ 2026-11-18 16:23 ` github 2026-11-18 18:15 ` Andrew Lunn ` (2 more replies) 2026-11-18 16:23 ` [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks github 1 sibling, 3 replies; 9+ messages in thread From: github @ 2026-11-18 16:23 UTC (permalink / raw) To: Russell King, Andrew Lunn, Heiner Kallweit Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel From: Israel Cueto <github@bumblecito.com> The ODI DFP-34X-2C3 XPON SFP module supports 2500Base-X. Add a quirk to enable 2500Base-X support for this module. Tested on a Horaco ZX-SWTGW2C8F switch with an ODI DFP-34X-2C3 module. A 2500 Mb/s link was established with speed and duplex forced and autonegotiation disabled. Signed-off-by: Israel Cueto <github@bumblecito.com> --- drivers/net/phy/sfp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 915156743..960ac89cc 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -614,6 +614,9 @@ static const struct sfp_quirk sfp_quirks[] = { SFP_QUIRK("Lantech", "8330-265D", sfp_quirk_2500basex, sfp_fixup_ignore_los), + // ODI DFP-34X-2C3 XPON stick can operate at 2500base-X + SFP_QUIRK_S("ODI", "DFP-34X-2C3", sfp_quirk_2500basex), + SFP_QUIRK_S("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 2026-11-18 16:23 ` [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 github @ 2026-11-18 18:15 ` Andrew Lunn [not found] ` <4fb66a63-b483-4777-9fe4-b94ccbe733b3@SynologyNAS> 2026-11-18 23:38 ` Andrew Lunn 2026-11-20 21:17 ` netdev-bot+sashiko 2 siblings, 1 reply; 9+ messages in thread From: Andrew Lunn @ 2026-11-18 18:15 UTC (permalink / raw) To: github Cc: Russell King, Heiner Kallweit, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel On Wed, Nov 18, 2026 at 04:23:22PM +0000, github@bumblecito.com wrote: > From: Israel Cueto <github@bumblecito.com> > > The ODI DFP-34X-2C3 XPON SFP module supports 2500Base-X. > > Add a quirk to enable 2500Base-X support for this module. > > Tested on a Horaco ZX-SWTGW2C8F switch with an ODI > DFP-34X-2C3 module. A 2500 Mb/s link was established > with speed and duplex forced and autonegotiation disabled. What happens without the quirk? Does it establish a link using 1000baseX? I'm just trying to ensure this is not going to break anybodies working system. Andrew ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4fb66a63-b483-4777-9fe4-b94ccbe733b3@SynologyNAS>]
* Re: [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 [not found] ` <4fb66a63-b483-4777-9fe4-b94ccbe733b3@SynologyNAS> @ 2026-11-18 20:32 ` Andrew Lunn 0 siblings, 0 replies; 9+ messages in thread From: Andrew Lunn @ 2026-11-18 20:32 UTC (permalink / raw) To: icue.retsam.diman Cc: github, Russell King, Heiner Kallweit, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel On Wed, Nov 18, 2026 at 02:08:44PM -0600, icue.retsam.diman wrote: > > Hi Andrew, > > I tested the module without the quirk using an unmodified OpenWrt SNAPSHOT build (r38465-2ccaccdb98) for the GoodTop GT-SWTXG8FM (realtek/rtl930x). > > The ODI DFP-34X-2C3 successfully establishes a 1000base-X link with autonegotiation enabled. > > The ethtool lan8 output confirms: > > Advertised link modes: 1000baseX/Full > > Link partner advertised link modes: 1000baseX/Full > > Advertised auto-negotiation: Yes > > Link partner advertised auto-negotiation: Yes > > Speed: 1000Mb/s > > Duplex: Full > > Auto-negotiation: on > > Link detected: yes > > With the quirk, I was able to establish a 2500 Mb/s link with speed and duplex forced and autonegotiation disabled. > > Therefore, the module works with 1000base-X autonegotiation without the quirk, while the quirk enables 2500base-X operation. Thanks for testing. You could add a Tested-by: if you want. That will help get the change merge. What i was afraid of is that for some reason 2500BaseX is rejected by the other end, and it will only work at 1000BaseX. For a traditional SFP, that would be true if the SFP on the other end of the fibre could only do 1000BaseX. But this is not a traditional SFP, it is XPON. Can the OLT say no to 2500BaseX, or is this purely down to what the ONT can do? Andrew ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 2026-11-18 16:23 ` [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 github 2026-11-18 18:15 ` Andrew Lunn @ 2026-11-18 23:38 ` Andrew Lunn 2026-11-20 21:17 ` netdev-bot+sashiko 2 siblings, 0 replies; 9+ messages in thread From: Andrew Lunn @ 2026-11-18 23:38 UTC (permalink / raw) To: github Cc: Russell King, Heiner Kallweit, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel On Wed, Nov 18, 2026 at 04:23:22PM +0000, github@bumblecito.com wrote: > From: Israel Cueto <github@bumblecito.com> > > The ODI DFP-34X-2C3 XPON SFP module supports 2500Base-X. > > Add a quirk to enable 2500Base-X support for this module. > > Tested on a Horaco ZX-SWTGW2C8F switch with an ODI > DFP-34X-2C3 module. A 2500 Mb/s link was established > with speed and duplex forced and autonegotiation disabled. > > Signed-off-by: Israel Cueto <github@bumblecito.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 2026-11-18 16:23 ` [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 github 2026-11-18 18:15 ` Andrew Lunn 2026-11-18 23:38 ` Andrew Lunn @ 2026-11-20 21:17 ` netdev-bot+sashiko 2 siblings, 0 replies; 9+ messages in thread From: netdev-bot+sashiko @ 2026-11-20 21:17 UTC (permalink / raw) To: github Cc: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev, linux-kernel Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider. Critical: 0 · High: 0 · Medium: 1 · Low: 1 If you believe none of the issues are legitimate, please reply to each issue of Medium severity or higher and explain why the AI is wrong. If any of them are legitimate and you plan to respin, please let patchwork know by including "pw-bot: cr" as a separate line at the end of your reply (one such reply per series is enough). - [Medium] The only test reported is a 2500 Mb/s link brought up after speed and duplex were forced and autonegotiation was disabled by hand. - [Low] The patch adds SFP_QUIRK_S("ODI", "DFP-34X-2C3", sfp_quirk_2500basex) to sfp_quirks[] in drivers/net/phy/sfp.c (lines… -- net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 This commit adds an entry to sfp_quirks[] that applies sfp_quirk_2500basex to the ODI DFP-34X-2C3 XPON module. It was tested on a Horaco ZX-SWTGW2C8F switch, with speed and duplex forced and autonegotiation disabled. > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index 915156743701b..960ac89cc2a0b 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -614,6 +614,9 @@ static const struct sfp_quirk sfp_quirks[] = { > SFP_QUIRK("Lantech", "8330-265D", sfp_quirk_2500basex, > sfp_fixup_ignore_los), > > + // ODI DFP-34X-2C3 XPON stick can operate at 2500base-X > + SFP_QUIRK_S("ODI", "DFP-34X-2C3", sfp_quirk_2500basex), [Severity: Low] What does this module actually report in its EEPROM? sfp_module_parse_support() in drivers/net/phy/sfp-bus.c can already turn on 2500base-X without a quirk in two cases. One is the FC speed bits with br_nominal >= 31. The other is the bit-rate fallback: drivers/net/phy/sfp-bus.c:sfp_module_parse_support() { ... if (linkmode_empty(modes) && br_nom) { ... if (br_min <= 3200 && br_max >= 2500) { phylink_set(modes, 2500baseX_Full); __set_bit(PHY_INTERFACE_MODE_2500BASEX, interfaces); } } ... } So the quirk is only needed if the EEPROM falls outside both rules. A typical case is an xPON stick that reports 1000BASE-LX at about 1300MBd. Most of the nearby xPON entries record this as "can operate at 2500base-X, but reports <X> in its EEPROM". Examples are Huawei MA5671A, Hisense LXT-010S-H, Hisense ZNID-GPON-2311NA, HSGQ, FS GPON-ONU-34-20BI and Alcatel G010SP. The OEM SFP-2.5G-BX10-D/U and LH03-B/LH20-A entries have no such comment, though. Could the commit message and the table comment say what the module reports for nominal bit rate, BR min/max and compliance codes? The vendor name and PN strings would help too, for example from ethtool -m. The strings matter because sfp_lookup_quirk() needs an exact vendor/part match after trimming. The later commit "net: sfp: sort OEM and Turris SFP quirks" does not change this entry. [Severity: Medium] Does the link come up with this entry under the default phylink configuration? The commit message says the link was established "with speed and duplex forced and autonegotiation disabled". sfp_quirk_2500basex() only adds the link mode and the interface: static void sfp_quirk_2500basex(const struct sfp_eeprom_id *id, struct sfp_module_caps *caps) { linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseX_Full_BIT, caps->link_modes); __set_bit(PHY_INTERFACE_MODE_2500BASEX, caps->interfaces); } It leaves the Autoneg bit that sfp_module_parse_support() always sets: phylink_set(modes, Autoneg); sfp_quirk_oem_2_5g(), by contrast, calls sfp_quirk_disable_autoneg(). With this entry, the default path looks like this: 1. sfp_module_parse_support() sets Autoneg. 2. sfp_quirk_2500basex() adds 2500base-X and keeps Autoneg. 3. phylink_choose_sfp_interface() picks 2500base-X. 4. phylink_sfp_set_config() uses mode = MLO_AN_INBAND. 5. phylink_pcs_neg_mode() takes the Base-X without a PHY branch. When the PCS reports no inband caps, or reports both enable and disable, the advertised Autoneg bit selects in-band negotiation: else if (linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, advertising)) neg_mode = PHYLINK_PCS_NEG_INBAND_ENABLED; Suppose the module's 2500base-X SerDes does not do clause 37 style in-band negotiation. On such hosts, would users need to run ethtool -s ... autoneg off to get a link after inserting the module? Could the entry also disable autoneg? Alternatively, could the commit message confirm that the module links up with in-band AN enabled? Several accepted xPON entries also use sfp_quirk_2500basex with Autoneg left set, so this may be fine if the module does negotiate. There is also the test host. The Horaco ZX-SWTGW2C8F is RTL930x based, and this tree has no mainline MAC/PCS/switch driver for it. The only RTL930x code under drivers/net is drivers/net/mdio/mdio-realtek-rtl9300.c. Was the test run on a downstream kernel? If so, could the commit message say so? The later commit "net: sfp: sort OEM and Turris SFP quirks" does not change the ODI entry either. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118162323.436219-1-github%40bumblecito.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks 2026-11-18 16:23 [PATCH net-next v3 0/2] net: sfp: add ODI quirk and sort SFP quirk entries github 2026-11-18 16:23 ` [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 github @ 2026-11-18 16:23 ` github 2026-11-18 18:11 ` Andrew Lunn 2026-11-20 21:17 ` netdev-bot+sashiko 1 sibling, 2 replies; 9+ messages in thread From: github @ 2026-11-18 16:23 UTC (permalink / raw) To: Russell King, Andrew Lunn, Heiner Kallweit Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel From: Israel Cueto <github@bumblecito.com> Keep OEM entries together in the vendor table's alphabetical order and sort the OEM and Turris entries by part number. This is a table-ordering cleanup only; preserve all existing quirk matches and fixup functions. Signed-off-by: Israel Cueto <github@bumblecito.com> --- drivers/net/phy/sfp.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 960ac89cc..33349c355 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -617,33 +617,24 @@ static const struct sfp_quirk sfp_quirks[] = { // ODI DFP-34X-2C3 XPON stick can operate at 2500base-X SFP_QUIRK_S("ODI", "DFP-34X-2C3", sfp_quirk_2500basex), - SFP_QUIRK_S("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), - - // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the - // Rollball protocol to talk to the PHY. - SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt), - SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt), - - SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron), - // HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY. SFP_QUIRK_F("OEM", "HC-10GE-113C", sfp_fixup_rollball), + SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc), + SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc), - // OEM SFP-GE-T is a 1000Base-T module with broken TX_FAULT indicator - SFP_QUIRK_F("OEM", "SFP-GE-T", sfp_fixup_ignore_tx_fault), + // OEM SFP+ONU-XGSPON is a XGS-PON ONT stick with broken TX_FAULT and + // LOS indicators and slow startup, just like potron. + SFP_QUIRK_F("OEM", "SFP+ONU-XGSPON", sfp_fixup_potron), SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc), - SFP_QUIRK_S("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g), SFP_QUIRK_S("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex), SFP_QUIRK_S("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex), SFP_QUIRK_S("OEM", "SFP-2.5G-LH03-B", sfp_quirk_2500basex), SFP_QUIRK_S("OEM", "SFP-2.5G-LH20-A", sfp_quirk_2500basex), - SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc), - SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc), + SFP_QUIRK_S("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g), - // OEM SFP+ONU-XGSPON is a XGS-PON ONT stick with broken TX_FAULT and - // LOS indicators and slow startup, just like potron. - SFP_QUIRK_F("OEM", "SFP+ONU-XGSPON", sfp_fixup_potron), + // OEM SFP-GE-T is a 1000Base-T module with broken TX_FAULT indicator + SFP_QUIRK_F("OEM", "SFP-GE-T", sfp_fixup_ignore_tx_fault), // OEM XGSPONST2001 is an XGS-PON ONT stick with broken TX_FAULT and // LOS indicators and slow startup, just like potron. On cold @@ -652,11 +643,20 @@ static const struct sfp_quirk sfp_quirks[] = { // match the part as a prefix. SFP_QUIRK_F_PREFIX("OEM", "XGSPONST2001", sfp_fixup_potron), + SFP_QUIRK_S("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), + + // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the + // Rollball protocol to talk to the PHY. + SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt), + SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt), + + SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron), + SFP_QUIRK_S("TP-LINK", "TL-SM410U", sfp_quirk_oem_2_5g), - SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball), SFP_QUIRK_F("Turris", "RTSFP-10", sfp_fixup_rollball), SFP_QUIRK_F("Turris", "RTSFP-10G", sfp_fixup_rollball), + SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball), SFP_QUIRK_F("XikeStor", "SKT-2.5G-100M", sfp_fixup_xikestor_2_5g), -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks 2026-11-18 16:23 ` [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks github @ 2026-11-18 18:11 ` Andrew Lunn 2026-11-20 21:17 ` netdev-bot+sashiko 1 sibling, 0 replies; 9+ messages in thread From: Andrew Lunn @ 2026-11-18 18:11 UTC (permalink / raw) To: github Cc: Russell King, Heiner Kallweit, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel On Wed, Nov 18, 2026 at 04:23:23PM +0000, github@bumblecito.com wrote: > From: Israel Cueto <github@bumblecito.com> > > Keep OEM entries together in the vendor table's alphabetical order > and sort the OEM and Turris entries by part number. > > This is a table-ordering cleanup only; preserve all existing quirk > matches and fixup functions. > > Signed-off-by: Israel Cueto <github@bumblecito.com> Thanks for spending the extra time to do this. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks 2026-11-18 16:23 ` [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks github 2026-11-18 18:11 ` Andrew Lunn @ 2026-11-20 21:17 ` netdev-bot+sashiko 1 sibling, 0 replies; 9+ messages in thread From: netdev-bot+sashiko @ 2026-11-20 21:17 UTC (permalink / raw) To: github Cc: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev, linux-kernel Thank you for your contribution! Sashiko AI review found more severe issue(s) in other patches of this series. This mail is only an FYI, in case you want to address the nit picks below when you respin. Low priority / nit picks for your consideration: - [Low] The commit message says the patch keeps the OEM entries "in the vendor table's alphabetical order", but the resulting sfp_quirks[]… - [Low] After the reordering, the comment "// HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY." (sfp.c:620) heads a block with… -- net: sfp: sort OEM and Turris SFP quirks This commit reorders the sfp_quirks[] table in drivers/net/phy/sfp.c. It moves the UBNT, Walsun and YV entries to after the OEM block, and sorts the OEM and Turris entries by part number. No quirk matches or fixups are changed. > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index 960ac89cc2a0b..33349c3556b31 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -617,33 +617,24 @@ static const struct sfp_quirk sfp_quirks[] = { > // ODI DFP-34X-2C3 XPON stick can operate at 2500base-X > SFP_QUIRK_S("ODI", "DFP-34X-2C3", sfp_quirk_2500basex), > > - SFP_QUIRK_S("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), > - > - // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the > - // Rollball protocol to talk to the PHY. > - SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt), > - SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt), > - > - SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron), > - > // HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY. > SFP_QUIRK_F("OEM", "HC-10GE-113C", sfp_fixup_rollball), > + SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc), > + SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc), [Severity: Low] Should there be a blank line after the HC-10GE-113C entry? In the rest of sfp_quirks[], a comment applies to every entry up to the next blank line. The Walsun, Fiberstore SFP-2.5G-T/SFP-10GM-T and Lantech comments each cover two entries this way. Because RTSFP-10 and RTSFP-10G now sit directly under it, the HORACO comment reads as if it also describes those modules. They are different modules, and they use sfp_fixup_rollball_cc, not sfp_fixup_rollball. Before this patch, the HORACO comment covered one entry and was followed by a blank line. The RTSFP entries were in the uncommented SFP-10G-T / SFP-2.5G-* block. Could a blank line or a separate comment be added for the RTSFP entries? [ ... ] > @@ -652,11 +643,20 @@ static const struct sfp_quirk sfp_quirks[] = { > // match the part as a prefix. > SFP_QUIRK_F_PREFIX("OEM", "XGSPONST2001", sfp_fixup_potron), > > + SFP_QUIRK_S("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), > + > + // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the > + // Rollball protocol to talk to the PHY. > + SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt), > + SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt), > + > + SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron), > + > SFP_QUIRK_S("TP-LINK", "TL-SM410U", sfp_quirk_oem_2_5g), [Severity: Low] The commit message says: Keep OEM entries together in the vendor table's alphabetical order Is the vendor order alphabetical after this move? The UBNT, Walsun and YV block now sits between OEM and TP-LINK, which gives this vendor order: ODI, OEM, UBNT, Walsun, YV, TP-LINK, Turris, XikeStor, ZOERAX In alphabetical order it would be: ODI, OEM, TP-LINK, Turris, UBNT, Walsun, XikeStor, YV, ZOERAX These are the only lines that this patch moves between vendors, and they are still out of order. Would it make sense to put UBNT and Walsun after Turris, and YV after XikeStor? Then a later patch would not need to move the same lines again. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118162323.436219-1-github%40bumblecito.com ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-11-20 21:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 16:23 [PATCH net-next v3 0/2] net: sfp: add ODI quirk and sort SFP quirk entries github
2026-11-18 16:23 ` [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 github
2026-11-18 18:15 ` Andrew Lunn
[not found] ` <4fb66a63-b483-4777-9fe4-b94ccbe733b3@SynologyNAS>
2026-11-18 20:32 ` Andrew Lunn
2026-11-18 23:38 ` Andrew Lunn
2026-11-20 21:17 ` netdev-bot+sashiko
2026-11-18 16:23 ` [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks github
2026-11-18 18:11 ` Andrew Lunn
2026-11-20 21:17 ` netdev-bot+sashiko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®