Re: [PATCH] riscv: dts: starfive: jh7110-common: keep the status power LED on

[E Shattow <e@freeshell.de>]

Hi Owen,

On 11/6/26 10:40, Owen O'Hehir wrote:
> The firmware turns the status power LED on, but the node has no
> default-state, so the LED switches off when leds-gpio probes and the
> board looks powered down.
> 
> Default the LED to on.
> 
> Tested on a VisionFive 2 v1.3B.
> 
> Fixes: 1ec99dfe9eb0 ("riscv: dts: starfive: jh7110-common: add status power led node")
> Signed-off-by: Owen O'Hehir <oo.hehir@gmail.com>
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 64de468f2..7ec94e968 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -44,6 +44,7 @@ leds {
>  
>  		led_status_power: led-0 {
>  			gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
>  		};
>  	};
>  
> 
> base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b

I think this change may disagree with fastboot select function on
VisionFive2 Lite, where (if I understand this correctly) it is read as
an input; see that schematic listed as the "VisionFive 2 Lit Schematic":

https://www.starfivetech.com/en/index.php?s=docs&c=search&keyword=schematic

You may reference also the ghidra archive
https://web.archive.org/web/20260718140236/https://freeshell.de/e/riscv64/hrv-jhre-JH-7110%20BootROM%20analysis_2026_02_22.gar
for decompilation of JH-7110 BootROM loader, and there (to the best of
my understanding) it is not interacting with that register so it must be
purely the SoC reset state.

-E