Re: [PATCH] riscv: dts: starfive: jh7110-common: keep the status power LED on

[E Shattow <e@freeshell.de>]

Hi Owen,

On 11/6/26 11:59, Owen O'Hehir wrote:
> Hi E,
> 
> Thanks for checking. You're right about the commit message: I saw the
> LED lit before Linux probes and assumed the firmware set it, without
> checking where it comes from.
> 
> On the Lite, the schematic (sheet 21) shows RGPIO3 driving the system
> LED and also used for fastboot detection, through jumper J20 that pulls
> it to 1.8 V via R257 (1k). Detection happens at reset, before Linux,

No, the software is not any concern for a hardware description.

> and R257 limits the current whichever level the pin is driven to
> afterwards, so I don't think driving it high conflicts there.
> 
> Owen

It may or may not conflict in software operation but that has nothing to
do with if it should be applied to device tree that describes hardware.
Conor since applied, which is trusting you researched this correctly
before sending to the list. I'm saying that all things being good in
intention this is obviously not well researched, and not allowing for
discussion to verify the fix before applying.

Anyways it is a user light not a power LED. Pine64 Star64 has a power
LED and this user LED. If a board does not have power LED then co-opting
the user LED is something that should be done in inittab not treating
upstream device tree as a preferences config file for userland.

-E