mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Conor Dooley <conor@kernel.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Owen O'Hehir <oo.hehir@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: keep the status power LED on
Date: Fri, 6 Nov 2026 11:06:22 -0800	[thread overview]
Message-ID: <181fdcd8-80ff-4486-ab16-9cbce16b0a29@freeshell.de> (raw)
In-Reply-To: <179399127414.1902073.729566010968054971.b4-ty@microchip.com>

Hi Conor,

On 11/6/26 10:54, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> On Fri, 06 Nov 2026 18:40:55 +0000, Owen O'Hehir wrote:
>> The firmware turns the status power LED on, but the node has no
>> default-state, so the LED switches off when leds-gpio probes and the
>> board looks powered down.
>>
>> Default the LED to on.
>>
>> Tested on a VisionFive 2 v1.3B.
>>
>> [...]
> 
> Applied to riscv-dt-fixes, thanks!
> 
> [1/1] riscv: dts: starfive: jh7110-common: keep the status power LED on
>       https://git.kernel.org/conor/c/68dbe2550bd4
> 
> Thanks,
> Conor.

I replied this a moment earlier:
https://lore.kernel.org/lkml/179fe9e8-322b-4745-8734-d5de5f1e8487@freeshell.de/

This disagrees with VisionFive 2 Lite schematic; if when this node is
consumed by a bootloader it will be evident we are not describing the
hardware correctly, no?

If you want the light on and it wasn't on at reset or due to boot ROM,
then that is userland stuff and not hardware description... but that is
your decision to make as maintainer.

-E

  reply	other threads:[~2026-11-06 19:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 18:40 Owen O'Hehir
2026-11-06 18:51 ` E Shattow
2026-11-06 19:59   ` Owen O'Hehir
2026-11-06 20:30     ` E Shattow
2026-11-06 21:12       ` Owen O'Hehir
2026-11-06 21:13       ` Owen O'Hehir
2026-11-06 18:54 ` Conor Dooley
2026-11-06 19:06   ` E Shattow [this message]
2026-11-06 21:15     ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=181fdcd8-80ff-4486-ab16-9cbce16b0a29@freeshell.de \
    --to=e@freeshell.de \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@esmil.dk \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=oo.hehir@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®