From: Chuyi Zhou <zhouchuyi@bytedance.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com
Cc: chengming.zhou@linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] sched/fair: Remove unused task_numa_migrate return value
Date: Mon, 23 Dec 2024 20:34:27 +0800 [thread overview]
Message-ID: <17b60889-8d1a-4c90-854c-104f1604c5bc@bytedance.com> (raw)
In-Reply-To: <2bda56c3-727f-4899-8d88-fd83f11b3e76@amd.com>
Hello Prateek,
在 2024/12/18 14:29, K Prateek Nayak 写道:
> Hello Chuyi,
>
> On 12/16/2024 5:53 PM, Chuyi Zhou wrote:
>> The return value of task_numa_migrate is unused, remove it.
>>
>> Signed-off-by: Chuyi Zhou <zhouchuyi@bytedance.com>
>
> Feel free to include:
>
> Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
>
> If anyone cares for the history, initial NUMA Balancing implementation
> used the return value of task_numa_migrate() to retry NUMA Balancing in
> commit 6b9a7460b6ba ("sched/numa: Retry migration of tasks to CPU on a
> preferred node") however in the same series[1], Mel also included an
> optimization from Rik which retried NUMA Balancing periodically
> irrespective the return value from task_numa_migrate() in commit
> 2739d3eef3a9 ("sched/numa: Retry task_numa_migrate() periodically")
>
> [1] https://lore.kernel.org/all/1381141781-10992-34-git-send-email-
> mgorman@suse.de/
>
Thank you for providing the historical information! I will incorporate
it into the next version.
next prev parent reply other threads:[~2024-12-23 12:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 12:23 [PATCH 0/3] Take the scheduling domain into account in numa balancing Chuyi Zhou
2024-12-16 12:23 ` [PATCH 1/3] sched/fair: Remove unused task_numa_migrate return value Chuyi Zhou
2024-12-18 6:29 ` K Prateek Nayak
2024-12-23 12:34 ` Chuyi Zhou [this message]
2024-12-16 12:23 ` [PATCH 2/3] sched/fair: Ignore isolated cpus in update_numa_stat Chuyi Zhou
2024-12-18 6:26 ` K Prateek Nayak
2024-12-18 7:19 ` [External] " Chuyi Zhou
2024-12-16 12:23 ` [PATCH 3/3] sched/fair: Ensure select housekeeping cpus in task_numa_find_cpu Chuyi Zhou
2024-12-18 6:21 ` K Prateek Nayak
2024-12-23 12:58 ` Chuyi Zhou
2024-12-27 4:40 ` K Prateek Nayak
2024-12-27 7:59 ` Chuyi Zhou
2025-01-02 5:49 ` K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b60889-8d1a-4c90-854c-104f1604c5bc@bytedance.com \
--to=zhouchuyi@bytedance.com \
--cc=bsegall@google.com \
--cc=chengming.zhou@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®