From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Chuyi Zhou <zhouchuyi@bytedance.com>, <mingo@redhat.com>,
<peterz@infradead.org>, <juri.lelli@redhat.com>,
<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
<vschneid@redhat.com>
Cc: <chengming.zhou@linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] sched/fair: Ensure select housekeeping cpus in task_numa_find_cpu
Date: Thu, 2 Jan 2025 11:19:08 +0530 [thread overview]
Message-ID: <f62a2a31-f79a-4715-b9ce-b6a647d6305f@amd.com> (raw)
In-Reply-To: <d8729277-f75f-449c-af12-9cd2f200a510@bytedance.com>
Hello Chuyi,
On 12/27/2024 1:29 PM, Chuyi Zhou wrote:
> [..snip..]
>>
>> I think the for_each_cpu_wrap() was used to reduce contention for xchg
>> operation below. Perhaps we can have a per-cpu temporary mask (like
>> load_balance_mask) if we want to reduce the xchg contention and break
>> this into cpumask_and() + for_each_cpu_wrap() steps. I'm not sure if
>> any of the existing masks (load_balance_mask, select_rq_mask,
>> should_we_balance_tmpmask) can be safely reused. Otherwise, perhaps we
>> can make a case for for_each_cpu_and_wrap() with this use case.
>>
>
>
> for_each_cpu_and_wrap() is a good idea, but it might be slightly off-topic for this subject. Perhaps we should stick with this implementation for now and see what others think about v2.
Sure thing! No strong feeling from my side :)
>
>
> Thanks.
>
--
Thanks and Regards,
Prateek
prev parent reply other threads:[~2025-01-02 5:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 12:23 [PATCH 0/3] Take the scheduling domain into account in numa balancing Chuyi Zhou
2024-12-16 12:23 ` [PATCH 1/3] sched/fair: Remove unused task_numa_migrate return value Chuyi Zhou
2024-12-18 6:29 ` K Prateek Nayak
2024-12-23 12:34 ` Chuyi Zhou
2024-12-16 12:23 ` [PATCH 2/3] sched/fair: Ignore isolated cpus in update_numa_stat Chuyi Zhou
2024-12-18 6:26 ` K Prateek Nayak
2024-12-18 7:19 ` [External] " Chuyi Zhou
2024-12-16 12:23 ` [PATCH 3/3] sched/fair: Ensure select housekeeping cpus in task_numa_find_cpu Chuyi Zhou
2024-12-18 6:21 ` K Prateek Nayak
2024-12-23 12:58 ` Chuyi Zhou
2024-12-27 4:40 ` K Prateek Nayak
2024-12-27 7:59 ` Chuyi Zhou
2025-01-02 5:49 ` K Prateek Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f62a2a31-f79a-4715-b9ce-b6a647d6305f@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bsegall@google.com \
--cc=chengming.zhou@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhouchuyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®