mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties
@ 2022-11-23  9:24 Pierre Gondois
  2022-11-23  9:24 ` [PATCH v4 1/2] arm64: dts: exynos: " Pierre Gondois
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Pierre Gondois @ 2022-11-23  9:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: Pierre Gondois, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
	Aswani Reddy, Shashank Prashar, Arjun K V, devicetree,
	linux-arm-kernel, linux-samsung-soc

v1:
 - exynos: [1]
 - fds: [2]
v2:
  No change.
 - exynos: [3]
 - fds: [4]
v3:
 - Update commit header for fsd platform. [5]
v4:
 - Update commit header for fsd platform.

As requested by [6], resend patches updating the cache properties for the
exynos/fsd platforms with:
1. Fixed subject.
2. Changelog.
3. Trimmed list.

[1] https://lore.kernel.org/all/20221031091945.531874-1-pierre.gondois@arm.com/
[2] https://lore.kernel.org/all/20221031092125.533621-1-pierre.gondois@arm.com/
[3] https://lore.kernel.org/all/20221107155825.1644604-8-pierre.gondois@arm.com/
[4] https://lore.kernel.org/all/20221107155825.1644604-23-pierre.gondois@arm.com/
[5] https://lore.kernel.org/all/20221123090109.74441-1-pierre.gondois@arm.com/
[6] https://lore.kernel.org/all/4f4bdc95-16a2-df76-9787-df46a3b5e1eb@linaro.org/

Pierre Gondois (2):
  arm64: dts: exynos: Update cache properties
  arm64: dts: fsd: Update cache properties

 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 2 ++
 arch/arm64/boot/dts/tesla/fsd.dtsi         | 2 ++
 3 files changed, 8 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v4 1/2] arm64: dts: exynos: Update cache properties
  2022-11-23  9:24 [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties Pierre Gondois
@ 2022-11-23  9:24 ` Pierre Gondois
  2022-11-23  9:24 ` [PATCH v4 2/2] arm64: dts: fsd: " Pierre Gondois
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Pierre Gondois @ 2022-11-23  9:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: Pierre Gondois, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
	Aswani Reddy, Shashank Prashar, devicetree, linux-arm-kernel,
	linux-samsung-soc

The DeviceTree Specification v0.3 specifies that the cache node
'compatible' and 'cache-level' properties are 'required'. Cf.
s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the
properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index bd6a354b9cb5..8619920da4b6 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -226,6 +226,8 @@ cpu7: cpu@3 {
 
 		cluster_a57_l2: l2-cache0 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x200000>;
 			cache-line-size = <64>;
 			cache-sets = <2048>;
@@ -233,6 +235,8 @@ cluster_a57_l2: l2-cache0 {
 
 		cluster_a53_l2: l2-cache1 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x40000>;
 			cache-line-size = <64>;
 			cache-sets = <256>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 1cd771c90b47..f378d8629d88 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -107,6 +107,8 @@ cpu_atlas3: cpu@3 {
 
 		atlas_l2: l2-cache0 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x200000>;
 			cache-line-size = <64>;
 			cache-sets = <2048>;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v4 2/2] arm64: dts: fsd: Update cache properties
  2022-11-23  9:24 [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties Pierre Gondois
  2022-11-23  9:24 ` [PATCH v4 1/2] arm64: dts: exynos: " Pierre Gondois
@ 2022-11-23  9:24 ` Pierre Gondois
  2022-11-27 21:25 ` [PATCH v4 0/2] arm64: dts: [exynos|fsd]: " Krzysztof Kozlowski
  2022-11-27 21:26 ` Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: Pierre Gondois @ 2022-11-23  9:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: Pierre Gondois, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
	Aswani Reddy, Shashank Prashar, devicetree, linux-arm-kernel,
	linux-samsung-soc

The DeviceTree Specification v0.3 specifies that the cache node
'compatible' and 'cache-level' properties are 'required'. Cf.
s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the
properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 arch/arm64/boot/dts/tesla/fsd.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index f35bc5a288c2..d58d47618c95 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -281,6 +281,8 @@ cpucl2_3: cpu@203 {
 
 		cpucl_l2: l2-cache0 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x400000>;
 			cache-line-size = <64>;
 			cache-sets = <4096>;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties
  2022-11-23  9:24 [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties Pierre Gondois
  2022-11-23  9:24 ` [PATCH v4 1/2] arm64: dts: exynos: " Pierre Gondois
  2022-11-23  9:24 ` [PATCH v4 2/2] arm64: dts: fsd: " Pierre Gondois
@ 2022-11-27 21:25 ` Krzysztof Kozlowski
  2022-11-27 21:26 ` Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-27 21:25 UTC (permalink / raw)
  To: Pierre Gondois, linux-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Aswani Reddy,
	Shashank Prashar, Arjun K V, devicetree, linux-arm-kernel,
	linux-samsung-soc

On 23/11/2022 10:24, Pierre Gondois wrote:
> v1:
>  - exynos: [1]
>  - fds: [2]
> v2:


Thanks, applied.
It is however very late in the cycle, so there is a chance this will
miss the merge window. If this happens, I will keep it for the next
cycle (no need for resending).

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties
  2022-11-23  9:24 [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties Pierre Gondois
                   ` (2 preceding siblings ...)
  2022-11-27 21:25 ` [PATCH v4 0/2] arm64: dts: [exynos|fsd]: " Krzysztof Kozlowski
@ 2022-11-27 21:26 ` Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-27 21:26 UTC (permalink / raw)
  To: linux-kernel, Pierre Gondois
  Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-arm-kernel,
	Arjun K V, Krzysztof Kozlowski, devicetree, Rob Herring,
	Aswani Reddy, Shashank Prashar, Alim Akhtar

On Wed, 23 Nov 2022 10:24:43 +0100, Pierre Gondois wrote:
> v1:
>  - exynos: [1]
>  - fds: [2]
> v2:
>   No change.
>  - exynos: [3]
>  - fds: [4]
> v3:
>  - Update commit header for fsd platform. [5]
> v4:
>  - Update commit header for fsd platform.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: exynos: Update cache properties
      https://git.kernel.org/krzk/linux/c/784287950d8613132d3c3fd502906ba844d63166
[2/2] arm64: dts: fsd: Update cache properties
      https://git.kernel.org/krzk/linux/c/bf2ae716bc4a442e6e8270c18fd29441c031ace8

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-27 21:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-23  9:24 [PATCH v4 0/2] arm64: dts: [exynos|fsd]: Update cache properties Pierre Gondois
2022-11-23  9:24 ` [PATCH v4 1/2] arm64: dts: exynos: " Pierre Gondois
2022-11-23  9:24 ` [PATCH v4 2/2] arm64: dts: fsd: " Pierre Gondois
2022-11-27 21:25 ` [PATCH v4 0/2] arm64: dts: [exynos|fsd]: " Krzysztof Kozlowski
2022-11-27 21:26 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®