mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <broonie@kernel.org>,
	<robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>,
	<manivannan.sadhasivam@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mtd@lists.infradead.org>
Cc: <quic_srichara@quicinc.com>, <quic_varada@quicinc.com>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: ipq9574: Add SPI nand support
Date: Fri, 16 Feb 2024 21:10:28 +0530	[thread overview]
Message-ID: <17c6b3df-2acd-45e2-8167-02c629b1e972@quicinc.com> (raw)
In-Reply-To: <20240215134856.1313239-5-quic_mdalam@quicinc.com>



On 2/15/2024 7:18 PM, Md Sadre Alam wrote:
> Add SPI NAND support for ipq9574 SoC.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
>   .../boot/dts/qcom/ipq9574-rdp-common.dtsi     | 43 +++++++++++++++++++
>   arch/arm64/boot/dts/qcom/ipq9574.dtsi         | 27 ++++++++++++
>   2 files changed, 70 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> index 91e104b0f865..5b54a027fa5d 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> @@ -139,6 +139,49 @@ gpio_leds_default: gpio-leds-default-state {
>   		drive-strength = <8>;
>   		bias-pull-up;
>   	};
> +
> +	qpic_snand_default_state: qpic-snand-default-state {
> +		clock-pins {
> +			pins = "gpio5";
> +			function = "qspi_clk";
> +			drive-strength = <8>;
> +			bias-disable;
> +		};
> +
> +		cs-pins {
> +			pins = "gpio4";
> +			function = "qspi_cs";
> +			drive-strength = <8>;
> +			bias-disable;
> +		};
> +
> +		data-pins {
> +			pins = "gpio0", "gpio1", "gpio2";


As per the pinctrl driver[1], there are 4 data pins.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pinctrl/qcom/pinctrl-ipq9574.c#n296


> +			function = "qspi_data";
> +			drive-strength = <8>;
> +			bias-disable;
> +		};
> +	};
> +};
> +
> +&qpic_bam {
> +	status = "okay";
> +};
> +
> +&qpic_nand {
> +	pinctrl-0 = <&qpic_snand_default_state>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "spi-nand";
> +		reg = <0>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		nand-ecc-engine = <&qpic_nand>;
> +		nand-ecc-strength = <4>;
> +		nand-ecc-step-size = <512>;
> +	};
>   };
>   
>   &usb_0_dwc3 {
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 7f2e5cbf3bbb..d963dd2035dd 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -319,6 +319,33 @@ tcsr: syscon@1937000 {
>   			reg = <0x01937000 0x21000>;
>   		};
>   
> +		qpic_bam: dma-controller@7984000 {


Nodes should be ordered by unit address in ascending order. So please 
move these nodes to the right place.


> +			compatible = "qcom,bam-v1.7.0";
> +			reg = <0x7984000 0x1c000>;


address should be padded to 8 bytes.

> +			interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&gcc GCC_QPIC_AHB_CLK>;
> +			clock-names = "bam_clk";
> +			#dma-cells = <1>;
> +			qcom,ee = <0>;
> +			status = "disabled";
> +		};
> +
> +		qpic_nand: spi@79b0000 {
> +			compatible = "qcom,ipq9574-snand";
> +			reg = <0x79b0000 0x10000>;


Ditto..

> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			clocks = <&gcc GCC_QPIC_CLK>,
> +			<&gcc GCC_QPIC_AHB_CLK>,
> +			<&gcc GCC_QPIC_IO_MACRO_CLK>;


Fix the alignment.

> +			clock-names = "core", "aon", "iom";
> +			dmas = <&qpic_bam 0>,
> +				<&qpic_bam 1>,
> +				<&qpic_bam 2>;


Here as well.


> +			dma-names = "tx", "rx", "cmd";
> +			status = "disabled";
> +		};
> +
>   		sdhc_1: mmc@7804000 {
>   			compatible = "qcom,ipq9574-sdhci", "qcom,sdhci-msm-v5";
>   			reg = <0x07804000 0x1000>,

  reply	other threads:[~2024-02-16 15:40 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 13:48 [PATCH 0/5] Add QPIC SPI NAND driver Md Sadre Alam
2024-02-15 13:48 ` [PATCH 1/5] spi: dt-bindings: add binding doc for spi-qpic-snand Md Sadre Alam
2024-02-15 14:22   ` Mark Brown
2024-02-20 12:05     ` Md Sadre Alam
2024-02-15 14:24   ` Conor Dooley
2024-02-20 12:06     ` Md Sadre Alam
2024-02-15 19:02   ` Krzysztof Kozlowski
2024-02-20 12:28     ` Md Sadre Alam
2024-02-15 13:48 ` [PATCH 2/5] drivers: mtd: nand: Add qpic_common API file Md Sadre Alam
2024-02-15 15:00   ` Dmitry Baryshkov
2024-02-20 15:59     ` Md Sadre Alam
2024-02-20 16:07       ` Dmitry Baryshkov
2024-02-21 10:38         ` Md Sadre Alam
2024-02-15 17:55   ` Konrad Dybcio
2024-02-20 12:21     ` Md Sadre Alam
2024-02-16 15:29   ` Kathiravan Thirumoorthy
2024-02-20 12:30     ` Md Sadre Alam
2024-02-15 13:48 ` [PATCH 3/5] spi: spi-qpic: Add qpic spi nand driver support Md Sadre Alam
2024-02-15 14:14   ` Mark Brown
2024-02-20 11:54     ` Md Sadre Alam
2024-02-20 16:04       ` Mark Brown
2024-02-21 10:36         ` Md Sadre Alam
2024-02-15 17:57   ` Konrad Dybcio
2024-02-20 12:14     ` Md Sadre Alam
2024-03-06  6:01       ` Md Sadre Alam
2024-03-06 16:27         ` Konrad Dybcio
2024-03-07  4:10           ` Md Sadre Alam
2024-02-17 13:48   ` kernel test robot
2024-02-17 18:41   ` kernel test robot
2024-02-18  8:14   ` kernel test robot
2024-02-15 13:48 ` [PATCH 4/5] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-02-16 15:40   ` Kathiravan Thirumoorthy [this message]
2024-02-20 12:31     ` Md Sadre Alam
2024-02-15 13:48 ` [PATCH 5/5] arm64: dts: qcom: ipq9574: Disable eMMC node Md Sadre Alam
2024-02-15 15:00   ` Dmitry Baryshkov
2024-02-15 17:58     ` Konrad Dybcio
2024-02-20 12:16       ` Md Sadre Alam
2024-02-20 12:12     ` Md Sadre Alam
2024-02-16 15:43   ` Kathiravan Thirumoorthy
2024-02-20 12:33     ` Md Sadre Alam
2024-02-19 13:04 ` [PATCH 0/5] Add QPIC SPI NAND driver Manivannan Sadhasivam
2024-02-20 11:32   ` Md Sadre Alam
2024-02-20 11:36     ` Krzysztof Kozlowski
2024-02-21 10:34       ` Md Sadre Alam
2024-02-21 11:01         ` Krzysztof Kozlowski
2024-02-21 11:08           ` Md Sadre Alam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17c6b3df-2acd-45e2-8167-02c629b1e972@quicinc.com \
    --to=quic_kathirav@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®