mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Md Sadre Alam <quic_mdalam@quicinc.com>,
	andersson@kernel.org, broonie@kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH 2/5] drivers: mtd: nand: Add qpic_common API file
Date: Thu, 15 Feb 2024 18:55:11 +0100	[thread overview]
Message-ID: <4cb0144c-303b-4b91-bf88-0a7d7412afe1@linaro.org> (raw)
In-Reply-To: <20240215134856.1313239-3-quic_mdalam@quicinc.com>

On 15.02.2024 14:48, Md Sadre Alam wrote:
> Add qpic_common.c file which hold all the common
> qpic APIs which will be used by both qpic raw nand
> driver and qpic spi nand driver.
> 
> Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---

IIUC this is mostly moving code around?

I do however have some suggestions..

>  drivers/mtd/nand/Makefile            |    1 +
>  drivers/mtd/nand/qpic_common.c       |  786 +++++++++++++++++
>  drivers/mtd/nand/raw/qcom_nandc.c    | 1226 +-------------------------
>  include/linux/mtd/nand-qpic-common.h |  488 ++++++++++
>  4 files changed, 1291 insertions(+), 1210 deletions(-)
>  create mode 100644 drivers/mtd/nand/qpic_common.c
>  create mode 100644 include/linux/mtd/nand-qpic-common.h
> 
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 19e1291ac4d5..131707a41293 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -12,3 +12,4 @@ nandcore-$(CONFIG_MTD_NAND_ECC) += ecc.o
>  nandcore-$(CONFIG_MTD_NAND_ECC_SW_HAMMING) += ecc-sw-hamming.o
>  nandcore-$(CONFIG_MTD_NAND_ECC_SW_BCH) += ecc-sw-bch.o
>  nandcore-$(CONFIG_MTD_NAND_ECC_MXIC) += ecc-mxic.o
> +obj-y += qpic_common.o
> diff --git a/drivers/mtd/nand/qpic_common.c b/drivers/mtd/nand/qpic_common.c
> new file mode 100644
> index 000000000000..4d74ba888028
> --- /dev/null
> +++ b/drivers/mtd/nand/qpic_common.c
> @@ -0,0 +1,786 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * QPIC Controller common API file.
> + * Copyright (C) 2023  Qualcomm Inc.
> + * Authors:	Md sadre Alam           <quic_mdalam@quicinc.com>
> + *		Sricharan R             <quic_srichara@quicinc.com>
> + *		Varadarajan Narayanan	<quic_varada@quicinc.com>
> + *
> + */
> +
> +#include <linux/mtd/nand-qpic-common.h>
> +
> +struct qcom_nand_controller *
> +get_qcom_nand_controller(struct nand_chip *chip)
> +{
> +	return container_of(chip->controller, struct qcom_nand_controller,
> +			    controller);
> +}
> +EXPORT_SYMBOL(get_qcom_nand_controller);

#define to_qcom_nand_controller()?

> +
> +/*
> + * Helper to prepare DMA descriptors for configuring registers
> + * before reading a NAND page.
> + */

Can you convert these to kerneldoc instead?

> +void config_nand_page_read(struct nand_chip *chip)
> +{
> +	struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
> +
> +	write_reg_dma(nandc, NAND_ADDR0, 2, 0);
> +	write_reg_dma(nandc, NAND_DEV0_CFG0, 3, 0);
> +	if (!nandc->props->qpic_v2)

This is not going to scale going forward.. please include a version
enum instead.

[...]

> +
> +int prep_adm_dma_desc(struct qcom_nand_controller *nandc, bool read,
> +		      int reg_off, const void *vaddr, int size,
> +			     bool flow_control)
> +{
> +	struct desc_info *desc;
> +	struct dma_async_tx_descriptor *dma_desc;
> +	struct scatterlist *sgl;
> +	struct dma_slave_config slave_conf;
> +	struct qcom_adm_peripheral_config periph_conf = {};
> +	enum dma_transfer_direction dir_eng;
> +	int ret;

Revertse-christmas-tree, please

> +
> +	desc = kzalloc(sizeof(*desc), GFP_KERNEL);
> +	if (!desc)
> +		return -ENOMEM;
> +
> +	sgl = &desc->adm_sgl;
> +
> +	sg_init_one(sgl, vaddr, size);
> +
> +	if (read) {
> +		dir_eng = DMA_DEV_TO_MEM;
> +		desc->dir = DMA_FROM_DEVICE;
> +	} else {
> +		dir_eng = DMA_MEM_TO_DEV;
> +		desc->dir = DMA_TO_DEVICE;
> +	}
> +
> +	ret = dma_map_sg(nandc->dev, sgl, 1, desc->dir);
> +	if (ret == 0) {

if (!ret)

> +		ret = -ENOMEM;
> +		goto err;
> +	}
> +
> +	memset(&slave_conf, 0x00, sizeof(slave_conf));

Just zero-initialize it (= { 0 }) at declaration time

Konrad

  parent reply	other threads:[~2024-02-15 17:55 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 13:48 [PATCH 0/5] Add QPIC SPI NAND driver Md Sadre Alam
2024-02-15 13:48 ` [PATCH 1/5] spi: dt-bindings: add binding doc for spi-qpic-snand Md Sadre Alam
2024-02-15 14:22   ` Mark Brown
2024-02-20 12:05     ` Md Sadre Alam
2024-02-15 14:24   ` Conor Dooley
2024-02-20 12:06     ` Md Sadre Alam
2024-02-15 19:02   ` Krzysztof Kozlowski
2024-02-20 12:28     ` Md Sadre Alam
2024-02-15 13:48 ` [PATCH 2/5] drivers: mtd: nand: Add qpic_common API file Md Sadre Alam
2024-02-15 15:00   ` Dmitry Baryshkov
2024-02-20 15:59     ` Md Sadre Alam
2024-02-20 16:07       ` Dmitry Baryshkov
2024-02-21 10:38         ` Md Sadre Alam
2024-02-15 17:55   ` Konrad Dybcio [this message]
2024-02-20 12:21     ` Md Sadre Alam
2024-02-16 15:29   ` Kathiravan Thirumoorthy
2024-02-20 12:30     ` Md Sadre Alam
2024-02-15 13:48 ` [PATCH 3/5] spi: spi-qpic: Add qpic spi nand driver support Md Sadre Alam
2024-02-15 14:14   ` Mark Brown
2024-02-20 11:54     ` Md Sadre Alam
2024-02-20 16:04       ` Mark Brown
2024-02-21 10:36         ` Md Sadre Alam
2024-02-15 17:57   ` Konrad Dybcio
2024-02-20 12:14     ` Md Sadre Alam
2024-03-06  6:01       ` Md Sadre Alam
2024-03-06 16:27         ` Konrad Dybcio
2024-03-07  4:10           ` Md Sadre Alam
2024-02-17 13:48   ` kernel test robot
2024-02-17 18:41   ` kernel test robot
2024-02-18  8:14   ` kernel test robot
2024-02-15 13:48 ` [PATCH 4/5] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-02-16 15:40   ` Kathiravan Thirumoorthy
2024-02-20 12:31     ` Md Sadre Alam
2024-02-15 13:48 ` [PATCH 5/5] arm64: dts: qcom: ipq9574: Disable eMMC node Md Sadre Alam
2024-02-15 15:00   ` Dmitry Baryshkov
2024-02-15 17:58     ` Konrad Dybcio
2024-02-20 12:16       ` Md Sadre Alam
2024-02-20 12:12     ` Md Sadre Alam
2024-02-16 15:43   ` Kathiravan Thirumoorthy
2024-02-20 12:33     ` Md Sadre Alam
2024-02-19 13:04 ` [PATCH 0/5] Add QPIC SPI NAND driver Manivannan Sadhasivam
2024-02-20 11:32   ` Md Sadre Alam
2024-02-20 11:36     ` Krzysztof Kozlowski
2024-02-21 10:34       ` Md Sadre Alam
2024-02-21 11:01         ` Krzysztof Kozlowski
2024-02-21 11:08           ` Md Sadre Alam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cb0144c-303b-4b91-bf88-0a7d7412afe1@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®