From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: do not require an empty line before error injection
Date: Thu, 16 Nov 2023 17:46:46 -0800 [thread overview]
Message-ID: <1868fc850a1ea5e51c833b68aacce120ad738ab7.camel@perches.com> (raw)
In-Reply-To: <20231109075147.2779461-1-senozhatsky@chromium.org>
On Thu, 2023-11-09 at 16:51 +0900, Sergey Senozhatsky wrote:
> ALLOW_ERROR_INJECTION macro (just like EXPORT_SYMBOL) can immediately
> follow a function it annotates.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 25fdb7fda112..a94ed6c46a6d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4054,7 +4054,7 @@ sub process {
> if ($prevline =~ /^[\+ ]};?\s*$/ &&
> $line =~ /^\+/ &&
> !($line =~ /^\+\s*$/ ||
> - $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ ||
> + $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param|ALLOW_ERROR_INJECTION)/ ||
> $line =~ /^\+\s*MODULE_/i ||
> $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
> $line =~ /^\+[a-z_]*init/ ||
prev parent reply other threads:[~2023-11-17 1:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 7:51 Sergey Senozhatsky
2023-11-17 1:40 ` Sergey Senozhatsky
2023-11-17 1:46 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1868fc850a1ea5e51c833b68aacce120ad738ab7.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®