From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH] checkpatch: do not require an empty line before error injection
Date: Fri, 17 Nov 2023 10:40:25 +0900 [thread overview]
Message-ID: <20231117014025.GC1325348@google.com> (raw)
In-Reply-To: <20231109075147.2779461-1-senozhatsky@chromium.org>
On (23/11/09 16:51), Sergey Senozhatsky wrote:
>
> ALLOW_ERROR_INJECTION macro (just like EXPORT_SYMBOL) can immediately
> follow a function it annotates.
Gentle ping.
[..]
> @@ -4054,7 +4054,7 @@ sub process {
> if ($prevline =~ /^[\+ ]};?\s*$/ &&
> $line =~ /^\+/ &&
> !($line =~ /^\+\s*$/ ||
> - $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ ||
> + $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param|ALLOW_ERROR_INJECTION)/ ||
> $line =~ /^\+\s*MODULE_/i ||
> $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
> $line =~ /^\+[a-z_]*init/ ||
> --
> 2.42.0.869.gea05f2083d-goog
>
next prev parent reply other threads:[~2023-11-17 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 7:51 Sergey Senozhatsky
2023-11-17 1:40 ` Sergey Senozhatsky [this message]
2023-11-17 1:46 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117014025.GC1325348@google.com \
--to=senozhatsky@chromium.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®