* [PATCH 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes
2024-10-08 2:59 [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support Joel Selvaraj via B4 Relay
@ 2024-10-08 2:59 ` Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support Joel Selvaraj via B4 Relay
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Joel Selvaraj via B4 Relay @ 2024-10-08 2:59 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joel Selvaraj, Joel Selvaraj
From: Joel Selvaraj <joelselvaraj.oss@gmail.com>
Enable qupv3_id_1 and gpi_dma1 as they are required for configuring
touchscreen. Also add pinctrl configurations needed for touchscreen.
These are common for both the tianma and ebbg touchscreen variant.
In the subsequent patches, we will enable support for the Novatek NT36672a
touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
Tianma and EBBG panel variant respectively. This is done in preparation
for that.
Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
---
.../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 39 ++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 617b17b2d7d9d..6773a7ddb9a33 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -243,6 +243,10 @@ &gmu {
status = "okay";
};
+&gpi_dma1 {
+ status = "okay";
+};
+
&gpu {
status = "okay";
@@ -408,6 +412,10 @@ &qupv3_id_0 {
status = "okay";
};
+&qupv3_id_1 {
+ status = "okay";
+};
+
&sdhc_2 {
status = "okay";
@@ -513,6 +521,37 @@ sdc2_card_det_n: sd-card-det-n-state {
function = "gpio";
bias-pull-up;
};
+
+ ts_int_default: ts-int-default-state {
+ pins = "gpio31";
+ function = "gpio";
+ drive-strength = <16>;
+ bias-pull-down;
+ input-enable;
+ };
+
+ ts_reset_default: ts-reset-default-state {
+ pins = "gpio32";
+ function = "gpio";
+ drive-strength = <16>;
+ output-high;
+ };
+
+ ts_int_sleep: ts-int-sleep-state {
+ pins = "gpio31";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ input-enable;
+ };
+
+ ts_reset_sleep: ts-reset-sleep-state {
+ pins = "gpio32";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ output-low;
+ };
};
&uart6 {
--
2.46.2
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support
2024-10-08 2:59 [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes Joel Selvaraj via B4 Relay
@ 2024-10-08 2:59 ` Joel Selvaraj via B4 Relay
2024-10-26 10:28 ` Konrad Dybcio
2024-10-08 2:59 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: " Joel Selvaraj via B4 Relay
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Joel Selvaraj via B4 Relay @ 2024-10-08 2:59 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joel Selvaraj, Joel Selvaraj
From: Joel Selvaraj <jo@jsfamily.in>
Enable the Novatek NT36672A touchscreen controller used in the Poco F1
(Tianma) panel variant.
Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
---
.../dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
index e9427851ebaae..b58964cde8342 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
@@ -13,3 +13,26 @@ &display_panel {
compatible = "tianma,fhd-video", "novatek,nt36672a";
status = "okay";
};
+
+&i2c14 {
+ status = "okay";
+
+ touchscreen@1 {
+ compatible = "novatek,nt36672a-ts";
+ reg = <0x01>;
+
+ interrupts-extended = <&tlmm 31 IRQ_TYPE_EDGE_RISING>;
+ reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>;
+ panel = <&display_panel>;
+
+ iovcc-supply = <&vreg_l14a_1p8>;
+ vcc-supply = <&lab>;
+
+ pinctrl-0 = <&ts_int_default &ts_reset_default>;
+ pinctrl-1 = <&ts_int_sleep &ts_reset_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ touchscreen-size-x = <1080>;
+ touchscreen-size-y = <2246>;
+ };
+};
--
2.46.2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support
2024-10-08 2:59 ` [PATCH 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support Joel Selvaraj via B4 Relay
@ 2024-10-26 10:28 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-10-26 10:28 UTC (permalink / raw)
To: foss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joel Selvaraj
On 8.10.2024 4:59 AM, Joel Selvaraj via B4 Relay wrote:
> From: Joel Selvaraj <jo@jsfamily.in>
>
> Enable the Novatek NT36672A touchscreen controller used in the Poco F1
> (Tianma) panel variant.
>
> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce touchscreen support
2024-10-08 2:59 [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support Joel Selvaraj via B4 Relay
@ 2024-10-08 2:59 ` Joel Selvaraj via B4 Relay
2024-10-26 10:28 ` Konrad Dybcio
2024-10-08 14:56 ` [PATCH 0/3] Add Xiaomi Poco F1 " Rob Herring (Arm)
2025-05-11 23:01 ` Bjorn Andersson
4 siblings, 1 reply; 9+ messages in thread
From: Joel Selvaraj via B4 Relay @ 2024-10-08 2:59 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joel Selvaraj, Joel Selvaraj
From: Joel Selvaraj <joelselvaraj.oss@gmail.com>
Enable the Focaltech FT8719 touchscreen controller used in the Poco F1
(EBBG) panel variant.
Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
---
.../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
index 76931ebad065e..2d6f0e382a6cb 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
@@ -13,3 +13,26 @@ &display_panel {
compatible = "ebbg,ft8719";
status = "okay";
};
+
+&i2c14 {
+ status = "okay";
+
+ touchscreen@38 {
+ compatible = "focaltech,ft8719";
+ reg = <0x38>;
+
+ interrupts-extended = <&tlmm 31 IRQ_TYPE_EDGE_RISING>;
+ reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>;
+ panel = <&display_panel>;
+
+ iovcc-supply = <&vreg_l14a_1p8>;
+ vcc-supply = <&lab>;
+
+ pinctrl-0 = <&ts_int_default &ts_reset_default>;
+ pinctrl-1 = <&ts_int_sleep &ts_reset_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ touchscreen-size-x = <1080>;
+ touchscreen-size-y = <2246>;
+ };
+};
--
2.46.2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce touchscreen support
2024-10-08 2:59 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: " Joel Selvaraj via B4 Relay
@ 2024-10-26 10:28 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-10-26 10:28 UTC (permalink / raw)
To: foss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joel Selvaraj
On 8.10.2024 4:59 AM, Joel Selvaraj via B4 Relay wrote:
> From: Joel Selvaraj <joelselvaraj.oss@gmail.com>
>
> Enable the Focaltech FT8719 touchscreen controller used in the Poco F1
> (EBBG) panel variant.
>
> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support
2024-10-08 2:59 [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support Joel Selvaraj via B4 Relay
` (2 preceding siblings ...)
2024-10-08 2:59 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: " Joel Selvaraj via B4 Relay
@ 2024-10-08 14:56 ` Rob Herring (Arm)
2024-10-26 10:27 ` Konrad Dybcio
2025-05-11 23:01 ` Bjorn Andersson
4 siblings, 1 reply; 9+ messages in thread
From: Rob Herring (Arm) @ 2024-10-08 14:56 UTC (permalink / raw)
To: Joel Selvaraj
Cc: linux-arm-msm, Konrad Dybcio, Bjorn Andersson, Conor Dooley,
Krzysztof Kozlowski, devicetree, Joel Selvaraj, linux-kernel,
Joel Selvaraj
On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote:
> In the first patch, I have enabled the qupv3_id_1 and gpi_dma1 as they
> are required for configuring touchscreen. Also added the pinctrl configurations.
> These are common for both the Poco F1 Tianma and EBBG panel variant.
>
> In the subsequent patches, I have enabled support for the Novatek NT36672a
> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
> Tianma and EBBG panel variant respectively.
>
> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
> ---
> Joel Selvaraj (3):
> arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes
> arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support
> arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce touchscreen support
>
> .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 39 ++++++++++++++++++++++
> .../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 23 +++++++++++++
> .../dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 23 +++++++++++++
> 3 files changed, 85 insertions(+)
> ---
> base-commit: d435d1e92be5fd26cd383fbddb596942ddc52b9f
> change-id: 20241007-pocof1-touchscreen-support-c752a162cdc2
>
> Best regards,
> --
> Joel Selvaraj <foss@joelselvaraj.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/sdm845-xiaomi-beryllium-ebbg.dtb qcom/sdm845-xiaomi-beryllium-tianma.dtb' for 20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@joelselvaraj.com:
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: touchscreen@38: 'panel' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/input/touchscreen/edt-ft5x06.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@3400000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@3400000: ts-int-sleep-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: pinctrl@3400000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: pinctrl@3400000: ts-int-sleep-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support
2024-10-08 14:56 ` [PATCH 0/3] Add Xiaomi Poco F1 " Rob Herring (Arm)
@ 2024-10-26 10:27 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2024-10-26 10:27 UTC (permalink / raw)
To: Rob Herring (Arm), Joel Selvaraj
Cc: linux-arm-msm, Konrad Dybcio, Bjorn Andersson, Conor Dooley,
Krzysztof Kozlowski, devicetree, Joel Selvaraj, linux-kernel,
Joel Selvaraj
On 8.10.2024 4:56 PM, Rob Herring (Arm) wrote:
>
> On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote:
>> In the first patch, I have enabled the qupv3_id_1 and gpi_dma1 as they
>> are required for configuring touchscreen. Also added the pinctrl configurations.
>> These are common for both the Poco F1 Tianma and EBBG panel variant.
>>
>> In the subsequent patches, I have enabled support for the Novatek NT36672a
>> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
>> Tianma and EBBG panel variant respectively.
>>
>> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
>> ---
[...]
> New warnings running 'make CHECK_DTBS=y qcom/sdm845-xiaomi-beryllium-ebbg.dtb qcom/sdm845-xiaomi-beryllium-tianma.dtb' for 20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@joelselvaraj.com:
>
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: touchscreen@38: 'panel' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/input/touchscreen/edt-ft5x06.yaml#
This needs a bindings update
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@3400000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
> 'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
> False schema does not allow True
> from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
I think these warnings are unhappy about input-enable (which is not really a
thing on TLMM, see:
e49eabe3e13f ("pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE")
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support
2024-10-08 2:59 [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support Joel Selvaraj via B4 Relay
` (3 preceding siblings ...)
2024-10-08 14:56 ` [PATCH 0/3] Add Xiaomi Poco F1 " Rob Herring (Arm)
@ 2025-05-11 23:01 ` Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2025-05-11 23:01 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Selvaraj
Cc: linux-arm-msm, devicetree, linux-kernel, Joel Selvaraj, Joel Selvaraj
On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote:
> In the first patch, I have enabled the qupv3_id_1 and gpi_dma1 as they
> are required for configuring touchscreen. Also added the pinctrl configurations.
> These are common for both the Poco F1 Tianma and EBBG panel variant.
>
> In the subsequent patches, I have enabled support for the Novatek NT36672a
> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
> Tianma and EBBG panel variant respectively.
>
> [...]
Applied, thanks!
[1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes
commit: 424246ed3e5d1d7b4a33e2b13a30c8d1b284fad5
[2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support
commit: 2be670d00b4002f56b11a57a510540001ef1cacb
[3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce touchscreen support
commit: a18226be95c7ae7c9ec22fd31a6124bef5675c64
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread