From: Vegard Nossum <vegard.nossum@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>,
stable@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix lazy vmap purging (use-after-free error)
Date: Sat, 21 Feb 2009 20:21:22 +0100 [thread overview]
Message-ID: <19f34abd0902211121i4eca3450y2c9306f73e23de7@mail.gmail.com> (raw)
In-Reply-To: <20090221174703.GA6860@linux.vnet.ibm.com>
2009/2/21 Paul E. McKenney <paulmck@linux.vnet.ibm.com>:
> Is this behavior recent, or does it apply to earlier 2.6.29-rc kernels
> as well? Does it happen with CONFIG_CLASSIC_RCU as well? (From the
> trace above, I suspect that it might well do so, but if not, that will
> be valuable information as well.)
I don't know -- I haven't tried earlier kernels.
I just compiled a CONFIG_CLASSIC_RCU kernel, and it does happen there too:
[ 1.061138] traversing list {
[ 1.062281] __free_vmap_area(c7803a40)
[ 1.063177] __free_vmap_area(c7803a80)
[ 1.065217] __free_vmap_area(c7803ac0)
[ 1.066255] __free_vmap_area(c7803b00)
[ 1.067156] kfree(c7803a40)
[ 1.068292] __free_vmap_area(c7803b40)
[ 1.069094] __free_vmap_area(c7803b80)
[ 1.071051] kfree(c7803a80)
[ 1.072138] __free_vmap_area(c7803bc0)
[ 1.073101] __free_vmap_area(c7803c00)
[ 1.074065] kfree(c7803ac0)
[ 1.077126] kfree(c7803b00)
[ 1.078124] __free_vmap_area(c7803c40)
[ 1.079079] __free_vmap_area(c7803c80)
...
[ 4.645118] __free_vmap_area(c7853440)
[ 4.646099] __free_vmap_area(c7853480)
[ 4.646507] __free_vmap_area(c78534c0)
[ 4.647049] kfree(c7853340)
[ 4.648058] kfree(c7853380)
[ 4.650090] };
[ 4.652061] kfree(c78533c0)
[ 4.653055] kfree(c7853400)
[ 4.656109] kfree(c7853440)
[ 4.656482] kfree(c7853480)
[ 4.656760] kfree(c78534c0)
[ 5.541885] traversing list {
[ 5.543081] __free_vmap_area(c7853380)
[ 5.544071] __free_vmap_area(c7853340)
...
[ 8.977412] __free_vmap_area(c7822400)
[ 8.977723] __free_vmap_area(c7822440)
[ 8.978045] kfree(c7822200)
[ 8.978569] kfree(c7822240)
[ 8.979054] kfree(c7822280)
[ 8.979389] };
[ 8.981051] kfree(c78222c0)
[ 8.983055] kfree(c7822300)
[ 8.984089] kfree(c7822340)
[ 8.984640] Freeing SMP alternatives: 20k freed
[ 8.985146] ACPI: Core revision 20081204
[ 8.986060] kfree(c7822380)
[ 8.987057] kfree(c78223c0)
[ 8.988052] kfree(c7822400)
[ 8.990045] kfree(c7822440)
[ 9.021526] ..TIMER: vector=0x30 apic1=0 pin1=0 apic2=-1 pin2=-1
The only difference I can see is that they're clumped together more
closely (4-5 calls of one kind, then 4-5 calls of the other) than with
the Tree RCU.
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
next prev parent reply other threads:[~2009-02-21 19:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 13:41 Vegard Nossum
2009-02-20 13:50 ` Ingo Molnar
2009-02-20 13:58 ` Pekka Enberg
2009-02-20 14:01 ` Ingo Molnar
2009-02-20 14:18 ` Pekka Enberg
2009-02-20 15:41 ` Paul E. McKenney
2009-02-20 14:51 ` Vegard Nossum
2009-02-20 15:46 ` Paul E. McKenney
2009-02-20 16:04 ` Ingo Molnar
2009-02-20 16:44 ` Paul E. McKenney
2009-02-20 17:14 ` Ingo Molnar
2009-02-20 17:25 ` Paul E. McKenney
2009-02-20 23:51 ` Vegard Nossum
2009-02-21 1:40 ` Paul E. McKenney
2009-02-21 9:30 ` Vegard Nossum
2009-02-21 17:47 ` Paul E. McKenney
2009-02-21 18:08 ` Vegard Nossum
2009-02-21 18:33 ` Paul E. McKenney
2009-02-21 18:37 ` Vegard Nossum
2009-02-22 3:00 ` Paul E. McKenney
2009-02-23 5:17 ` Paul E. McKenney
2009-02-23 8:24 ` Vegard Nossum
2009-02-23 15:39 ` Paul E. McKenney
2009-02-23 9:07 ` Ingo Molnar
2009-02-23 9:17 ` Andrew Morton
2009-02-23 9:27 ` Ingo Molnar
2009-02-23 15:56 ` Paul E. McKenney
2009-02-23 13:29 ` Nick Piggin
2009-02-23 16:17 ` Paul E. McKenney
2009-02-23 17:20 ` Ingo Molnar
2009-02-23 19:10 ` Andrew Morton
2009-02-23 19:30 ` Paul E. McKenney
2009-02-23 19:59 ` Andrew Morton
2009-02-23 20:12 ` Paul E. McKenney
2009-02-23 20:30 ` Andrew Morton
2009-02-23 19:33 ` Ingo Molnar
2009-02-23 20:04 ` Andrew Morton
2009-02-23 20:09 ` Ingo Molnar
2009-02-23 20:44 ` Paul E. McKenney
2009-02-23 20:43 ` Paul E. McKenney
2009-02-24 3:23 ` Nick Piggin
2009-02-24 3:37 ` Paul E. McKenney
2009-02-21 19:21 ` Vegard Nossum [this message]
2009-02-20 16:01 ` Ingo Molnar
2009-02-20 16:49 ` Paul E. McKenney
2009-02-20 15:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0902211121i4eca3450y2c9306f73e23de7@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®