From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Anup Sharma <anupnewsmail@gmail.com>
Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, andy@kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h>
Date: Sun, 16 Apr 2023 15:08:56 +0200 [thread overview]
Message-ID: <1a4a7016-a871-abbe-e8cb-c8a7241de50f@redhat.com> (raw)
In-Reply-To: <CAHp75Veaqp4O1jcBHZZh2L5ReMU1+2vH+FfRzfLyY8CdwZwq+w@mail.gmail.com>
Hi,
On 4/16/23 12:01, Andy Shevchenko wrote:
> On Sun, Apr 16, 2023 at 10:20 AM Anup Sharma <anupnewsmail@gmail.com> wrote:
>>
>> Fix following checkpatch.pl warning by including
>> <linux/processor.h> instead of <asm/processor.h>
>
> Missing period at the end. But the entire patch seems unnecessary
> since it's all about x86, and we have more arch headers there anyway.
> Anyway it's up to Hans. Also see below.
Right, given how much real work this driver still needs this
really feels like needless churn, so I'm not going to take
this patch, sorry.
Regards,
Hans
>
> ...
>
>> #include <asm/intel-family.h>
>> -#include <asm/processor.h>
>> +#include <linux/processor.h>
>>
>> #include <linux/i2c.h>
>> #include <media/v4l2-subdev.h>
>
> This seems a bit chaotic with the ordering of the headers here.
>
> ...
>
> If you want a good patch, you need to understand what headers are
> _really_ being used in the header file. Then drop unused, try to
> compile that and fix all files that will have missing headers after
> that. This will be a very useful clean up!
>
prev parent reply other threads:[~2023-04-16 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZDuhnLPczec5qJnq@yoga>
2023-04-16 10:01 ` Andy Shevchenko
2023-04-16 13:08 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a4a7016-a871-abbe-e8cb-c8a7241de50f@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=anupnewsmail@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®