Re: [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h>

Re: [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h>

[Andy Shevchenko]

On Sun, Apr 16, 2023 at 10:20 AM Anup Sharma <anupnewsmail@gmail.com> wrote:
>
> Fix following checkpatch.pl warning by including
> <linux/processor.h> instead of <asm/processor.h>

Missing period at the end. But the entire patch seems unnecessary
since it's all about x86, and we have more arch headers there anyway.
Anyway it's up to Hans. Also see below.

...

>  #include <asm/intel-family.h>
> -#include <asm/processor.h>
> +#include <linux/processor.h>
>
>  #include <linux/i2c.h>
>  #include <media/v4l2-subdev.h>

This seems a bit chaotic with the ordering of the headers here.

...

If you want a good patch, you need to understand what headers are
_really_ being used in the header file. Then drop unused, try to
compile that and fix all files that will have missing headers after
that. This will be a very useful clean up!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h>

[Hans de Goede]

Hi,

On 4/16/23 12:01, Andy Shevchenko wrote:
> On Sun, Apr 16, 2023 at 10:20 AM Anup Sharma <anupnewsmail@gmail.com> wrote:
>>
>> Fix following checkpatch.pl warning by including
>> <linux/processor.h> instead of <asm/processor.h>
> 
> Missing period at the end. But the entire patch seems unnecessary
> since it's all about x86, and we have more arch headers there anyway.
> Anyway it's up to Hans. Also see below.

Right, given how much real work this driver still needs this
really feels like needless churn, so I'm not going to take
this patch, sorry.

Regards,

Hans



> 
> ...
> 
>>  #include <asm/intel-family.h>
>> -#include <asm/processor.h>
>> +#include <linux/processor.h>
>>
>>  #include <linux/i2c.h>
>>  #include <media/v4l2-subdev.h>
> 
> This seems a bit chaotic with the ordering of the headers here.
> 
> ...
> 
> If you want a good patch, you need to understand what headers are
> _really_ being used in the header file. Then drop unused, try to
> compile that and fix all files that will have missing headers after
> that. This will be a very useful clean up!
>