mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Diogo Ivo <diogo.ivo.sx@renesas.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Linus Walleij <linusw@kernel.org>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 4/8] i3c: renesas: Add RZ/G3L support
Date: Fri, 23 Oct 2026 16:08:58 +0100	[thread overview]
Message-ID: <1ab43b52-0ee0-4e9f-871c-708736023b4b@renesas.com> (raw)
In-Reply-To: <20261023-thundering-axolotl-of-examination-aaa6ba@quoll>

On 10/23/2026 9:28 AM, Krzysztof Kozlowski wrote:
> On Tue, Oct 20, 2026 at 10:14:58AM +0100, Diogo Ivo wrote:
>> Add support for the I3C Bus Interface on the Renesas RZ/G3L (R9A08G046)
>> SoC by adding the renesas,r9a08g046-i3c compatible to the OF match
>> table.
>>
>> The controller is very similar to the IP on the RZ/G3S. However, for
>> instance the RZ/G3L variant has no HDR Exit Pattern detection interrupt:
>> RZ/G3S exposes 17 interrupts, while RZ/G3L exposes 16. A RZ/G3L node
>> therefore cannot be described with the RZ/G3S compatible, as its bindings
>> require at least 17 interrupts. The same point applies to RZ/G3E, that
>> requires 3 clocks while the RZ/G3L requires 2.
>>
>> >From the driver point of view there is no difference between the two
>> SoCs: the driver only consumes the tclk clock, the presetn and tresetn
>> resets and seven named interrupts (resp, rx, tx, st, sp, tend, nack),
>> all of which are among the 16 shared ones. No driver changes are needed
>> besides the new compatible.
>>
>> Signed-off-by: Diogo Ivo <diogo.ivo.sx@renesas.com>
>> ---
>>   drivers/i3c/master/renesas-i3c.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
>> index 4fddc1b4fdbb..80a6df1151bf 100644
>> --- a/drivers/i3c/master/renesas-i3c.c
>> +++ b/drivers/i3c/master/renesas-i3c.c
>> @@ -1625,6 +1625,7 @@ static const struct dev_pm_ops renesas_i3c_pm_ops = {
>>
>>   static const struct of_device_id renesas_i3c_of_ids[] = {
>>        { .compatible = "renesas,r9a08g045-i3c" },
>> +     { .compatible = "renesas,r9a08g046-i3c" },
> 
> So fully compatible? If so, drop this and express compatibility in the
> bindings.

Ok, I will drop this patch and use the fallback to the G3S instead, as 
per Biju's comment on the HW differences between G3{L, S} and G3E.

Thanks for the review,
Diogo

> Best regards,
> Krzysztof


  parent reply	other threads:[~2026-10-23 15:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  9:14 [PATCH 0/8] " Diogo Ivo
2026-10-20  9:14 ` [PATCH 1/8] i3c: renesas: Fix zero I2C SCL rate on pure I3C buses Diogo Ivo
2026-10-20  9:27   ` Geert Uytterhoeven
2026-10-20 14:13     ` Diogo Ivo
2026-10-23 10:27   ` Wolfram Sang
2026-10-23 15:04     ` Diogo Ivo
2026-10-20  9:14 ` [PATCH 2/8] i3c: renesas: Drop comma after OF match table sentinel Diogo Ivo
2026-10-20 19:20   ` Frank Li
2026-10-23 10:27   ` Wolfram Sang
2026-10-20  9:14 ` [PATCH 3/8] dt-bindings: i3c: renesas,i3c: Add RZ/G3L support Diogo Ivo
2026-10-20 19:23   ` Frank Li
2026-10-23  8:27   ` Krzysztof Kozlowski
2026-10-20  9:14 ` [PATCH 4/8] i3c: renesas: " Diogo Ivo
2026-10-20 19:29   ` Frank Li
2026-10-23  8:28   ` Krzysztof Kozlowski
2026-10-23 10:45     ` Wolfram Sang
2026-10-23 11:01       ` Biju Das
2026-10-23 11:25         ` Krzysztof Kozlowski
2026-10-23 15:08     ` Diogo Ivo [this message]
2026-10-20  9:14 ` [PATCH 5/8] clk: renesas: r9a08g046: Add I3C clocks and resets Diogo Ivo
2026-10-20  9:15 ` [PATCH 6/8] pinctrl: renesas: rzg2l: Split SoC-specific masks in struct rzg2l_register_masks Diogo Ivo
2026-10-20  9:15 ` [PATCH 7/8] pinctrl: renesas: rzg2l: Add RZ/G3L support for selecting I3C power source Diogo Ivo
2026-10-20  9:15 ` [PATCH 8/8] arm64: dts: renesas: r9a08g046: Add I3C support Diogo Ivo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ab43b52-0ee0-4e9f-871c-708736023b4b@renesas.com \
    --to=diogo.ivo.sx@renesas.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tommaso.merciai.xr@bp.renesas.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®