From: "Moger, Babu" <bmoger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
Babu Moger <babu.moger@amd.com>,
bp@alien8.de, tony.luck@intel.com
Cc: tglx@kernel.org, mingo@redhat.com, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, Dave.Martin@arm.com,
james.morse@arm.com, dapeng1.mi@linux.intel.com,
peterz@infradead.org, thomas.lendacky@amd.com,
chang.seok.bae@intel.com, jmattson@google.com,
kim.phillips@amd.com, prathyushi.nangia@amd.com, acme@redhat.com,
nik.borisov@suse.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] x86/resctrl: Rename AMD resctrl MSR defines to use MSR_AMD_ prefix
Date: Wed, 30 Sep 2026 17:45:42 -0500 [thread overview]
Message-ID: <1bcdfce7-c3cf-49d4-a3e1-e293edd1bc62@amd.com> (raw)
In-Reply-To: <1f27dd5d-eb95-4eae-bbe0-f57ec6210a95@intel.com>
Hi Reinette,
On 9/30/2026 12:23 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 9/29/26 3:39 PM, Babu Moger wrote:
>> ---
>> arch/x86/include/asm/msr-index.h | 10 +++++-----
>> arch/x86/kernel/cpu/resctrl/core.c | 4 ++--
>> arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 6 +++---
>> arch/x86/kernel/cpu/resctrl/internal.h | 6 +++---
>> arch/x86/kernel/cpu/resctrl/monitor.c | 8 ++++----
>> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 4 ++--
>> fs/resctrl/rdtgroup.c | 4 ++--
>
> nit: subject prefix is missing the update to filesystem code:
> x86,fs/resctrl: Rename AMD resctrl MSR defines to use MSR_AMD_ prefix
Sure.
>
> sidenote (not a critique of this change since it just renames
> existing things): we should aim to avoid using architecture
> specific register names in resctrl filesystem code.
Agree.
>
> | Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>
Thanks
Babu
prev parent reply other threads:[~2026-09-30 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 22:39 Babu Moger
2026-09-29 22:39 ` [PATCH v2 2/2] x86,fs/resctrl: Use a consistent log prefix Babu Moger
2026-09-29 23:04 ` Luck, Tony
2026-09-30 13:47 ` Babu Moger
2026-09-30 17:24 ` Reinette Chatre
2026-09-30 22:47 ` Moger, Babu
2026-09-30 17:23 ` [PATCH v2 1/2] x86/resctrl: Rename AMD resctrl MSR defines to use MSR_AMD_ prefix Reinette Chatre
2026-09-30 22:45 ` Moger, Babu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bcdfce7-c3cf-49d4-a3e1-e293edd1bc62@amd.com \
--to=bmoger@amd.com \
--cc=Dave.Martin@arm.com \
--cc=acme@redhat.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nik.borisov@suse.com \
--cc=peterz@infradead.org \
--cc=prathyushi.nangia@amd.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®