Re: [PATCH v2 2/2] x86,fs/resctrl: Use a consistent log prefix

[Babu Moger <babu.moger@amd.com>]

Hi Tony,

On 9/29/26 18:04, Luck, Tony wrote:
> On Tue, Sep 29, 2026 at 05:39:04PM -0500, Babu Moger wrote:
>> resctrl code is split between arch and fs/resctrl/. Some files derive the
>> printk prefix from KBUILD_MODNAME, while others use "resctrl: ". Since
>> KBUILD_MODNAME follows the object name, messages use different prefixes
>> such as "rdtgroup:", "ctrlmondata:", and "pseudo_lock:".
>>
>> Use "resctrl: " throughout both directories so all resctrl messages have
>> the same subsystem prefix.
>>
>> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>> v2: New patch. The issue came up during the discussion of PLZA series.
>>      https://lore.kernel.org/lkml/432f0cbfb811aee3c8c51bbc42faf66174375d8b.1787772750.git.babu.moger@amd.com/
>> ---
>>   arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 2 +-
>>   arch/x86/kernel/cpu/resctrl/intel_aet.c   | 2 +-
>>   arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
>>   arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 2 +-
>>   fs/resctrl/ctrlmondata.c                  | 2 +-
>>   fs/resctrl/pseudo_lock.c                  | 2 +-
>>   fs/resctrl/rdtgroup.c                     | 2 +-
>>   7 files changed, 7 insertions(+), 7 deletions(-)
> 
> These are all good.
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>

Thank you.

> 
> Note that ARM have done something different:

Yes. I noticed that. I wasn't sure about changing it. let's hear 
everyone's thoughts.

> 
> $ git grep 'define pr_fmt' -- drivers/resctrl
> drivers/resctrl/mpam_devices.c:#define pr_fmt(fmt) "%s:%s: " fmt, KBUILD_MODNAME, __func__
> drivers/resctrl/mpam_resctrl.c:#define pr_fmt(fmt) "%s:%s: " fmt, KBUILD_MODNAME, __func__
> 
> Perhaps up to James & co. whether they want to jump on this alignment or
> keep their more specific messages identifying file and function name.
> 
> -Tony

Thanks
Babu