mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Babu Moger <babu.moger@amd.com>
Cc: <bp@alien8.de>, <reinette.chatre@intel.com>, <tglx@kernel.org>,
	<mingo@redhat.com>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <Dave.Martin@arm.com>,
	<james.morse@arm.com>, <dapeng1.mi@linux.intel.com>,
	<peterz@infradead.org>, <thomas.lendacky@amd.com>,
	<chang.seok.bae@intel.com>, <jmattson@google.com>,
	<kim.phillips@amd.com>, <prathyushi.nangia@amd.com>,
	<acme@redhat.com>, <nik.borisov@suse.com>, <namhyung@kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] x86,fs/resctrl: Use a consistent log prefix
Date: Tue, 29 Sep 2026 16:04:39 -0700	[thread overview]
Message-ID: <arxEB24S2bO1ALm2@agluck-desk3> (raw)
In-Reply-To: <bc637e9a1f0c4624a01b8208f0e53582cbf21886.1790721445.git.babu.moger@amd.com>

On Tue, Sep 29, 2026 at 05:39:04PM -0500, Babu Moger wrote:
> resctrl code is split between arch and fs/resctrl/. Some files derive the
> printk prefix from KBUILD_MODNAME, while others use "resctrl: ". Since
> KBUILD_MODNAME follows the object name, messages use different prefixes
> such as "rdtgroup:", "ctrlmondata:", and "pseudo_lock:".
> 
> Use "resctrl: " throughout both directories so all resctrl messages have
> the same subsystem prefix.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> v2: New patch. The issue came up during the discussion of PLZA series.
>     https://lore.kernel.org/lkml/432f0cbfb811aee3c8c51bbc42faf66174375d8b.1787772750.git.babu.moger@amd.com/
> ---
>  arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 2 +-
>  arch/x86/kernel/cpu/resctrl/intel_aet.c   | 2 +-
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 2 +-
>  fs/resctrl/ctrlmondata.c                  | 2 +-
>  fs/resctrl/pseudo_lock.c                  | 2 +-
>  fs/resctrl/rdtgroup.c                     | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)

These are all good.

Reviewed-by: Tony Luck <tony.luck@intel.com>

Note that ARM have done something different:

$ git grep 'define pr_fmt' -- drivers/resctrl
drivers/resctrl/mpam_devices.c:#define pr_fmt(fmt) "%s:%s: " fmt, KBUILD_MODNAME, __func__
drivers/resctrl/mpam_resctrl.c:#define pr_fmt(fmt) "%s:%s: " fmt, KBUILD_MODNAME, __func__

Perhaps up to James & co. whether they want to jump on this alignment or
keep their more specific messages identifying file and function name.

-Tony

      reply	other threads:[~2026-09-29 23:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 22:39 [PATCH v2 1/2] x86/resctrl: Rename AMD resctrl MSR defines to use MSR_AMD_ prefix Babu Moger
2026-09-29 22:39 ` [PATCH v2 2/2] x86,fs/resctrl: Use a consistent log prefix Babu Moger
2026-09-29 23:04   ` Luck, Tony [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arxEB24S2bO1ALm2@agluck-desk3 \
    --to=tony.luck@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=acme@redhat.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jmattson@google.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=nik.borisov@suse.com \
    --cc=peterz@infradead.org \
    --cc=prathyushi.nangia@amd.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®