From: tndave <tushar.n.dave@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: chris.hyser@oracle.com, sowmini.varadhan@oracle.com,
vgupta@synopsys.com, robin.murphy@arm.com, jroedel@suse.de,
egtvedt@samfundet.no, krzk@kernel.org, rkuo@codeaurora.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support
Date: Mon, 24 Oct 2016 13:40:06 -0700 [thread overview]
Message-ID: <1be31752-6f6d-e28e-9e30-835c8b7b8395@oracle.com> (raw)
In-Reply-To: <20161024.134645.2216722602983259081.davem@davemloft.net>
On 10/24/2016 10:46 AM, David Miller wrote:
> From: Tushar Dave <tushar.n.dave@oracle.com>
> Date: Mon, 10 Oct 2016 11:12:03 -0700
>
>> + /* calculate size of IOTSB */
>> + table_size = (atu->size / IO_PAGE_SIZE) * 8;
>> + table = kzalloc(table_size, GFP_KERNEL);
>> + if (!table) {
>> + err = -ENOMEM;
>> + goto table_failed;
>> + }
>> + table = (void *)IO_PAGE_ALIGN((u64)table);
>
> If you use the page allocator directly you can avoid all of these
> funny alignment calculations.
Okay. I will look into this.
>
>> @@ -931,8 +1046,10 @@ static int pci_sun4v_probe(struct platform_device *op)
>> struct pci_pbm_info *pbm;
>> struct device_node *dp;
>> struct iommu *iommu;
>> + struct atu *atu;
>> u32 devhandle;
>> int i, err = -ENODEV;
>> + static bool hv_atu = 1;
>
> Please use true/false with boolean variables.
Sure.
>
>> + hv_atu = 0;
>
> Likewise.
>
Thanks.
-Tushar
next prev parent reply other threads:[~2016-10-24 20:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 18:12 [PATCH 0/6] sparc: Enable sun4v hypervisor PCI IOMMU v2 APIs and ATU Tushar Dave
2016-10-10 18:12 ` [PATCH 1/6] sparc64: Add FORCE_MAX_ZONEORDER and default to 13 Tushar Dave
2016-10-24 17:45 ` David Miller
2016-10-24 18:31 ` tndave
2016-10-24 18:32 ` David Miller
2016-10-10 18:12 ` [PATCH 2/6] sparc64: Add ATU (new IOMMU) support Tushar Dave
2016-10-24 17:46 ` David Miller
2016-10-24 20:40 ` tndave [this message]
2016-10-10 18:12 ` [PATCH 3/6] sparc64: Initialize iommu_map_table and iommu_pool Tushar Dave
2016-10-24 17:47 ` David Miller
2016-10-24 20:36 ` tndave
2016-10-10 18:12 ` [PATCH 4/6] sparc64: Bind PCIe devices to use IOMMU v2 service Tushar Dave
2016-10-10 18:12 ` [PATCH 5/6] sparc64: Enable sun4v dma ops to use IOMMU v2 APIs Tushar Dave
2016-10-10 18:12 ` [PATCH 6/6] sparc64: Enable 64-bit DMA Tushar Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1be31752-6f6d-e28e-9e30-835c8b7b8395@oracle.com \
--to=tushar.n.dave@oracle.com \
--cc=chris.hyser@oracle.com \
--cc=davem@davemloft.net \
--cc=egtvedt@samfundet.no \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkuo@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®