From: tndave <tushar.n.dave@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: chris.hyser@oracle.com, sowmini.varadhan@oracle.com,
vgupta@synopsys.com, robin.murphy@arm.com, jroedel@suse.de,
egtvedt@samfundet.no, krzk@kernel.org, rkuo@codeaurora.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] sparc64: Initialize iommu_map_table and iommu_pool
Date: Mon, 24 Oct 2016 13:36:54 -0700 [thread overview]
Message-ID: <91dd06dd-22bd-c50a-4a6f-f45334b13b4a@oracle.com> (raw)
In-Reply-To: <20161024.134750.374485400910042905.davem@davemloft.net>
On 10/24/2016 10:47 AM, David Miller wrote:
> From: Tushar Dave <tushar.n.dave@oracle.com>
> Date: Mon, 10 Oct 2016 11:12:04 -0700
>
>> Like legacy IOMMU, use common iommu_map_table and iommu_pool for ATU.
>> This change initializes iommu_map_table and iommu_pool for ATU.
>>
>> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
>> Reviewed-by: chris hyser <chris.hyser@oracle.com>
>> Reviewed-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
>
> I suspect you are adding a bisection problem here.
>
> It looks to me like patch #2 starts setting up to use the ATU
> but these changes in #3 and later are necessary for it to even
> work properly.
>
> You can't leave the tree in an intermediate non-working state
> between changes like that.
I agree but even if you apply only patch #1, #2 things still work using
legacy IOMMU. (and the same is true for rest of the other patches i.e.
#3, #4, #5).
All the patches, except patch #6 , sets up needed data structures and
functions for ATU however ATU will only be used in action after you
apply patch #6 which actually enables 64bit DMA. Until then, things are
going to work using legacy IOMMU with 32bit DMA.
Thanks.
-Tushar
>
next prev parent reply other threads:[~2016-10-24 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 18:12 [PATCH 0/6] sparc: Enable sun4v hypervisor PCI IOMMU v2 APIs and ATU Tushar Dave
2016-10-10 18:12 ` [PATCH 1/6] sparc64: Add FORCE_MAX_ZONEORDER and default to 13 Tushar Dave
2016-10-24 17:45 ` David Miller
2016-10-24 18:31 ` tndave
2016-10-24 18:32 ` David Miller
2016-10-10 18:12 ` [PATCH 2/6] sparc64: Add ATU (new IOMMU) support Tushar Dave
2016-10-24 17:46 ` David Miller
2016-10-24 20:40 ` tndave
2016-10-10 18:12 ` [PATCH 3/6] sparc64: Initialize iommu_map_table and iommu_pool Tushar Dave
2016-10-24 17:47 ` David Miller
2016-10-24 20:36 ` tndave [this message]
2016-10-10 18:12 ` [PATCH 4/6] sparc64: Bind PCIe devices to use IOMMU v2 service Tushar Dave
2016-10-10 18:12 ` [PATCH 5/6] sparc64: Enable sun4v dma ops to use IOMMU v2 APIs Tushar Dave
2016-10-10 18:12 ` [PATCH 6/6] sparc64: Enable 64-bit DMA Tushar Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91dd06dd-22bd-c50a-4a6f-f45334b13b4a@oracle.com \
--to=tushar.n.dave@oracle.com \
--cc=chris.hyser@oracle.com \
--cc=davem@davemloft.net \
--cc=egtvedt@samfundet.no \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkuo@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®