From: David Miller <davem@davemloft.net>
To: tushar.n.dave@oracle.com
Cc: chris.hyser@oracle.com, sowmini.varadhan@oracle.com,
vgupta@synopsys.com, robin.murphy@arm.com, jroedel@suse.de,
egtvedt@samfundet.no, krzk@kernel.org, rkuo@codeaurora.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support
Date: Mon, 24 Oct 2016 13:46:45 -0400 (EDT) [thread overview]
Message-ID: <20161024.134645.2216722602983259081.davem@davemloft.net> (raw)
In-Reply-To: <1476123127-24314-3-git-send-email-tushar.n.dave@oracle.com>
From: Tushar Dave <tushar.n.dave@oracle.com>
Date: Mon, 10 Oct 2016 11:12:03 -0700
> + /* calculate size of IOTSB */
> + table_size = (atu->size / IO_PAGE_SIZE) * 8;
> + table = kzalloc(table_size, GFP_KERNEL);
> + if (!table) {
> + err = -ENOMEM;
> + goto table_failed;
> + }
> + table = (void *)IO_PAGE_ALIGN((u64)table);
If you use the page allocator directly you can avoid all of these
funny alignment calculations.
> @@ -931,8 +1046,10 @@ static int pci_sun4v_probe(struct platform_device *op)
> struct pci_pbm_info *pbm;
> struct device_node *dp;
> struct iommu *iommu;
> + struct atu *atu;
> u32 devhandle;
> int i, err = -ENODEV;
> + static bool hv_atu = 1;
Please use true/false with boolean variables.
> + hv_atu = 0;
Likewise.
next prev parent reply other threads:[~2016-10-24 17:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 18:12 [PATCH 0/6] sparc: Enable sun4v hypervisor PCI IOMMU v2 APIs and ATU Tushar Dave
2016-10-10 18:12 ` [PATCH 1/6] sparc64: Add FORCE_MAX_ZONEORDER and default to 13 Tushar Dave
2016-10-24 17:45 ` David Miller
2016-10-24 18:31 ` tndave
2016-10-24 18:32 ` David Miller
2016-10-10 18:12 ` [PATCH 2/6] sparc64: Add ATU (new IOMMU) support Tushar Dave
2016-10-24 17:46 ` David Miller [this message]
2016-10-24 20:40 ` tndave
2016-10-10 18:12 ` [PATCH 3/6] sparc64: Initialize iommu_map_table and iommu_pool Tushar Dave
2016-10-24 17:47 ` David Miller
2016-10-24 20:36 ` tndave
2016-10-10 18:12 ` [PATCH 4/6] sparc64: Bind PCIe devices to use IOMMU v2 service Tushar Dave
2016-10-10 18:12 ` [PATCH 5/6] sparc64: Enable sun4v dma ops to use IOMMU v2 APIs Tushar Dave
2016-10-10 18:12 ` [PATCH 6/6] sparc64: Enable 64-bit DMA Tushar Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024.134645.2216722602983259081.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.hyser@oracle.com \
--cc=egtvedt@samfundet.no \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkuo@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=tushar.n.dave@oracle.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®