Re: [PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static

[Alessio Belle <Alessio.Belle@imgtec.com>]

Hi Ben,

On Fri, 2026-07-03 at 17:23 +0100, Ben Dooks wrote:
> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
> so make it static to avoid the following sparse warning:
> 
> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
> 
> Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")?

nit: the "?" at the end

> Revied-by: Alessio Belle <Alessio.Belle@imgtec.com>

nit: Revied-by -> Reviewed-by

I can fixup these manually after applying the patch, if you are fine with it,
unless you prefer to send a v3.

Planning to apply this patch to drm-misc-fixes by the end of this week.

Thanks,
Alessio

> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> v2:
>   - added fixes tag
> ---
>  drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> index 6bb5baa6c41b..805d9f9bc1dd 100644
> --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
> +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> @@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp)
>  	return 0;
>  }
>  
> -const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
> +static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
>  	.set = pvr_fw_trace_init_mask_set,
>  	.get = param_get_hexint,
>  };