From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Alessio Belle <Alessio.Belle@imgtec.com>
Cc: "tzimmermann@suse.de" <tzimmermann@suse.de>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"matt.coster@imgtec.com" <matt.coster@imgtec.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@gmail.com" <airlied@gmail.com>,
Frank Binns <Frank.Binns@imgtec.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static
Date: Mon, 6 Jul 2026 17:37:58 +0100 [thread overview]
Message-ID: <45e86efe-28a6-491c-80c6-79b2dd947cf5@codethink.co.uk> (raw)
In-Reply-To: <1c7c5867cfba89094d39e5178cc281c0cc9c87fa.camel@imgtec.com>
On 06/07/2026 17:31, Alessio Belle wrote:
> Hi Ben,
>
> On Fri, 2026-07-03 at 17:23 +0100, Ben Dooks wrote:
>> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
>> so make it static to avoid the following sparse warning:
>>
>> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
>>
>> Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")?
>
> nit: the "?" at the end
>
>> Revied-by: Alessio Belle <Alessio.Belle@imgtec.com>
>
> nit: Revied-by -> Reviewed-by
>
> I can fixup these manually after applying the patch, if you are fine with it,
> unless you prefer to send a v3.
>
> Planning to apply this patch to drm-misc-fixes by the end of this week.
Please go ahead and fixup the issues before applying.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2026-07-06 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 16:23 Ben Dooks
2026-07-06 16:31 ` Alessio Belle
2026-07-06 16:37 ` Ben Dooks [this message]
2026-07-09 14:13 ` Alessio Belle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e86efe-28a6-491c-80c6-79b2dd947cf5@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=Alessio.Belle@imgtec.com \
--cc=Frank.Binns@imgtec.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®