[PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static

[PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static

[Ben Dooks]

The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
so make it static to avoid the following sparse warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?

Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")?
Revied-by: Alessio Belle <Alessio.Belle@imgtec.com>
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
v2:
  - added fixes tag
---
 drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c
index 6bb5baa6c41b..805d9f9bc1dd 100644
--- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
+++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
@@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp)
 	return 0;
 }
 
-const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
+static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
 	.set = pvr_fw_trace_init_mask_set,
 	.get = param_get_hexint,
 };
-- 
2.37.2.352.g3c44437643

Re: [PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static

[Alessio Belle]

Hi Ben,

On Fri, 2026-07-03 at 17:23 +0100, Ben Dooks wrote:
> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
> so make it static to avoid the following sparse warning:
> 
> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
> 
> Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")?

nit: the "?" at the end

> Revied-by: Alessio Belle <Alessio.Belle@imgtec.com>

nit: Revied-by -> Reviewed-by

I can fixup these manually after applying the patch, if you are fine with it,
unless you prefer to send a v3.

Planning to apply this patch to drm-misc-fixes by the end of this week.

Thanks,
Alessio

> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> v2:
>   - added fixes tag
> ---
>  drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> index 6bb5baa6c41b..805d9f9bc1dd 100644
> --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
> +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> @@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp)
>  	return 0;
>  }
>  
> -const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
> +static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
>  	.set = pvr_fw_trace_init_mask_set,
>  	.get = param_get_hexint,
>  };

Re: [PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static

[Ben Dooks]

On 06/07/2026 17:31, Alessio Belle wrote:
> Hi Ben,
> 
> On Fri, 2026-07-03 at 17:23 +0100, Ben Dooks wrote:
>> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
>> so make it static to avoid the following sparse warning:
>>
>> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
>>
>> Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")?
> 
> nit: the "?" at the end
> 
>> Revied-by: Alessio Belle <Alessio.Belle@imgtec.com>
> 
> nit: Revied-by -> Reviewed-by
> 
> I can fixup these manually after applying the patch, if you are fine with it,
> unless you prefer to send a v3.
> 
> Planning to apply this patch to drm-misc-fixes by the end of this week.

Please go ahead and fixup the issues before applying.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html

Re: [PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static

[Alessio Belle]

On Fri, 03 Jul 2026 17:23:38 +0100, Ben Dooks wrote:
> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
> so make it static to avoid the following sparse warning:
> 
> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
> 
> 

Applied, thanks!

[1/1] drm/imagination: make pvr_fw_trace_init_mask_ops static
      commit: c804aadc4ce3dcb34d6f2ecc9a159c148210805a

Best regards,
-- 
Alessio Belle <alessio.belle@imgtec.com>