From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Frank Li <Frank.li@nxp.com>, Frieder Schrempf <frieder@fris.de>
Cc: Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH 2/4] arm64: dts: imx8mp-kontron: Fix SD card supply on SMARC eval carrier
Date: Thu, 19 Feb 2026 08:51:32 +0100 [thread overview]
Message-ID: <1c86a997-4781-4816-9e90-35b15e2b0146@kontron.de> (raw)
In-Reply-To: <aZXv6QSq-ydOX5Wt@lizhi-Precision-Tower-5810>
Hi Frank,
On 18.02.26 17:59, Frank Li wrote:
> On Wed, Feb 18, 2026 at 02:25:06PM +0100, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> The SMARC eval carrier has a power switch for the SD card compliant
>> to the OSM standard definition. To use this as already specified in
>> the OSM base devicetree, stop overriding it in the board tree.
>>
>> This fixes the power-supply for the SC card.
>
> Is below commit better?
Do you mean "commit message"?
Did you run my message through a LLM to enhance it and now feed it back
to me?
If yes, it is a very strange way to waste GPU cycles and developer time.
>
> ARM: dts: imx8mp-sm2s-imx8mp: Drop SD power-supply override
The subject line is completely wrong.
>
> The SMARC evaluation carrier provides an SD card power switch that complies
> with the OSM standard definition. The OSM base device tree already
> describes this correctly.
>
> Stop overriding the SD power-supply in the board device tree and rely on
> the definition from the OSM base DTS instead to fix the power-supply
> configuration for the SD card.
Ok, maybe this rephrasing is slightly better to read, but again: is this
really worth the efforts? And it doesn't even correct my mistake of
using either 'vmmc-supply' to refer to the property or "power supply"
without a dash.
Thanks
Frieder
>
>>
>> Fixes: 6fe1ced5ccab7 ("arm64: dts: Add support for Kontron i.MX8MP SMARC module and eval carrier")
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>> .../boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts b/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
>> index 2173a36ff6917..74d620dd06b7b 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
>> @@ -249,6 +249,5 @@ &usb3_phy1 {
>> };
>>
>> &usdhc2 {
>> - vmmc-supply = <®_vdd_3v3>;
>> status = "okay";
>> };
>> --
>> 2.52.0
>>
next prev parent reply other threads:[~2026-02-19 7:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 13:25 [PATCH 0/4] Kontron i.MX8MP OSM Devicetree Fixups Frieder Schrempf
2026-02-18 13:25 ` [PATCH 1/4] arm64: dts: imx8mp-kontron: Fix touch reset configuration on DL devices Frieder Schrempf
2026-02-18 16:55 ` Frank Li
2026-02-18 13:25 ` [PATCH 2/4] arm64: dts: imx8mp-kontron: Fix SD card supply on SMARC eval carrier Frieder Schrempf
2026-02-18 16:59 ` Frank Li
2026-02-19 7:51 ` Frieder Schrempf [this message]
2026-02-19 17:38 ` Frank Li
2026-02-20 10:35 ` Frieder Schrempf
2026-02-18 13:25 ` [PATCH 3/4] arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC Frieder Schrempf
2026-02-18 17:01 ` Frank Li
2026-02-19 7:54 ` Frieder Schrempf
2026-02-18 13:25 ` [PATCH 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree Frieder Schrempf
2026-02-18 17:02 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c86a997-4781-4816-9e90-35b15e2b0146@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder@fris.de \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®