Re: [PATCH 2/4] arm64: dts: imx8mp-kontron: Fix SD card supply on SMARC eval carrier

[Frank Li <Frank.li@nxp.com>]

On Thu, Feb 19, 2026 at 08:51:32AM +0100, Frieder Schrempf wrote:
> Hi Frank,
>
> On 18.02.26 17:59, Frank Li wrote:
> > On Wed, Feb 18, 2026 at 02:25:06PM +0100, Frieder Schrempf wrote:
> >> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>
> >> The SMARC eval carrier has a power switch for the SD card compliant
> >> to the OSM standard definition. To use this as already specified in
> >> the OSM base devicetree, stop overriding it in the board tree.
> >>
> >> This fixes the power-supply for the SC card.
> >
> > Is below commit better?
>
> Do you mean "commit message"?
>
> Did you run my message through a LLM to enhance it and now feed it back
> to me?
>
> If yes, it is a very strange way to waste GPU cycles and developer time.

I used LLM for some unsatisfied commit message with LLM. I need make sure
other reviewers can understand the commit message easily and commit message
align submit-patch requirement before I can pick up it.

It is not waste GPU, which already found many problem although there are
some false alarm.

>
> >
> > ARM: dts: imx8mp-sm2s-imx8mp: Drop SD power-supply override
>
> The subject line is completely wrong.

sorry for typo 'power-supply', it should be 'mmc-supply'

subject should be "do (what) to"

drop vmmc-supply to fix ... or
drop vmmc-supply because it is already in base devicetree

>
> >
> > The SMARC evaluation carrier provides an SD card power switch that complies
> > with the OSM standard definition. The OSM base device tree already
> > describes this correctly.
> >
> > Stop overriding the SD power-supply in the board device tree and rely on
> > the definition from the OSM base DTS instead to fix the power-supply
> > configuration for the SD card.
>
> Ok, maybe this rephrasing is slightly better to read, but again: is this
> really worth the efforts? And it doesn't even correct my mistake of
> using either 'vmmc-supply' to refer to the property or "power supply"
> without a dash.

Sorry for typo,

Frank
>
> Thanks
> Frieder
>
> >
> >>
> >> Fixes: 6fe1ced5ccab7 ("arm64: dts: Add support for Kontron i.MX8MP SMARC module and eval carrier")
> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >> ---
> >>  .../boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts     | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts b/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
> >> index 2173a36ff6917..74d620dd06b7b 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
> >> @@ -249,6 +249,5 @@ &usb3_phy1 {
> >>  };
> >>
> >>  &usdhc2 {
> >> -	vmmc-supply = <&reg_vdd_3v3>;
> >>  	status = "okay";
> >>  };
> >> --
> >> 2.52.0
> >>
>