From: Jozsef Kadlecsik <kadlec@netfilter.org>
To: "Benjamin Szőke" <egyszeregy@freemail.hu>
Cc: fw@strlen.de, pablo@netfilter.org, lorenzo@kernel.org,
daniel@iogearbox.net, leitao@debian.org, amiculas@cisco.com,
davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 09/10] netfilter: Add message pragma for deprecated xt_*.h, ipt_*.h.
Date: Tue, 7 Jan 2025 20:39:52 +0100 (CET) [thread overview]
Message-ID: <1cd443f7-df1e-20cf-cfe8-f38ac72491e4@netfilter.org> (raw)
In-Reply-To: <20250107024120.98288-10-egyszeregy@freemail.hu>
[-- Attachment #1: Type: text/plain, Size: 4735 bytes --]
On Tue, 7 Jan 2025, egyszeregy@freemail.hu wrote:
> From: Benjamin Szőke <egyszeregy@freemail.hu>
>
> Display information about deprecated xt_*.h, ipt_*.h files
> at compile time. Recommended to use header files with
> lowercase name format in the future.
I still don't know whether adding the pragmas to notify about header file
deprecation is a good idea.
On my part that's all. Thank you the work!
Best regards,
Jozsef
> Signed-off-by: Benjamin Szőke <egyszeregy@freemail.hu>
> ---
> include/uapi/linux/netfilter/xt_CONNMARK.h | 2 ++
> include/uapi/linux/netfilter/xt_DSCP.h | 2 ++
> include/uapi/linux/netfilter/xt_MARK.h | 2 ++
> include/uapi/linux/netfilter/xt_RATEEST.h | 2 ++
> include/uapi/linux/netfilter/xt_TCPMSS.h | 2 ++
> include/uapi/linux/netfilter_ipv4/ipt_ECN.h | 2 ++
> include/uapi/linux/netfilter_ipv4/ipt_TTL.h | 2 ++
> include/uapi/linux/netfilter_ipv6/ip6t_HL.h | 2 ++
> 8 files changed, 16 insertions(+)
>
> diff --git a/include/uapi/linux/netfilter/xt_CONNMARK.h b/include/uapi/linux/netfilter/xt_CONNMARK.h
> index 171af24ef679..1bc991fd546a 100644
> --- a/include/uapi/linux/netfilter/xt_CONNMARK.h
> +++ b/include/uapi/linux/netfilter/xt_CONNMARK.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter/xt_connmark.h>
>
> +#pragma message("xt_CONNMARK.h header is deprecated. Use xt_connmark.h instead.")
> +
> #endif /* _XT_CONNMARK_TARGET_H */
> diff --git a/include/uapi/linux/netfilter/xt_DSCP.h b/include/uapi/linux/netfilter/xt_DSCP.h
> index fcff72347256..bd550292803d 100644
> --- a/include/uapi/linux/netfilter/xt_DSCP.h
> +++ b/include/uapi/linux/netfilter/xt_DSCP.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter/xt_dscp.h>
>
> +#pragma message("xt_DSCP.h header is deprecated. Use xt_dscp.h instead.")
> +
> #endif /* _XT_DSCP_TARGET_H */
> diff --git a/include/uapi/linux/netfilter/xt_MARK.h b/include/uapi/linux/netfilter/xt_MARK.h
> index cdc12c0954b3..9f6c03e26c96 100644
> --- a/include/uapi/linux/netfilter/xt_MARK.h
> +++ b/include/uapi/linux/netfilter/xt_MARK.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter/xt_mark.h>
>
> +#pragma message("xt_MARK.h header is deprecated. Use xt_mark.h instead.")
> +
> #endif /* _XT_MARK_H_TARGET_H */
> diff --git a/include/uapi/linux/netfilter/xt_RATEEST.h b/include/uapi/linux/netfilter/xt_RATEEST.h
> index f817b5387164..ec3d68f67b2f 100644
> --- a/include/uapi/linux/netfilter/xt_RATEEST.h
> +++ b/include/uapi/linux/netfilter/xt_RATEEST.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter/xt_rateest.h>
>
> +#pragma message("xt_RATEEST.h header is deprecated. Use xt_rateest.h instead.")
> +
> #endif /* _XT_RATEEST_TARGET_H */
> diff --git a/include/uapi/linux/netfilter/xt_TCPMSS.h b/include/uapi/linux/netfilter/xt_TCPMSS.h
> index 154e88c1de02..826060264766 100644
> --- a/include/uapi/linux/netfilter/xt_TCPMSS.h
> +++ b/include/uapi/linux/netfilter/xt_TCPMSS.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter/xt_tcpmss.h>
>
> +#pragma message("xt_TCPMSS.h header is deprecated. Use xt_tcpmss.h instead.")
> +
> #endif /* _XT_TCPMSS_TARGET_H */
> diff --git a/include/uapi/linux/netfilter_ipv4/ipt_ECN.h b/include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> index 6727f5a44512..42317fb3a4e9 100644
> --- a/include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> +++ b/include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter_ipv4/ipt_ecn.h>
>
> +#pragma message("ipt_ECN.h header is deprecated. Use ipt_ecn.h instead.")
> +
> #endif /* _IPT_ECN_TARGET_H */
> diff --git a/include/uapi/linux/netfilter_ipv4/ipt_TTL.h b/include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> index 5d989199ed28..1663493e4951 100644
> --- a/include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> +++ b/include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter_ipv4/ipt_ttl.h>
>
> +#pragma message("ipt_TTL.h header is deprecated. Use ipt_ttl.h instead.")
> +
> #endif /* _IPT_TTL_TARGET_H */
> diff --git a/include/uapi/linux/netfilter_ipv6/ip6t_HL.h b/include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> index bcf22824b393..55f08e20acd2 100644
> --- a/include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> +++ b/include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> @@ -4,4 +4,6 @@
>
> #include <linux/netfilter_ipv6/ip6t_hl.h>
>
> +#pragma message("ip6t_HL.h header is deprecated. Use ip6t_hl.h instead.")
> +
> #endif /* _IP6T_HL_TARGET_H */
> --
> 2.43.5
>
>
--
E-mail : kadlec@netfilter.org, kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
Address: Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
next prev parent reply other threads:[~2025-01-07 19:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 2:41 [PATCH 00/10] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name egyszeregy
2025-01-07 2:41 ` [PATCH 01/10] netfilter: x_tables: Merge xt_DSCP.h to xt_dscp.h egyszeregy
2025-01-07 19:23 ` Jozsef Kadlecsik
2025-01-07 21:38 ` Szőke Benjamin
2025-01-08 20:11 ` Jozsef Kadlecsik
2025-01-08 21:08 ` Szőke Benjamin
2025-01-09 14:59 ` Jozsef Kadlecsik
2025-01-07 2:41 ` [PATCH 02/10] netfilter: x_tables: Merge xt_RATEEST.h to xt_rateest.h egyszeregy
2025-01-07 2:41 ` [PATCH 03/10] netfilter: x_tables: Merge xt_TCPMSS.h to xt_tcpmss.h egyszeregy
2025-01-07 2:41 ` [PATCH 04/10] netfilter: x_tables: Use consistent header guard egyszeregy
2025-01-07 2:41 ` [PATCH 05/10] netfilter: iptables: Merge ipt_ECN.h to ipt_ecn.h egyszeregy
2025-01-07 19:26 ` Jozsef Kadlecsik
2025-01-07 21:48 ` Szőke Benjamin
2025-01-08 20:15 ` Jozsef Kadlecsik
2025-01-07 2:41 ` [PATCH 06/10] netfilter: iptables: Merge ipt_TTL.h to ipt_ttl.h egyszeregy
2025-01-07 2:41 ` [PATCH 07/10] netfilter: iptables: Merge ip6t_HL.h to ip6t_hl.h egyszeregy
2025-01-07 2:41 ` [PATCH 08/10] netfilter: Adjust code style of xt_*.h, ipt_*.h files egyszeregy
2025-01-07 19:39 ` Jozsef Kadlecsik
2025-01-07 21:59 ` Szőke Benjamin
2025-01-08 20:20 ` Jozsef Kadlecsik
2025-01-08 21:18 ` Szőke Benjamin
2025-01-07 2:41 ` [PATCH 09/10] netfilter: Add message pragma for deprecated xt_*.h, ipt_*.h egyszeregy
2025-01-07 19:39 ` Jozsef Kadlecsik [this message]
2025-01-07 22:06 ` Szőke Benjamin
2025-01-07 22:38 ` Jan Engelhardt
2025-01-07 23:24 ` Szőke Benjamin
2025-01-08 20:51 ` Jozsef Kadlecsik
2025-01-08 21:38 ` Szőke Benjamin
2025-01-09 10:22 ` Przemek Kitszel
2025-01-07 2:41 ` [PATCH 10/10] netfilter: Use merged xt_*.h, ipt_*.h headers egyszeregy
2025-01-07 19:14 ` [PATCH 00/10] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd443f7-df1e-20cf-cfe8-f38ac72491e4@netfilter.org \
--to=kadlec@netfilter.org \
--cc=amiculas@cisco.com \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=egyszeregy@freemail.hu \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®