From: "Szőke Benjamin" <egyszeregy@freemail.hu>
To: Jan Engelhardt <ej@inai.de>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
fw@strlen.de, pablo@netfilter.org, lorenzo@kernel.org,
daniel@iogearbox.net, leitao@debian.org, amiculas@cisco.com,
davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 09/10] netfilter: Add message pragma for deprecated xt_*.h, ipt_*.h.
Date: Wed, 8 Jan 2025 00:24:16 +0100 [thread overview]
Message-ID: <283ffe91-5181-4544-8913-e4d1d6895d5c@freemail.hu> (raw)
In-Reply-To: <n72qp2s8-00q1-3n32-n600-p59o2oqo7s43@vanv.qr>
2025. 01. 07. 23:38 keltezéssel, Jan Engelhardt írta:
>
> On Tuesday 2025-01-07 23:06, Szőke Benjamin wrote:
>>>
>>> I still don't know whether adding the pragmas to notify about header file
>>> deprecation is a good idea.
>>
>> Do you have any other ideas how can you display this information to the
>> users/customers, that it is time to stop using the uppercase header files then
>> they shall to use its merged lowercase named files instead in their userspace
>> SW?
>
> ``__attribute__`` is just as implementation-specific as ``#pragma``, so it's
> not really an improvement, but here goes:
>
> ----
> struct __attribute__((deprecated("This header file is deprecated"))) dontusethisstruct {
> };
> extern struct dontusethisstruct undefinedstruct;
> ----
As i know it is a feature only in GCC, can it work with Clang compiler?
https://renenyffenegger.ch/notes/development/languages/C-C-plus-plus/GCC/__attribute__/deprecated/index
By the way it is perfect for through a warning for a deprecated struct, function
etc ... only in GCC, but it is not ideal to use a simple header file include and
the syntax of it is horryble. Usage of a generic #pragma message is more
feasible in all compilers.
next prev parent reply other threads:[~2025-01-07 23:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 2:41 [PATCH 00/10] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name egyszeregy
2025-01-07 2:41 ` [PATCH 01/10] netfilter: x_tables: Merge xt_DSCP.h to xt_dscp.h egyszeregy
2025-01-07 19:23 ` Jozsef Kadlecsik
2025-01-07 21:38 ` Szőke Benjamin
2025-01-08 20:11 ` Jozsef Kadlecsik
2025-01-08 21:08 ` Szőke Benjamin
2025-01-09 14:59 ` Jozsef Kadlecsik
2025-01-07 2:41 ` [PATCH 02/10] netfilter: x_tables: Merge xt_RATEEST.h to xt_rateest.h egyszeregy
2025-01-07 2:41 ` [PATCH 03/10] netfilter: x_tables: Merge xt_TCPMSS.h to xt_tcpmss.h egyszeregy
2025-01-07 2:41 ` [PATCH 04/10] netfilter: x_tables: Use consistent header guard egyszeregy
2025-01-07 2:41 ` [PATCH 05/10] netfilter: iptables: Merge ipt_ECN.h to ipt_ecn.h egyszeregy
2025-01-07 19:26 ` Jozsef Kadlecsik
2025-01-07 21:48 ` Szőke Benjamin
2025-01-08 20:15 ` Jozsef Kadlecsik
2025-01-07 2:41 ` [PATCH 06/10] netfilter: iptables: Merge ipt_TTL.h to ipt_ttl.h egyszeregy
2025-01-07 2:41 ` [PATCH 07/10] netfilter: iptables: Merge ip6t_HL.h to ip6t_hl.h egyszeregy
2025-01-07 2:41 ` [PATCH 08/10] netfilter: Adjust code style of xt_*.h, ipt_*.h files egyszeregy
2025-01-07 19:39 ` Jozsef Kadlecsik
2025-01-07 21:59 ` Szőke Benjamin
2025-01-08 20:20 ` Jozsef Kadlecsik
2025-01-08 21:18 ` Szőke Benjamin
2025-01-07 2:41 ` [PATCH 09/10] netfilter: Add message pragma for deprecated xt_*.h, ipt_*.h egyszeregy
2025-01-07 19:39 ` Jozsef Kadlecsik
2025-01-07 22:06 ` Szőke Benjamin
2025-01-07 22:38 ` Jan Engelhardt
2025-01-07 23:24 ` Szőke Benjamin [this message]
2025-01-08 20:51 ` Jozsef Kadlecsik
2025-01-08 21:38 ` Szőke Benjamin
2025-01-09 10:22 ` Przemek Kitszel
2025-01-07 2:41 ` [PATCH 10/10] netfilter: Use merged xt_*.h, ipt_*.h headers egyszeregy
2025-01-07 19:14 ` [PATCH 00/10] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=283ffe91-5181-4544-8913-e4d1d6895d5c@freemail.hu \
--to=egyszeregy@freemail.hu \
--cc=amiculas@cisco.com \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=ej@inai.de \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®