mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Szőke Benjamin" <egyszeregy@freemail.hu>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: fw@strlen.de, pablo@netfilter.org, lorenzo@kernel.org,
	daniel@iogearbox.net, leitao@debian.org, amiculas@cisco.com,
	davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 08/10] netfilter: Adjust code style of xt_*.h, ipt_*.h files.
Date: Tue, 7 Jan 2025 22:59:21 +0100	[thread overview]
Message-ID: <4cf2e26b-2727-4b50-9ada-56a6be814dca@freemail.hu> (raw)
In-Reply-To: <2962ec51-4d32-76d9-4229-99001a437963@netfilter.org>

2025. 01. 07. 20:39 keltezéssel, Jozsef Kadlecsik írta:
> On Tue, 7 Jan 2025, egyszeregy@freemail.hu wrote:
> 
>> From: Benjamin Szőke <egyszeregy@freemail.hu>
>>
>> - Adjust tab indents
>> - Fix format of #define macros
> 
> I don't really understand why it'd be important to use parentheses around
> plain constant values in macros. The kernel coding style does not list it
> as a requirement, see 12) 4. in Documentation/process/coding-style.rst.
> 

If it would be more than just a const value, parentheses is a must have thing 
for it (now for it, it is not critical to have it but better to get used to 
this). This is how my hand automatically do it, to avoid the syntax problem in 
this coding.

> Best regards,
> Jozsef
>   
>> Signed-off-by: Benjamin Szőke <egyszeregy@freemail.hu>
>> ---
>>   include/uapi/linux/netfilter/xt_dscp.h      | 6 +++---
>>   include/uapi/linux/netfilter/xt_rateest.h   | 4 ++--
>>   include/uapi/linux/netfilter/xt_tcpmss.h    | 6 +++---
>>   include/uapi/linux/netfilter_ipv4/ipt_ecn.h | 8 ++++----
>>   include/uapi/linux/netfilter_ipv4/ipt_ttl.h | 3 +--
>>   include/uapi/linux/netfilter_ipv6/ip6t_hl.h | 3 +--
>>   6 files changed, 14 insertions(+), 16 deletions(-)
>>
>> diff --git a/include/uapi/linux/netfilter/xt_dscp.h b/include/uapi/linux/netfilter/xt_dscp.h
>> index bcfe4afa6351..22b6488ef2e7 100644
>> --- a/include/uapi/linux/netfilter/xt_dscp.h
>> +++ b/include/uapi/linux/netfilter/xt_dscp.h
>> @@ -15,9 +15,9 @@
>>   
>>   #include <linux/types.h>
>>   
>> -#define XT_DSCP_MASK	0xfc	/* 11111100 */
>> -#define XT_DSCP_SHIFT	2
>> -#define XT_DSCP_MAX	0x3f	/* 00111111 */
>> +#define XT_DSCP_MASK	(0xfc)	/* 11111100 */
>> +#define XT_DSCP_SHIFT	(2)
>> +#define XT_DSCP_MAX		(0x3f)	/* 00111111 */
>>   
>>   /* match info */
>>   struct xt_dscp_info {
>> diff --git a/include/uapi/linux/netfilter/xt_rateest.h b/include/uapi/linux/netfilter/xt_rateest.h
>> index da9727fa527b..f719bd501d1a 100644
>> --- a/include/uapi/linux/netfilter/xt_rateest.h
>> +++ b/include/uapi/linux/netfilter/xt_rateest.h
>> @@ -22,8 +22,8 @@ enum xt_rateest_match_mode {
>>   };
>>   
>>   struct xt_rateest_match_info {
>> -	char			name1[IFNAMSIZ];
>> -	char			name2[IFNAMSIZ];
>> +	char		name1[IFNAMSIZ];
>> +	char		name2[IFNAMSIZ];
>>   	__u16		flags;
>>   	__u16		mode;
>>   	__u32		bps1;
>> diff --git a/include/uapi/linux/netfilter/xt_tcpmss.h b/include/uapi/linux/netfilter/xt_tcpmss.h
>> index 3ee4acaa6e03..ad858ae93e6a 100644
>> --- a/include/uapi/linux/netfilter/xt_tcpmss.h
>> +++ b/include/uapi/linux/netfilter/xt_tcpmss.h
>> @@ -4,11 +4,11 @@
>>   
>>   #include <linux/types.h>
>>   
>> -#define XT_TCPMSS_CLAMP_PMTU	0xffff
>> +#define XT_TCPMSS_CLAMP_PMTU	(0xffff)
>>   
>>   struct xt_tcpmss_match_info {
>> -    __u16 mss_min, mss_max;
>> -    __u8 invert;
>> +	__u16 mss_min, mss_max;
>> +	__u8 invert;
>>   };
>>   
>>   struct xt_tcpmss_info {
>> diff --git a/include/uapi/linux/netfilter_ipv4/ipt_ecn.h b/include/uapi/linux/netfilter_ipv4/ipt_ecn.h
>> index a6d479aece21..0594dd49d13f 100644
>> --- a/include/uapi/linux/netfilter_ipv4/ipt_ecn.h
>> +++ b/include/uapi/linux/netfilter_ipv4/ipt_ecn.h
>> @@ -16,10 +16,10 @@
>>   
>>   #define ipt_ecn_info xt_ecn_info
>>   
>> -#define IPT_ECN_OP_SET_IP	0x01	/* set ECN bits of IPv4 header */
>> -#define IPT_ECN_OP_SET_ECE	0x10	/* set ECE bit of TCP header */
>> -#define IPT_ECN_OP_SET_CWR	0x20	/* set CWR bit of TCP header */
>> -#define IPT_ECN_OP_MASK		0xce
>> +#define IPT_ECN_OP_SET_IP	(0x01)	/* set ECN bits of IPv4 header */
>> +#define IPT_ECN_OP_SET_ECE	(0x10)	/* set ECE bit of TCP header */
>> +#define IPT_ECN_OP_SET_CWR	(0x20)	/* set CWR bit of TCP header */
>> +#define IPT_ECN_OP_MASK		(0xce)
>>   
>>   enum {
>>   	IPT_ECN_IP_MASK       = XT_ECN_IP_MASK,
>> diff --git a/include/uapi/linux/netfilter_ipv4/ipt_ttl.h b/include/uapi/linux/netfilter_ipv4/ipt_ttl.h
>> index c21eb6651353..15c75a4ba355 100644
>> --- a/include/uapi/linux/netfilter_ipv4/ipt_ttl.h
>> +++ b/include/uapi/linux/netfilter_ipv4/ipt_ttl.h
>> @@ -9,13 +9,12 @@
>>   #include <linux/types.h>
>>   
>>   enum {
>> -	IPT_TTL_EQ = 0,		/* equals */
>> +	IPT_TTL_EQ = 0,	/* equals */
>>   	IPT_TTL_NE,		/* not equals */
>>   	IPT_TTL_LT,		/* less than */
>>   	IPT_TTL_GT,		/* greater than */
>>   };
>>   
>> -
>>   struct ipt_ttl_info {
>>   	__u8	mode;
>>   	__u8	ttl;
>> diff --git a/include/uapi/linux/netfilter_ipv6/ip6t_hl.h b/include/uapi/linux/netfilter_ipv6/ip6t_hl.h
>> index caef38a63b8f..4af05c86dcd5 100644
>> --- a/include/uapi/linux/netfilter_ipv6/ip6t_hl.h
>> +++ b/include/uapi/linux/netfilter_ipv6/ip6t_hl.h
>> @@ -9,13 +9,12 @@
>>   #include <linux/types.h>
>>   
>>   enum {
>> -	IP6T_HL_EQ = 0,		/* equals */
>> +	IP6T_HL_EQ = 0,	/* equals */
>>   	IP6T_HL_NE,		/* not equals */
>>   	IP6T_HL_LT,		/* less than */
>>   	IP6T_HL_GT,		/* greater than */
>>   };
>>   
>> -
>>   struct ip6t_hl_info {
>>   	__u8	mode;
>>   	__u8	hop_limit;
>> -- 
>> 2.43.5
>>
>>
> 


  reply	other threads:[~2025-01-07 21:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07  2:41 [PATCH 00/10] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name egyszeregy
2025-01-07  2:41 ` [PATCH 01/10] netfilter: x_tables: Merge xt_DSCP.h to xt_dscp.h egyszeregy
2025-01-07 19:23   ` Jozsef Kadlecsik
2025-01-07 21:38     ` Szőke Benjamin
2025-01-08 20:11       ` Jozsef Kadlecsik
2025-01-08 21:08         ` Szőke Benjamin
2025-01-09 14:59           ` Jozsef Kadlecsik
2025-01-07  2:41 ` [PATCH 02/10] netfilter: x_tables: Merge xt_RATEEST.h to xt_rateest.h egyszeregy
2025-01-07  2:41 ` [PATCH 03/10] netfilter: x_tables: Merge xt_TCPMSS.h to xt_tcpmss.h egyszeregy
2025-01-07  2:41 ` [PATCH 04/10] netfilter: x_tables: Use consistent header guard egyszeregy
2025-01-07  2:41 ` [PATCH 05/10] netfilter: iptables: Merge ipt_ECN.h to ipt_ecn.h egyszeregy
2025-01-07 19:26   ` Jozsef Kadlecsik
2025-01-07 21:48     ` Szőke Benjamin
2025-01-08 20:15       ` Jozsef Kadlecsik
2025-01-07  2:41 ` [PATCH 06/10] netfilter: iptables: Merge ipt_TTL.h to ipt_ttl.h egyszeregy
2025-01-07  2:41 ` [PATCH 07/10] netfilter: iptables: Merge ip6t_HL.h to ip6t_hl.h egyszeregy
2025-01-07  2:41 ` [PATCH 08/10] netfilter: Adjust code style of xt_*.h, ipt_*.h files egyszeregy
2025-01-07 19:39   ` Jozsef Kadlecsik
2025-01-07 21:59     ` Szőke Benjamin [this message]
2025-01-08 20:20       ` Jozsef Kadlecsik
2025-01-08 21:18         ` Szőke Benjamin
2025-01-07  2:41 ` [PATCH 09/10] netfilter: Add message pragma for deprecated xt_*.h, ipt_*.h egyszeregy
2025-01-07 19:39   ` Jozsef Kadlecsik
2025-01-07 22:06     ` Szőke Benjamin
2025-01-07 22:38       ` Jan Engelhardt
2025-01-07 23:24         ` Szőke Benjamin
2025-01-08 20:51       ` Jozsef Kadlecsik
2025-01-08 21:38         ` Szőke Benjamin
2025-01-09 10:22           ` Przemek Kitszel
2025-01-07  2:41 ` [PATCH 10/10] netfilter: Use merged xt_*.h, ipt_*.h headers egyszeregy
2025-01-07 19:14 ` [PATCH 00/10] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cf2e26b-2727-4b50-9ada-56a6be814dca@freemail.hu \
    --to=egyszeregy@freemail.hu \
    --cc=amiculas@cisco.com \
    --cc=coreteam@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®