* [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel
2026-07-30 21:51 [PATCH 0/4] arm64: dts: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
@ 2026-07-30 21:52 ` Dawid Wróbel via B4 Relay
2026-08-04 8:10 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Dawid Wróbel via B4 Relay @ 2026-07-30 21:52 UTC (permalink / raw)
To: Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, Dawid Wróbel
From: Dawid Wróbel <me@dawidwrobel.com>
The Xiaomi Mi Pad 5 Pro 5G (enuma) ships the same CSOT panel as the Mi
Pad 5 Pro (elish), so it falls back to the elish compatible. Give it a
device-specific one in front, so a later difference does not need a
device tree change.
Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
index b9300a1f2646..2f3f34d08f29 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
@@ -22,6 +22,10 @@ properties:
- xiaomi,elish-boe-nt36523
- xiaomi,elish-csot-nt36523
- const: novatek,nt36523
+ - items:
+ - const: xiaomi,enuma-csot-nt36523
+ - const: xiaomi,elish-csot-nt36523
+ - const: novatek,nt36523
- items:
- enum:
- lenovo,j606f-boe-nt36523w
--
2.55.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel
2026-07-30 21:52 ` [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel Dawid Wróbel via B4 Relay
@ 2026-08-04 8:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 8:10 UTC (permalink / raw)
To: Dawid Wróbel
Cc: Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, dri-devel,
devicetree, linux-kernel, linux-arm-msm
On Thu, Jul 30, 2026 at 11:52:00PM +0200, Dawid Wróbel wrote:
> The Xiaomi Mi Pad 5 Pro 5G (enuma) ships the same CSOT panel as the Mi
> Pad 5 Pro (elish), so it falls back to the elish compatible. Give it a
> device-specific one in front, so a later difference does not need a
> device tree change.
>
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
> Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G
2026-07-30 21:51 [PATCH 0/4] arm64: dts: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
2026-07-30 21:52 ` [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel Dawid Wróbel via B4 Relay
@ 2026-07-30 21:52 ` Dawid Wróbel via B4 Relay
2026-08-04 8:09 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node Dawid Wróbel via B4 Relay
2026-07-30 21:52 ` [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
3 siblings, 1 reply; 10+ messages in thread
From: Dawid Wróbel via B4 Relay @ 2026-07-30 21:52 UTC (permalink / raw)
To: Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, Dawid Wróbel
From: Dawid Wróbel <me@dawidwrobel.com>
The Mi Pad 5 Pro 5G (enuma) is the modem-equipped variant of the Mi Pad
5 Pro (elish) and shares its board design, so it falls back to the elish
compatible.
Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index f8c37096df46..a19d0146ae4b 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1110,6 +1110,11 @@ properties:
- xiaomi,pipa
- const: qcom,sm8250
+ - items:
+ - const: xiaomi,enuma
+ - const: xiaomi,elish
+ - const: qcom,sm8250
+
- items:
- enum:
- microsoft,surface-duo2
--
2.55.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G
2026-07-30 21:52 ` [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
@ 2026-08-04 8:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 8:09 UTC (permalink / raw)
To: Dawid Wróbel
Cc: Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, dri-devel,
devicetree, linux-kernel, linux-arm-msm
On Thu, Jul 30, 2026 at 11:52:01PM +0200, Dawid Wróbel wrote:
> The Mi Pad 5 Pro 5G (enuma) is the modem-equipped variant of the Mi Pad
> 5 Pro (elish) and shares its board design, so it falls back to the elish
> compatible.
>
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node
2026-07-30 21:51 [PATCH 0/4] arm64: dts: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
2026-07-30 21:52 ` [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel Dawid Wróbel via B4 Relay
2026-07-30 21:52 ` [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
@ 2026-07-30 21:52 ` Dawid Wróbel via B4 Relay
2026-08-04 8:10 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
3 siblings, 1 reply; 10+ messages in thread
From: Dawid Wróbel via B4 Relay @ 2026-07-30 21:52 UTC (permalink / raw)
To: Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, Dawid Wróbel
From: Dawid Wróbel <me@dawidwrobel.com>
The Mi Pad 5 Pro 5G shares this device tree but needs its own board data
variant, so give the node a label to allow overriding the property.
Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
index 19aff83ecf7b..12a2ba48340f 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
@@ -817,7 +817,7 @@ &pcie0_phy {
};
&pcieport0 {
- wifi@0 {
+ wifi_0: wifi@0 {
compatible = "pci17cb,1101";
reg = <0x10000 0x0 0x0 0x0 0x0>;
--
2.55.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node
2026-07-30 21:52 ` [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node Dawid Wróbel via B4 Relay
@ 2026-08-04 8:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 8:10 UTC (permalink / raw)
To: Dawid Wróbel
Cc: Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, dri-devel,
devicetree, linux-kernel, linux-arm-msm
On Thu, Jul 30, 2026 at 11:52:02PM +0200, Dawid Wróbel wrote:
> The Mi Pad 5 Pro 5G shares this device tree but needs its own board data
> variant, so give the node a label to allow overriding the property.
>
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> index 19aff83ecf7b..12a2ba48340f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> @@ -817,7 +817,7 @@ &pcie0_phy {
> };
>
> &pcieport0 {
> - wifi@0 {
> + wifi_0: wifi@0 {
This is pointless on its own. Label does not end up in DTB, so your
patch has zero effect.
You miss the user of the label here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G
2026-07-30 21:51 [PATCH 0/4] arm64: dts: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
` (2 preceding siblings ...)
2026-07-30 21:52 ` [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node Dawid Wróbel via B4 Relay
@ 2026-07-30 21:52 ` Dawid Wróbel via B4 Relay
2026-08-18 10:48 ` Konrad Dybcio
3 siblings, 1 reply; 10+ messages in thread
From: Dawid Wróbel via B4 Relay @ 2026-07-30 21:52 UTC (permalink / raw)
To: Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, Dawid Wróbel
From: Dawid Wróbel <me@dawidwrobel.com>
The Mi Pad 5 Pro 5G (enuma, 2021) is the modem-equipped variant of the
Mi Pad 5 Pro. The board is otherwise the elish design, so describe it as
the common device tree plus its own board ID, panel compatible and WiFi
board data variant.
Unlike elish, this model shipped with a single display variant, so there
is one device tree rather than a per-panel pair.
Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts | 26 ++++++++++++++++++++++++
2 files changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index e05414290d8e..529e29ffb25a 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -369,6 +369,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-boe.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-csot.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-enuma.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-pipa.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
new file mode 100644
index 000000000000..7cc9ed7d12b2
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>
+ */
+
+/dts-v1/;
+
+#include "sm8250-xiaomi-elish-common.dtsi"
+
+/ {
+ model = "Xiaomi Mi Pad 5 Pro 5G";
+ compatible = "xiaomi,enuma", "xiaomi,elish", "qcom,sm8250";
+
+ /* Platform type differs from elish; msm-id is inherited unchanged. */
+ qcom,board-id = <0x2e 0>;
+};
+
+&display_panel {
+ compatible = "xiaomi,enuma-csot-nt36523", "xiaomi,elish-csot-nt36523",
+ "novatek,nt36523";
+ status = "okay";
+};
+
+&wifi_0 {
+ qcom,calibration-variant = "Xiaomi_Pad_5Pro_5G";
+};
--
2.55.0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G
2026-07-30 21:52 ` [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
@ 2026-08-18 10:48 ` Konrad Dybcio
2026-09-08 16:04 ` Dawid Wrobel
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2026-08-18 10:48 UTC (permalink / raw)
To: me, Jianhua Lu, Neil Armstrong, Jessica Zhang, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm
On 7/30/26 11:52 PM, Dawid Wróbel via B4 Relay wrote:
> From: Dawid Wróbel <me@dawidwrobel.com>
>
> The Mi Pad 5 Pro 5G (enuma, 2021) is the modem-equipped variant of the
> Mi Pad 5 Pro. The board is otherwise the elish design, so describe it as
> the common device tree plus its own board ID, panel compatible and WiFi
> board data variant.
[...]
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>
Happy new year!
> + */
> +
> +/dts-v1/;
> +
> +#include "sm8250-xiaomi-elish-common.dtsi"
> +
> +/ {
> + model = "Xiaomi Mi Pad 5 Pro 5G";
> + compatible = "xiaomi,enuma", "xiaomi,elish", "qcom,sm8250";
> +
> + /* Platform type differs from elish; msm-id is inherited unchanged. */
> + qcom,board-id = <0x2e 0>;
> +};
> +
> +&display_panel {
> + compatible = "xiaomi,enuma-csot-nt36523", "xiaomi,elish-csot-nt36523",
> + "novatek,nt36523";
> + status = "okay";
ultra nit: \n before status is preferred
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G
2026-08-18 10:48 ` Konrad Dybcio
@ 2026-09-08 16:04 ` Dawid Wrobel
0 siblings, 0 replies; 10+ messages in thread
From: Dawid Wrobel @ 2026-09-08 16:04 UTC (permalink / raw)
To: Konrad Dybcio, Jianhua Lu, Neil Armstrong, Jessica Zhang,
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm
On 18.08.2026 12:48, Konrad Dybcio wrote:
>> + * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>
>
> Happy new year!
Hah, indeed!
>> + status = "okay";
>
> ultra nit: \n before status is preferred
Thank you for the review. Both fixed in v3, which I just sent out:
https://lore.kernel.org/r/20260908-sm8250-xiaomi-enuma-v3-0-0198c3bf954a@dawidwrobel.com
Note that v2 had been on the list for two weeks when you reviewed this
one, so it may have slipped past you. It folds the WiFi-label patch into
this one per Krzysztof's feedback. I *did* carry your Reviewed-by onto
the v3 patch, though — let me know if you'd rather take another look on
that fold.
--
With Kind Regards,
Dawid Wrobel
^ permalink raw reply [flat|nested] 10+ messages in thread