mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string
@ 2024-10-30  8:57 Cheng Jiang
  2024-10-30  9:26 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Cheng Jiang @ 2024-10-30  8:57 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi,
	Rocky Liao
  Cc: linux-bluetooth, devicetree, linux-kernel, quic_chejiang

Add QCA6698 qcom,qca6698-bt compatible strings.

Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
---
 .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index 7bb68311c609..8ae1827e6a70 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -24,6 +24,7 @@ properties:
       - qcom,wcn3991-bt
       - qcom,wcn3998-bt
       - qcom,qca6390-bt
+      - qcom,qca6698-bt
       - qcom,wcn6750-bt
       - qcom,wcn6855-bt
       - qcom,wcn7850-bt
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string
  2024-10-30  8:57 [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string Cheng Jiang
@ 2024-10-30  9:26 ` Krzysztof Kozlowski
  2024-10-30  9:44   ` Cheng Jiang
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-30  9:26 UTC (permalink / raw)
  To: Cheng Jiang, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Balakrishna Godavarthi, Rocky Liao
  Cc: linux-bluetooth, devicetree, linux-kernel

On 30/10/2024 09:57, Cheng Jiang wrote:
> Add QCA6698 qcom,qca6698-bt compatible strings.
> 
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> index 7bb68311c609..8ae1827e6a70 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> @@ -24,6 +24,7 @@ properties:
>        - qcom,wcn3991-bt
>        - qcom,wcn3998-bt
>        - qcom,qca6390-bt
> +      - qcom,qca6698-bt

This looks incomplete. Does this device has really all these supplies?
Look at the binding.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string
  2024-10-30  9:26 ` Krzysztof Kozlowski
@ 2024-10-30  9:44   ` Cheng Jiang
  0 siblings, 0 replies; 3+ messages in thread
From: Cheng Jiang @ 2024-10-30  9:44 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Balakrishna Godavarthi, Rocky Liao
  Cc: linux-bluetooth, devicetree, linux-kernel

Hi Krzysztof,

Sorry, I miss the compatibility part and will submit a new version. 

On 10/30/2024 5:26 PM, Krzysztof Kozlowski wrote:
> On 30/10/2024 09:57, Cheng Jiang wrote:
>> Add QCA6698 qcom,qca6698-bt compatible strings.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
>> ---
>>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> index 7bb68311c609..8ae1827e6a70 100644
>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> @@ -24,6 +24,7 @@ properties:
>>        - qcom,wcn3991-bt
>>        - qcom,wcn3998-bt
>>        - qcom,qca6390-bt
>> +      - qcom,qca6698-bt
> 
> This looks incomplete. Does this device has really all these supplies?
> Look at the binding.
> 
> Best regards,
> Krzysztof
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-30  9:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-30  8:57 [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string Cheng Jiang
2024-10-30  9:26 ` Krzysztof Kozlowski
2024-10-30  9:44   ` Cheng Jiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®