From: "H. Peter Anvin" <hpa@zytor.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Borislav Petkov <bp@alien8.de>
Cc: Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Mikael Starvik <starvik@axis.com>,
the arch/x86 maintainers <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86
Date: Tue, 14 Feb 2017 10:46:29 -0800 [thread overview]
Message-ID: <1f27da30-12ec-831a-b722-9834a0d12de4@zytor.com> (raw)
In-Reply-To: <CAMuHMdUXUzOqqczZfdGznJVB10JzJyXJkLEDfEoK7QAwOkjpxA@mail.gmail.com>
On 02/14/17 09:56, Geert Uytterhoeven wrote:
>>
>> Well, almost. You need the wp_works_ok removal patch too, otherwise you
>> have the 3 bytes hole below.
>
> That's because you removed a char in commit 93a829e8e2c292f1
> ("x86, cpu: Convert FDIV bug detection), without compensating with padding ;-)
>
Padding isn't a problem (other than efficiency) for a structure which is
strictly internal to the kernel as opposed to an ABI structure.
-hpa
next prev parent reply other threads:[~2017-02-14 18:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 21:12 [PATCH 0/6] struct cpuinfo_x86 related cleanups Mathias Krause
2017-02-12 21:12 ` [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 Mathias Krause
2017-02-14 16:17 ` Borislav Petkov
2017-02-14 16:40 ` Mathias Krause
2017-02-14 17:56 ` Geert Uytterhoeven
2017-02-14 18:21 ` Borislav Petkov
2017-02-14 18:46 ` H. Peter Anvin [this message]
2017-03-11 13:34 ` [tip:x86/cpu] x86/cpu: Drop " tip-bot for Mathias Krause
2017-02-12 21:12 ` [PATCH 2/6] x86/cpu: drop wp_works_ok member " Mathias Krause
2017-03-11 13:34 ` [tip:x86/cpu] x86/cpu: Drop " tip-bot for Mathias Krause
2017-02-12 21:12 ` [PATCH 3/6] x86/cpu: proc - remove "wp" status line in cpuinfo Mathias Krause
2017-02-14 16:20 ` Borislav Petkov
2017-02-14 16:47 ` Mathias Krause
2017-02-14 17:11 ` Borislav Petkov
2017-02-14 18:13 ` H. Peter Anvin
2017-02-14 18:30 ` Borislav Petkov
2017-02-14 21:42 ` Mathias Krause
2017-02-28 7:15 ` Mathias Krause
2017-02-12 21:12 ` [PATCH 4/6] sparc: remove unused wp_works_ok macro Mathias Krause
2017-02-13 2:48 ` David Miller
2017-02-12 21:12 ` [PATCH 5/6] cris: " Mathias Krause
2017-02-13 9:18 ` Jesper Nilsson
2017-02-12 21:12 ` [PATCH 6/6] m68k: paging_init - remove dead code Mathias Krause
2017-02-13 9:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f27da30-12ec-831a-b722-9834a0d12de4@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hpa@linux.intel.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=starvik@axis.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®