Re: [PATCH 09/13] scsi: alua: Add scsi_alua_handle_state_transition()

[John Garry <john.g.garry@oracle.com>]

On 18/03/2026 07:58, Hannes Reinecke wrote:
>>   int scsi_alua_check_tpgs(struct scsi_device *sdev);
>>   int scsi_alua_rtpg_run(struct scsi_device *sdev);
>> @@ -39,6 +41,9 @@ int scsi_alua_init(void);
>>   void scsi_exit_alua(void);
>>   #else //CONFIG_SCSI_ALUA
>> +static inline void scsi_alua_handle_state_transition(struct 
>> scsi_device *sdev)
>> +{
>> +}
>>   static inline int scsi_alua_check_tpgs(struct scsi_device *sdev)
>>   {
>>       return 0;
> 
> ???
> This doesn't handle a state transition, it just _sets_ the state 
> transition. Please fold it into the patch where the state transition
> is actually handled.

Sure, doing it like this is a bit silly.

Thanks,
John