From: John Garry <john.g.garry@oracle.com>
To: Hannes Reinecke <hare@suse.de>,
martin.petersen@oracle.com,
james.bottomley@hansenpartnership.com, hare@suse.com,
bmarzins@redhat.com
Cc: jmeneghi@redhat.com, linux-scsi@vger.kernel.org,
michael.christie@oracle.com, snitzer@kernel.org,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/13] scsi: alua: Add scsi_alua_tur()
Date: Tue, 24 Mar 2026 10:49:16 +0000 [thread overview]
Message-ID: <d2a9c76d-885e-4b2c-afe9-3178408cffad@oracle.com> (raw)
In-Reply-To: <649e8a2b-b0b1-4eff-b2f5-56e37b7da980@oracle.com>
On 23/03/2026 13:42, John Garry wrote:
> On 18/03/2026 07:54, Hannes Reinecke wrote:
>>> /*
>>> * submit_rtpg - Issue a REPORT TARGET GROUP STATES command
>>> * @sdev: sdev the command should be sent to
>>
>> ???
>> And this function is useful _why_?
>> We're just sending a normal 'TEST UNIT READY', it has nothing to
>> do with ALUA. Why do we have a special function here?
>
> This is used in the STPG code, and I added the STPG code to scsi_alua.c
I meant to say that this is used in RTPG code from the following:
commit 9d2c30395213166e0b5614fe97576a789864e5de
Author: Hannes Reinecke <hare@suse.de>
Date: Fri Feb 19 09:17:15 2016 +0100
scsi_dh_alua: Send TEST UNIT READY to poll for transitioning
Sending a 'REPORT TARGET PORT GROUP' command is a costly operation,
as the array has to gather information about all ports.
So instead of using RTPG to poll for a status update when a port
is in transitioning we should be sending a TEST UNIT READY, and
wait for the sense code to report success.
next prev parent reply other threads:[~2026-03-24 10:49 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 12:06 [PATCH 00/13] scsi: Core ALUA driver John Garry
2026-03-17 12:06 ` [PATCH 01/13] scsi: scsi_dh_alua: Delete alua_port_group John Garry
2026-03-18 7:44 ` Hannes Reinecke
2026-03-18 8:53 ` John Garry
2026-03-23 0:08 ` Benjamin Marzinski
2026-03-23 10:33 ` John Garry
2026-03-23 16:15 ` Benjamin Marzinski
2026-03-23 18:07 ` John Garry
2026-03-17 12:06 ` [PATCH 02/13] scsi: alua: Create a core ALUA driver John Garry
2026-03-18 7:47 ` Hannes Reinecke
2026-03-23 12:56 ` John Garry
2026-03-18 17:17 ` kernel test robot
2026-03-18 22:54 ` kernel test robot
2026-03-17 12:06 ` [PATCH 03/13] scsi: alua: Add scsi_alua_rtpg() John Garry
2026-03-18 7:50 ` Hannes Reinecke
2026-03-23 12:58 ` John Garry
2026-03-17 12:06 ` [PATCH 04/13] scsi: alua: Add scsi_alua_stpg() John Garry
2026-03-18 7:53 ` Hannes Reinecke
2026-03-17 12:06 ` [PATCH 05/13] scsi: alua: Add scsi_alua_tur() John Garry
2026-03-18 7:54 ` Hannes Reinecke
2026-03-23 13:42 ` John Garry
2026-03-24 10:49 ` John Garry [this message]
2026-03-17 12:06 ` [PATCH 06/13] scsi: alua: Add scsi_alua_rtpg_run() John Garry
2026-03-17 12:06 ` [PATCH 07/13] scsi: alua: Add scsi_alua_stpg_run() John Garry
2026-03-18 7:57 ` Hannes Reinecke
2026-03-18 8:59 ` John Garry
2026-03-18 9:24 ` Hannes Reinecke
2026-03-23 13:58 ` John Garry
2026-03-17 12:06 ` [PATCH 08/13] scsi: alua: Add scsi_alua_check_tpgs() John Garry
2026-03-18 7:57 ` Hannes Reinecke
2026-03-17 12:06 ` [PATCH 09/13] scsi: alua: Add scsi_alua_handle_state_transition() John Garry
2026-03-18 7:58 ` Hannes Reinecke
2026-03-23 13:43 ` John Garry
2026-03-17 12:07 ` [PATCH 10/13] scsi: alua: Add scsi_alua_prep_fn() John Garry
2026-03-18 8:01 ` Hannes Reinecke
2026-03-23 13:49 ` John Garry
2026-03-17 12:07 ` [PATCH 11/13] scsi: alua: Add scsi_device_alua_implicit() John Garry
2026-03-18 8:02 ` Hannes Reinecke
2026-03-23 13:50 ` John Garry
2026-03-17 12:07 ` [PATCH 12/13] scsi: scsi_dh_alua: Switch to use core support John Garry
2026-03-23 1:47 ` Benjamin Marzinski
2026-03-23 11:59 ` John Garry
2026-03-17 12:07 ` [PATCH 13/13] scsi: core: Add implicit ALUA support John Garry
2026-03-18 8:08 ` Hannes Reinecke
2026-03-18 23:08 ` kernel test robot
2026-03-23 1:58 ` Benjamin Marzinski
2026-03-23 12:52 ` John Garry
2026-03-23 17:29 ` Benjamin Marzinski
2026-03-23 18:13 ` John Garry
2026-03-22 17:37 ` [PATCH 00/13] scsi: Core ALUA driver Benjamin Marzinski
2026-03-23 9:57 ` John Garry
2026-03-23 16:25 ` Benjamin Marzinski
2026-03-23 18:04 ` John Garry
2026-03-23 19:45 ` Benjamin Marzinski
2026-03-24 10:57 ` John Garry
2026-03-24 13:58 ` Benjamin Marzinski
2026-03-24 15:12 ` John Garry
2026-03-24 15:48 ` Benjamin Marzinski
2026-03-24 16:25 ` John Garry
2026-03-26 10:19 ` Hannes Reinecke
2026-03-26 12:16 ` John Garry
2026-03-27 7:02 ` Hannes Reinecke
2026-03-26 10:17 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2a9c76d-885e-4b2c-afe9-3178408cffad@oracle.com \
--to=john.g.garry@oracle.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=jmeneghi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome