From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: John Ruttenberg <rutt@chezrutt.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)
Date: Tue, 9 Jan 2001 09:04:27 -0800 [thread overview]
Message-ID: <20010109090427.A30175@bougret.hpl.hp.com> (raw)
In-Reply-To: <200101091217.f09CH1n01252@mojo.chezrutt.com>
In-Reply-To: <200101091217.f09CH1n01252@mojo.chezrutt.com>; from rutt@chezrutt.com on Tue, Jan 09, 2001 at 07:17:01AM -0500
On Tue, Jan 09, 2001 at 07:17:01AM -0500, John Ruttenberg wrote:
> I get:
>
> Jan 9 07:04:51 mojo cardmgr[511]: socket 1: Digital RoamAbout/DS
> Jan 9 07:04:52 mojo cardmgr[511]: executing: 'modprobe wavelan_cs'
> Jan 9 07:04:52 mojo cardmgr[511]: + /lib/modules/2.4.0-test11/pcmcia/wavelan_cs.o: unresolved symbol __bad_udelay
> Jan 9 07:04:52 mojo cardmgr[511]: + /lib/modules/2.4.0-test11/pcmcia/wavelan_cs.o: insmod /lib/modules/2.4.0-test11/pcmcia/wavelan_cs.o failed
> Jan 9 07:04:52 mojo cardmgr[511]: + /lib/modules/2.4.0-test11/pcmcia/wavelan_cs.o: insmod wavelan_cs failed
> Jan 9 07:04:52 mojo cardmgr[511]: modprobe exited with status 255
> Jan 9 07:04:52 mojo cardmgr[511]: executing: 'insmod /lib/modules/2.4.0/pcmcia/wavelan_cs.o'
> Jan 9 07:04:52 mojo cardmgr[511]: + /lib/modules/2.4.0/pcmcia/wavelan_cs.o: unresolved symbol __bad_udelay
> Jan 9 07:04:52 mojo cardmgr[511]: insmod exited with status 1
This is a bug with the definition of udelay(). Somebody tried
to be too clever with udelay(), and the end result is that it breaks
perfectly good and valid code.
Therefore, it should be reported as such on LKML, a bug in udelay().
I think that Alan has a ugly workaround for this driver (or
maybe it's only for wavelan.c) in the ac4 tree, so please check
there. For my part, I insist that the code is correct, that replacing
an inline function by a #define is going backwards and that udelay()
should be fixed one way or another (easy, just define __bad_udelay()
as returning a compilation warning or an error message).
Also, please remember that the version of wavelan_cs.c in the
kernel is outdated with respect to the version in the Pcmcia package.
That's it...
Jean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next parent reply other threads:[~2001-01-09 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200101091217.f09CH1n01252@mojo.chezrutt.com>
2001-01-09 17:04 ` Jean Tourrilhes [this message]
2001-01-09 17:13 ` Alan Cox
2001-01-09 17:42 ` Jean Tourrilhes
2001-01-09 17:48 ` Alan Cox
2001-01-09 17:58 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010109090427.A30175@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rutt@chezrutt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®