From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jt@hpl.hp.com, John Ruttenberg <rutt@chezrutt.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)
Date: Tue, 9 Jan 2001 09:42:17 -0800 [thread overview]
Message-ID: <20010109094217.A30225@bougret.hpl.hp.com> (raw)
In-Reply-To: <20010109090427.A30175@bougret.hpl.hp.com> <E14G2LB-0006zy-00@the-village.bc.nu>
In-Reply-To: <E14G2LB-0006zy-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Tue, Jan 09, 2001 at 05:13:42PM +0000
On Tue, Jan 09, 2001 at 05:13:42PM +0000, Alan Cox wrote:
> > This is a bug with the definition of udelay(). Somebody tried
> > to be too clever with udelay(), and the end result is that it breaks
> > perfectly good and valid code.
> > Therefore, it should be reported as such on LKML, a bug in udelay().
>
> It is a bug in the driver.
Please check again the code and point me the invalid
udelay(). You will realise that there is no delay in the driver that
is longer than 100ms.
The bug is that udelay() can't be passed a variable but only a
constant. Therefore bug in udelay().
> > there. For my part, I insist that the code is correct, that replacing
> > an inline function by a #define is going backwards and that udelay()
> > should be fixed one way or another (easy, just define __bad_udelay()
> > as returning a compilation warning or an error message).
>
> You can't #define a function to a #warning or #error in C. Language limitation
Yes. Tough.
Jean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-09 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200101091217.f09CH1n01252@mojo.chezrutt.com>
2001-01-09 17:04 ` Jean Tourrilhes
2001-01-09 17:13 ` Alan Cox
2001-01-09 17:42 ` Jean Tourrilhes [this message]
2001-01-09 17:48 ` Alan Cox
2001-01-09 17:58 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010109094217.A30225@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rutt@chezrutt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®